You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "younsl (via GitHub)" <gi...@apache.org> on 2026/10/16 18:10:29 UTC
[PR] docs(architecture): drop removed status fields from internals [superset-kubernetes-operator]
younsl opened a new pull request, #452:
URL: https://github.com/apache/superset-kubernetes-operator/pull/452
## Summary
The internals page still shows status fields that the API no longer has, plus two smaller wording mistakes. The parent status example lists ready and ref on component entries and ref on the migrate task, but ComponentRefStatus and TaskRefStatus have neither field. A reader who compares the example with kubectl output looks for fields that are never set. This PR brings the page in line with the API and the code. It changes docs only.
## Details
- Parent status example: removed ready and ref from the component entries and ref from the migrate entry. The Celery worker and beat entries now show replicas and readyReplicas, which ComponentRefStatus does have. The top-level ready field stays, since SupersetStatus still has it.
- Status Aggregation: "ready count, replica details" becomes "replica counts", matching the same change.
- DeploymentConfig snippet: the ContainerName comment said "superset-web-server". Every component uses the reserved container name superset (common.Container), so the comment now says that.
- Ingress, HTTPRoute, ServiceMonitor and NetworkPolicy were called cluster-scoped. They are all namespaced and belong to one Superset instance, so the sentence now calls them instance-level resources.
<details>
<summary>Verification</summary>
- Field lists checked against SupersetStatus, ComponentRefStatus and TaskRefStatus in api/v1alpha1/superset_types.go, and container names against ComponentResourceDefs in internal/controller/component_resources.go.
- make lint-md passes.
- mkdocs build in strict mode passes with the pinned docs requirements.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(architecture): drop removed status fields from internals [superset-kubernetes-operator]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #452:
URL: https://github.com/apache/superset-kubernetes-operator/pull/452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(architecture): drop removed status fields from internals [superset-kubernetes-operator]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #452:
URL: https://github.com/apache/superset-kubernetes-operator/pull/452#issuecomment-6224704607
## [Codecov](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/452?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 93.20%. Comparing base ([`b4e8545`](https://app.codecov.io/gh/apache/superset-kubernetes-operator/commit/b4e8545cbfcc8f4bc23caf175c4fa315a77d3262?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2aa0153`](https://app.codecov.io/gh/apache/superset-kubernetes-operator/commit/2aa0153d86f314ea19a909dac2789e665fe29583?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/452?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org