You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/11 18:26:52 UTC
[GitHub] [spark] allisonwang-db commented on a change in pull request #34237: [SPARK-36970][SQL] Manual disabled format `B` of `date_format` function to make Java 17 compatible with Java 8
allisonwang-db commented on a change in pull request #34237:
URL: https://github.com/apache/spark/pull/34237#discussion_r726488711
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -280,6 +280,7 @@ private object DateTimeFormatterHelper {
// 2.4, the SimpleDateFormat uses Monday as the first day of week.
final val weekBasedLetters = Set('Y', 'W', 'w', 'u', 'e', 'c')
final val unsupportedLetters = Set('A', 'n', 'N', 'p')
+ final val unknownPatternLetters: Set[Char] = Set('B')
Review comment:
Awesome thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org