You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/18 20:38:06 UTC
[GitHub] [superset] geido opened a new issue #12587: Explore(modal) cancel button should come before the save button
geido opened a new issue #12587:
URL: https://github.com/apache/superset/issues/12587
## Screenshot
<img width="905" alt="Screen Shot 2021-01-18 at 21 35 04" src="https://user-images.githubusercontent.com/60598000/104960770-31013180-59d5-11eb-83ef-720f38a760c2.png">
## Description
The "SAVE" button should be the last button in the footer of the modal, just after the "CANCEL" one to make it consistent with the other modals in the project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12587: [Explore]modal cancel button should come before the save button
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12587:
URL: https://github.com/apache/superset/issues/12587#issuecomment-762641465
please make sure changes apply to both edit and change dataset modal in Explore. thanks! @geido
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on issue #12587: [Explore]modal cancel button should come before the save button
Posted by GitBox <gi...@apache.org>.
geido commented on issue #12587:
URL: https://github.com/apache/superset/issues/12587#issuecomment-762912310
@junlincc it looks like the Change Dataset modal already has the buttons in the right position when you pick a new dataset. Is there anything else you are looking to change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas closed issue #12587: [Explore]modal cancel button should come before the save button
Posted by GitBox <gi...@apache.org>.
rusackas closed issue #12587:
URL: https://github.com/apache/superset/issues/12587
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on issue #12587: Explore(modal) cancel button should come before the save button
Posted by GitBox <gi...@apache.org>.
geido commented on issue #12587:
URL: https://github.com/apache/superset/issues/12587#issuecomment-762460672
I'll be fixing this one @junlincc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org