You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/09/09 22:14:12 UTC
[GitHub] [zookeeper] colinmcintosh opened a new pull request #1751: ZOOKEEPER-4372: Added check and unit test for negative sequence numbers in lock recipe
colinmcintosh opened a new pull request #1751:
URL: https://github.com/apache/zookeeper/pull/1751
I took a stab at fixing this and adding a simple case to one of the existing unit tests to check for negative sequence numbers. This is my first time working in the ZK Java implementation so please let me know if I need to make any adjustments. I updated the code to check if there is a prior "-" character in the index before the last "-" and move the index back one if there is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1751: ZOOKEEPER-4372: Added check and unit test for negative sequence numbers in lock recipe
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1751:
URL: https://github.com/apache/zookeeper/pull/1751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1751: ZOOKEEPER-4372: Added check and unit test for negative sequence numbers in lock recipe
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1751:
URL: https://github.com/apache/zookeeper/pull/1751#issuecomment-932689342
@colinmcintosh
Thanks for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling closed pull request #1751: ZOOKEEPER-4372: Added check and unit test for negative sequence numbers in lock recipe
Posted by GitBox <gi...@apache.org>.
maoling closed pull request #1751:
URL: https://github.com/apache/zookeeper/pull/1751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] colinmcintosh commented on pull request #1751: ZOOKEEPER-4372: Added check and unit test for negative sequence numbers in lock recipe
Posted by GitBox <gi...@apache.org>.
colinmcintosh commented on pull request #1751:
URL: https://github.com/apache/zookeeper/pull/1751#issuecomment-930396060
Thanks! Yes, I agree using "_" would probably be better than "-" but my intent was to maintain compatibility for anyone using the existing lock recipe directly which would require checking for "-".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1751: ZOOKEEPER-4372: Added check and unit test for negative sequence numbers in lock recipe
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1751:
URL: https://github.com/apache/zookeeper/pull/1751#issuecomment-930075089
@colinmcintosh LGTM. If no other concerns, I'll merge it at this weekend(10-03).
Think further, using "_" is better than "-" to avoid the confusion between separator and minus sign
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1751: ZOOKEEPER-4372: Added check and unit test for negative sequence numbers in lock recipe
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1751:
URL: https://github.com/apache/zookeeper/pull/1751#issuecomment-930075089
@colinmcintosh LGTM. If no other concerns, I'll merge it at this weekend(10-03).
Think further, using "_" is better than "-" to avoid the confusion between separator and minus sign
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] colinmcintosh commented on pull request #1751: ZOOKEEPER-4372: Added check and unit test for negative sequence numbers in lock recipe
Posted by GitBox <gi...@apache.org>.
colinmcintosh commented on pull request #1751:
URL: https://github.com/apache/zookeeper/pull/1751#issuecomment-930396060
Thanks! Yes, I agree using "_" would probably be better than "-" but my intent was to maintain compatibility for anyone using the existing lock recipe directly which would require checking for "-".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org