You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Jeremias Maerki <de...@jeremias-maerki.ch> on 2005/12/19 17:05:58 UTC
Font work (CLA needed)
Vincent,
I'm sorry. I almost forgot about your patch. I started working on the
intermediate format and realized that I would need to do some changes
related to font handling in the area tree. Not a good idea if bigger
changes are waiting. I'm going to look at your patch tomorrow morning
(CET). In the meantime, please get a signed ICLA (and a CCLA, if
necessary) to the ASF's secretary. Details here:
http://www.apache.org/licenses/#clas
Thanks a lot!
Jeremias Maerki
Re: Eclipse and JUnit
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
On 21.12.2005 14:50:58 Simon Pepping wrote:
> On Wed, Dec 21, 2005 at 11:03:59AM +0100, Jeremias Maerki wrote:
> > Yes, digging up the right system properties is a nuisance, but you only
> > have to do it once. Have a look at the attached screen shots that show
> > how I set up the launch config for running the FOP test suite. You can
> > see that I simply add an "x" somewhere to effectively disable the
> > setting for a system property. Like this I'm can change the parameters to
> > the test suite very quickly. Maybe that helps make things easier.
>
> Thanks. The "x" is a nice trick.
>
> It would be good to have a document describing the system properties
> of the test suites. If you do not do it, I will write one.
I've started documentation about the layout engine test suite here:
http://wiki.apache.org/xmlgraphics-fop/HowToCreateLayoutEngineTests
I'm going to add some notes about the various system properties in a few
minutes.
> I see you have a project 'FOP Temp', which probably is a copy of
> project FOP. I have a problem making a copy of a project, when I make
> a copy of the working directory for a specific task. Esp. one has to
> duplicate the lauch configurations. I solve it by reusing the same
> symlink on Unix. Is there an easier way to work with a changing set of
> copies of the working directory?
Well, being on Windows I don't have symlinks. I simply check out from
the same SVN URL again and switch the project dependency in my project
with my custom FOP test code from one FOP checkout to the other. Not
ideal but not a big deal for me.
Jeremias Maerki
Re: Eclipse and JUnit
Posted by Simon Pepping <sp...@leverkruid.nl>.
On Wed, Dec 21, 2005 at 11:03:59AM +0100, Jeremias Maerki wrote:
> Yes, digging up the right system properties is a nuisance, but you only
> have to do it once. Have a look at the attached screen shots that show
> how I set up the launch config for running the FOP test suite. You can
> see that I simply add an "x" somewhere to effectively disable the
> setting for a system property. Like this I'm can change the parameters to
> the test suite very quickly. Maybe that helps make things easier.
Thanks. The "x" is a nice trick.
It would be good to have a document describing the system properties
of the test suites. If you do not do it, I will write one.
I see you have a project 'FOP Temp', which probably is a copy of
project FOP. I have a problem making a copy of a project, when I make
a copy of the working directory for a specific task. Esp. one has to
duplicate the lauch configurations. I solve it by reusing the same
symlink on Unix. Is there an easier way to work with a changing set of
copies of the working directory?
Simon
--
Simon Pepping
home page: http://www.leverkruid.nl
Re: Eclipse and JUnit
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
Yes, digging up the right system properties is a nuisance, but you only
have to do it once. Have a look at the attached screen shots that show
how I set up the launch config for running the FOP test suite. You can
see that I simply add an "x" somewhere to effectively disable the
setting for a system property. Like this I'm can change the parameters to
the test suite very quickly. Maybe that helps make things easier.
On 21.12.2005 10:46:33 Simon Pepping wrote:
> On Wed, Dec 21, 2005 at 09:48:52AM +0100, Jeremias Maerki wrote:
> > That's very unfortunate. Can you guys explain to me what exactly the
> > problems are? Maybe I can help. It is very helpful to simply run a
> > single test under JUnit control directly from Eclipse. I simply have to
> > specify the test case I want to run in the system properties and off I
> > go.
>
> Running a single test is always a problem, with ant and with
> eclipse. The point is just that I do not do this often, and everytime
> I have to look through the test suite code to dig up the exact system
> property to set.
>
> Eclipse is a bewildering huge beast when you start with it. I have
> just spent some time learning how to use it properly, and now I feel
> more comfortable with it. I suppose it is a matter of habit. At the
> moment I happen to write scripts more easily than eclipse launch
> configurations. So I tend to avoid complications and use the simplest
> solution.
Jeremias Maerki
Re: Eclipse and JUnit
Posted by Simon Pepping <sp...@leverkruid.nl>.
On Wed, Dec 21, 2005 at 09:48:52AM +0100, Jeremias Maerki wrote:
> That's very unfortunate. Can you guys explain to me what exactly the
> problems are? Maybe I can help. It is very helpful to simply run a
> single test under JUnit control directly from Eclipse. I simply have to
> specify the test case I want to run in the system properties and off I
> go.
Running a single test is always a problem, with ant and with
eclipse. The point is just that I do not do this often, and everytime
I have to look through the test suite code to dig up the exact system
property to set.
Eclipse is a bewildering huge beast when you start with it. I have
just spent some time learning how to use it properly, and now I feel
more comfortable with it. I suppose it is a matter of habit. At the
moment I happen to write scripts more easily than eclipse launch
configurations. So I tend to avoid complications and use the simplest
solution.
Simon
--
Simon Pepping
home page: http://www.leverkruid.nl
Re: Eclipse and JUnit [was: Re: Font work (CLA needed)]
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
That's very unfortunate. Can you guys explain to me what exactly the
problems are? Maybe I can help. It is very helpful to simply run a
single test under JUnit control directly from Eclipse. I simply have to
specify the test case I want to run in the system properties and off I
go.
On 21.12.2005 09:34:07 Simon Pepping wrote:
> On Mon, Dec 19, 2005 at 08:52:59PM +0100, Jeremias Maerki wrote:
> >
> > On 19.12.2005 20:06:26 Vincent Hennebert wrote:
> > > Moreover my patched Fop still doesn't pass the unitary tests. I'm trying to
> > > figure out what is going on but so far I've spent more time fighting against
> > > Eclipse to make the debugger work on the junit system than searching for errors.
> > > Not sure yet if I've won.
> >
> > Hmm, so far I've had no problems debugging inside Eclipse's JUnit
> > environment.
>
> I try to avoid it by running fop directly with the XSL stylesheet
> test/layoutengine/testcase2fo.xsl, or I even generate the FO using
> this stylesheet.
>
> Maybe unnecessary, but if you are not so experienced with eclipse, you
> can have a hard time to make it do what you want. Avoiding JUnit in
> the debugging process helps me.
>
> Simon
>
> --
> Simon Pepping
> home page: http://www.leverkruid.nl
Jeremias Maerki
Eclipse and JUnit [was: Re: Font work (CLA needed)]
Posted by Simon Pepping <sp...@leverkruid.nl>.
On Mon, Dec 19, 2005 at 08:52:59PM +0100, Jeremias Maerki wrote:
>
> On 19.12.2005 20:06:26 Vincent Hennebert wrote:
> > Moreover my patched Fop still doesn't pass the unitary tests. I'm trying to
> > figure out what is going on but so far I've spent more time fighting against
> > Eclipse to make the debugger work on the junit system than searching for errors.
> > Not sure yet if I've won.
>
> Hmm, so far I've had no problems debugging inside Eclipse's JUnit
> environment.
I try to avoid it by running fop directly with the XSL stylesheet
test/layoutengine/testcase2fo.xsl, or I even generate the FO using
this stylesheet.
Maybe unnecessary, but if you are not so experienced with eclipse, you
can have a hard time to make it do what you want. Avoiding JUnit in
the debugging process helps me.
Simon
--
Simon Pepping
home page: http://www.leverkruid.nl
Re: Font work (CLA needed)
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
On 19.12.2005 20:06:26 Vincent Hennebert wrote:
> Jeremias Maerki a écrit :
> > Vincent,
> >
> > I'm sorry. I almost forgot about your patch.
>
> Fop is free software, and as such work is done when time is available.
> So no need to worry ;-)
>
> Moreover my patched Fop still doesn't pass the unitary tests. I'm trying to
> figure out what is going on but so far I've spent more time fighting against
> Eclipse to make the debugger work on the junit system than searching for errors.
> Not sure yet if I've won.
Hmm, so far I've had no problems debugging inside Eclipse's JUnit
environment.
> > I started working on the
> > intermediate format and realized that I would need to do some changes
> > related to font handling in the area tree. Not a good idea if bigger
> > changes are waiting. I'm going to look at your patch tomorrow morning
> > (CET). In the meantime, please get a signed ICLA (and a CCLA, if
> > necessary) to the ASF's secretary. Details here:
> > http://www.apache.org/licenses/#clas
>
> ICLA faxed a few minutes ago. No need for CCLA, it's a personal work.
> While we are on the legal issues, I've taken from FOray an entire class
> (PDFFontFileStream) plus some lines of code (put in PDFFont). It is perhaps time
> to contact Victor? How, what, when, etc. ?
Thanks for handling the ICLA so quickly. Concerning PDFFontFileStream:
Yes, we need to contact Victor. As far as I remember he was ok for us to
reuse part of his work but due to ASF license policy I think we still
need some action by Victor (license grant probably). When Adam sent his
ToUnicode patch I asked a question about how to handle his case (quite
similar here) on legal-discuss, but so far I haven't received an answer.
I guess I need to ping again.
Jeremias Maerki (hates legal stuff but has to be a role model. Grrr)
Re: Font work (CLA needed)
Posted by Vincent Hennebert <vi...@enseeiht.fr>.
Jeremias Maerki a écrit :
> Vincent,
>
> I'm sorry. I almost forgot about your patch.
Fop is free software, and as such work is done when time is available.
So no need to worry ;-)
Moreover my patched Fop still doesn't pass the unitary tests. I'm trying to
figure out what is going on but so far I've spent more time fighting against
Eclipse to make the debugger work on the junit system than searching for errors.
Not sure yet if I've won.
> I started working on the
> intermediate format and realized that I would need to do some changes
> related to font handling in the area tree. Not a good idea if bigger
> changes are waiting. I'm going to look at your patch tomorrow morning
> (CET). In the meantime, please get a signed ICLA (and a CCLA, if
> necessary) to the ASF's secretary. Details here:
> http://www.apache.org/licenses/#clas
ICLA faxed a few minutes ago. No need for CCLA, it's a personal work.
While we are on the legal issues, I've taken from FOray an entire class
(PDFFontFileStream) plus some lines of code (put in PDFFont). It is perhaps time
to contact Victor? How, what, when, etc. ?
Thanks,
Vincent
Re: Font work (CLA needed)
Posted by Adam Strzelecki <on...@java.pl>.
> Anyone who submits more than just a small patch on an existing source
> file should submit an ICLA (and if necessary a CCLA). Basically as soon
> as a new file is involved an ICLA becomes necessary. If you intend to
> submit more patches in the future then you, too, should think about
> submitting an ICLA to avoid delays processing a bigger patch.
> HTH
Great thanks.
I'm much into paperwork madness lately so thought it may be about me
heh, .. I'm living in Poland, working for French company.. and now
fixing business trip to Australia :> and everything produces lot of
papers & form.
Cheers,
--
Adam Strzelecki |: nanoant.com :|
Re: Font work (CLA needed)
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
As far as I know there are no stupid questions. :-)
The recipient is mainly Vincent Hennebert.
Anyone who submits more than just a small patch on an existing source
file should submit an ICLA (and if necessary a CCLA). Basically as soon
as a new file is involved an ICLA becomes necessary. If you intend to
submit more patches in the future then you, too, should think about
submitting an ICLA to avoid delays processing a bigger patch.
HTH
On 19.12.2005 17:33:00 Adam Strzelecki wrote:
> Hi,
>
> > I'm sorry. I almost forgot about your patch. I started working on the
> > intermediate format and realized that I would need to do some changes
> > related to font handling in the area tree. Not a good idea if bigger
> > changes are waiting. I'm going to look at your patch tomorrow morning
> > (CET). In the meantime, please get a signed ICLA (and a CCLA, if
> > necessary) to the ASF's secretary. Details here:
> > http://www.apache.org/licenses/#clas
>
> Just a stupid question.. who is supposed to be recipient of this
> information ;)
> Because since I submitted some patched but no ICLA yet.. maybe me ?
>
> Regards,
> --
> Adam Strzelecki |: nanoant.com :|
Jeremias Maerki
Re: Font work (CLA needed)
Posted by Adam Strzelecki <on...@java.pl>.
Hi,
> I'm sorry. I almost forgot about your patch. I started working on the
> intermediate format and realized that I would need to do some changes
> related to font handling in the area tree. Not a good idea if bigger
> changes are waiting. I'm going to look at your patch tomorrow morning
> (CET). In the meantime, please get a signed ICLA (and a CCLA, if
> necessary) to the ASF's secretary. Details here:
> http://www.apache.org/licenses/#clas
Just a stupid question.. who is supposed to be recipient of this
information ;)
Because since I submitted some patched but no ICLA yet.. maybe me ?
Regards,
--
Adam Strzelecki |: nanoant.com :|