[jira] [Commented] (CASSANDRA-6389) Check first and last key to potentially skip SSTable for reads

["Jonathan Ellis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-6389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830351#comment-13830351 ] 

Jonathan Ellis commented on CASSANDRA-6389:
-------------------------------------------

On second look, this isn't as critical as I thought since intervaltree should keep the query-set to tables that satisfy the condition anyway.

If that's the case, maybe we can just change this to an assert to make sure.

> Check first and last key to potentially skip SSTable for reads
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-6389
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6389
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Tyler Hobbs
>            Assignee: Tyler Hobbs
>            Priority: Minor
>         Attachments: 6389.patch
>
>
> In {{SSTableReader.getPosition()}}, we use a -1 result from a binary search on the index summary to check if the requested key falls before the start of the sstable.  Instead, we can directly compare the requested key with the {{first}} and {{last}} keys for the sstable, which will allow us to also skip keys that fall after the last key in the sstable.



--
This message was sent by Atlassian JIRA
(v6.1#6144)