You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "zihaoAK47 (via GitHub)" <gi...@apache.org> on 2023/06/25 14:04:20 UTC
[GitHub] [shardingsphere] zihaoAK47 opened a new pull request, #26555: Add table rule in identifierKeywordsUnambiguous
zihaoAK47 opened a new pull request, #26555:
URL: https://github.com/apache/shardingsphere/pull/26555
Refer #25535.
Changes proposed in this pull request:
- EXECUTE ps1 USING @expected, @db, @table
- Add table rule in identifierKeywordsUnambiguous
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ✓] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ✓] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ✓] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ✓] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zihaoAK47 commented on pull request #26555: Add table rule in identifierKeywordsUnambiguous
Posted by "zihaoAK47 (via GitHub)" <gi...@apache.org>.
zihaoAK47 commented on PR #26555:
URL: https://github.com/apache/shardingsphere/pull/26555#issuecomment-1606115396
@strongduanmu Please review thank :smirk:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #26555: Add table rule in identifierKeywordsUnambiguous
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #26555:
URL: https://github.com/apache/shardingsphere/pull/26555#issuecomment-1609251226
> @strongduanmu Hi mentor, I have added the test but this error occurred in CI `Error: Failed to execute goal on project shardingsphere-test-e2e-sql: Could not resolve dependencies for project org.apache.shardingsphere:shardingsphere-test-e2e-sql:jar:5.3.3-SNAPSHOT: Could not find artifact org.apache.shardingsphere:shardingsphere-test-e2e-env:jar:tests:5.3.3-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots) -> [Help 1]` The above error seems to be that the corresponding jar package was not found in the repository. This error often appears in my submitted PR. Can you tell me how to solve it? Thank you.
I have triggered the ci, let's see the new result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zihaoAK47 commented on pull request #26555: Add table rule in identifierKeywordsUnambiguous
Posted by "zihaoAK47 (via GitHub)" <gi...@apache.org>.
zihaoAK47 commented on PR #26555:
URL: https://github.com/apache/shardingsphere/pull/26555#issuecomment-1609457944
> > @strongduanmu Hi mentor, I have added the test but this error occurred in CI `Error: Failed to execute goal on project shardingsphere-test-e2e-sql: Could not resolve dependencies for project org.apache.shardingsphere:shardingsphere-test-e2e-sql:jar:5.3.3-SNAPSHOT: Could not find artifact org.apache.shardingsphere:shardingsphere-test-e2e-env:jar:tests:5.3.3-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots) -> [Help 1]` The above error seems to be that the corresponding jar package was not found in the repository. This error often appears in my submitted PR. Can you tell me how to solve it? Thank you.
>
> I have triggered the ci, let's see the new result.
Aha, everything has passed the inspection :blush:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zihaoAK47 commented on pull request #26555: Add table rule in identifierKeywordsUnambiguous
Posted by "zihaoAK47 (via GitHub)" <gi...@apache.org>.
zihaoAK47 commented on PR #26555:
URL: https://github.com/apache/shardingsphere/pull/26555#issuecomment-1608996008
@strongduanmu
Hi mentor, I have added the test but this error occurred in CI
`
Error: Failed to execute goal on project shardingsphere-test-e2e-sql: Could not resolve dependencies for project org.apache.shardingsphere:shardingsphere-test-e2e-sql:jar:5.3.3-SNAPSHOT: Could not find artifact org.apache.shardingsphere:shardingsphere-test-e2e-env:jar:tests:5.3.3-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots) -> [Help 1]
`
The above error seems to be that the corresponding jar package was not found in the repository.
This error often appears in my submitted PR. Can you tell me how to solve it? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #26555: Add table rule in identifierKeywordsUnambiguous
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #26555:
URL: https://github.com/apache/shardingsphere/pull/26555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org