[jira] [Reopened] (OFBIZ-6895) Product price rule with no conditions.

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-6895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-6895:
------------------------------------

> Product price rule with no conditions. 
> ---------------------------------------
>
>                 Key: OFBIZ-6895
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6895
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>
> I'm currently closing pending stuff, here is one
> Skip reported this 2 years ago on user ML:
> {quote}
> I recently had a user accidentially create a product price rule with no
> conditions.  This resulted in all products sold afterwards getting the
> discounted price (-5% price) set by the action.
> After tracking this down, I added some code in PriceServices.java to check
> if there were no price conditions and if so, set the local variable alltrue
> to false.  This fixes it for me.
> I am debating whether or not to add a Jira for this issue.  Was this
> intended and can anyone see any value in this behavior?
> Skip
> {quote}
> I then answered
> {quote}
> I'd create a Jira. It looks like a miss to me, the check you do seems good. I'd
> also prevent users to create such rules from UI
> Maybe we could add a properties, in case someone would like to use a such
> scenario (could be used for temporarily give a percent on all products)?
> {quote}
> Jacques



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)