You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by Ruwan Linton <ru...@gmail.com> on 2009/03/22 16:11:40 UTC
Re: [jira] Resolved: (SYNAPSE-521) Send Synapse generated Hessian
faults with HTTP status 200
Well, even earlier we should have removed it, with th introduction of the
HTTP_SC property to the message..... but we kept that for the backward
compatibility...
Don't we need to keep this as deprecated for this release?
Thanks,
Ruwan
On Sat, Mar 21, 2009 at 1:30 PM, Hubert, Eric <Er...@foxmobile.com>wrote:
> Hi,
>
> It seems like we have a Jira downtime so I answer directly on the list.
>
> > Asankha C. Perera resolved SYNAPSE-521.
> > ---------------------------------------
> >
> > Resolution: Fixed
> > Assignee: Asankha C. Perera
> >
> > Thanks Eric for the fix. I just removed an unused constant "HTTP_SC_OK"
> > from the NhttpConstants
>
> Asankha, thanks for reviewing and committing and sorry about forgetting to
> remove the now unused constant. This has been a remaining of the alternative
> solution using the FaultMediator to set the HTTP 200 status code.
> With the latest approach it was possible to use the int constants of
> HttpStatus directly.
>
> Regards,
> Eric
>
--
Ruwan Linton
Senior Software Engineer & Product Manager; WSO2 ESB; http://wso2.org/esb
WSO2 Inc.; http://wso2.org
email: ruwan@wso2.com; cell: +94 77 341 3097
blog: http://ruwansblog.blogspot.com
Re: [jira] Resolved: (SYNAPSE-521) Send Synapse generated Hessian
faults with HTTP status 200
Posted by Ruwan Linton <ru...@gmail.com>.
Well, what I meant is the complete functionality..... i.e. if HTTP_SC_OK is
set tot true write the 200 OK as the status code. People might be using this
in their configurations.
I am OK with just removing it though... :-)
Thanks,
Ruwan
On Sun, Mar 22, 2009 at 9:01 PM, Asankha C. Perera <as...@apache.org>wrote:
> Hi Ruwan
>
>> Well, even earlier we should have removed it, with th introduction of the
>> HTTP_SC property to the message..... but we kept that for the backward
>> compatibility...
>>
>> Don't we need to keep this as deprecated for this release?
>>
> This is just the constant declaration in the file that was removed..
> Personally I do not think this is serious enough to keep for backward
> compatibility in this case.
>
> cheers
> asankha
>
> --
> Asankha C. Perera
> AdroitLogic, http://adroitlogic.org
>
> http://esbmagic.blogspot.com
>
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
> For additional commands, e-mail: dev-help@synapse.apache.org
>
>
--
Ruwan Linton
Senior Software Engineer & Product Manager; WSO2 ESB; http://wso2.org/esb
WSO2 Inc.; http://wso2.org
email: ruwan@wso2.com; cell: +94 77 341 3097
blog: http://ruwansblog.blogspot.com
Re: [jira] Resolved: (SYNAPSE-521) Send Synapse generated Hessian
faults with HTTP status 200
Posted by "Asankha C. Perera" <as...@apache.org>.
Hi Ruwan
> Well, even earlier we should have removed it, with th introduction of
> the HTTP_SC property to the message..... but we kept that for the
> backward compatibility...
>
> Don't we need to keep this as deprecated for this release?
This is just the constant declaration in the file that was removed..
Personally I do not think this is serious enough to keep for backward
compatibility in this case.
cheers
asankha
--
Asankha C. Perera
AdroitLogic, http://adroitlogic.org
http://esbmagic.blogspot.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org