You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2025/04/22 23:49:36 UTC
Re: [PR] Add TableSegmentsInfo to Thrift and Proto to broker/server messages [pinot]
Jackie-Jiang commented on code in PR #15573:
URL: https://github.com/apache/pinot/pull/15573#discussion_r2055052401
##########
pinot-common/src/main/proto/server.proto:
##########
@@ -25,11 +25,18 @@ service PinotQueryServer {
rpc Submit(ServerRequest) returns (stream ServerResponse);
}
+message TableSegmentsInfo {
+ string tableName = 1;
+ repeated string segments = 2;
+ repeated string optionalSegments = 3;
+}
+
message ServerRequest {
map<string, string> metadata = 1;
string sql = 2;
repeated string segments = 3;
bytes payload = 4;
+ repeated TableSegmentsInfo tableSegmentsInfo = 5;
Review Comment:
Not introduced in this PR, but should we also allow optional segments for regular query?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org