You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2025/03/24 06:15:48 UTC

[PR] Correctly limit werkzeug to < 3 [airflow]

amoghrajesh opened a new pull request, #48176:
URL: https://github.com/apache/airflow/pull/48176

   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   Seems to me that flask is being updated to versions leading to failures in CI: https://github.com/apache/airflow/actions/runs/14025646226/job/39264015635
   ```
   DB: sqlite:////root/airflow/sqlite/airflow.db
   [2025-03-24T02:15:05.441+0000] {db.py:1171} INFO - Dropping Airflow tables that exist
   [2025-03-24T02:15:05.593+0000] {migration.py:207} INFO - Context impl SQLiteImpl.
   [2025-03-24T02:15:05.593+0000] {migration.py:210} INFO - Will assume non-transactional DDL.
   [2025-03-24T02:15:05.594+0000] {db.py:1180} INFO - Dropped all Airflow tables
   [2025-03-24T02:15:05.606+0000] {migration.py:207} INFO - Context impl SQLiteImpl.
   [2025-03-24T02:15:05.607+0000] {migration.py:210} INFO - Will assume non-transactional DDL.
   Traceback (most recent call last):
     File "/usr/local/bin/airflow", line 10, in <module>
       sys.exit(main())
     File "/opt/airflow/airflow-core/src/airflow/__main__.py", line 58, in main
       args.func(args)
     File "/opt/airflow/airflow-core/src/airflow/cli/cli_config.py", line 49, in command
       return func(*args, **kwargs)
     File "/opt/airflow/airflow-core/src/airflow/utils/providers_configuration_loader.py", line 55, in wrapped_function
       return func(*args, **kwargs)
     File "/opt/airflow/airflow-core/src/airflow/cli/commands/local_commands/db_command.py", line 50, in resetdb
       db.resetdb(skip_init=args.skip_init)
     File "/opt/airflow/airflow-core/src/airflow/utils/session.py", line 101, in wrapper
       return func(*args, session=session, **kwargs)
     File "/opt/airflow/airflow-core/src/airflow/utils/db.py", line 1182, in resetdb
       external_db_manager.drop_tables(session, connection)
     File "/opt/airflow/airflow-core/src/airflow/utils/db_manager.py", line 218, in drop_tables
       m.drop_tables(connection)
     File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/models/db.py", line 123, in drop_tables
       _get_flask_db(settings.SQL_ALCHEMY_CONN).drop_all()
     File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/models/db.py", line 38, in _get_flask_db
       from airflow.providers.fab.www.session import AirflowDatabaseSessionInterface
     File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/session.py", line 21, in <module>
       from flask_session.sessions import SqlAlchemySessionInterface
   ModuleNotFoundError: No module named 'flask_session.sessions'
   ```
   
   Werkzeug 3 is known to break flask with airflow, so tryna limit it to see if it works.
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org