You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/06/08 13:12:57 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #24322: chore: Deprecates some NVD3 charts in 3.0
michael-s-molina opened a new pull request, #24322:
URL: https://github.com/apache/superset/pull/24322
### SUMMARY
Deprecates the following NVD3 charts in 3.0 to be removed in the next major version:
- Area
- Bar
- Dist Bar
- Line
- Pie
NVD3 charts that have a migration and an ECharts replacement will be removed in 3.0. The others remain untouched until we provide a migration and ECharts replacement in a future major version.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="1099" alt="Screenshot 2023-06-08 at 10 07 35" src="https://github.com/apache/superset/assets/70410625/4d93573d-dcc7-475b-91aa-e1b4addd264f">
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24322: chore: Deprecates some NVD3 charts in 3.0
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24322:
URL: https://github.com/apache/superset/pull/24322#issuecomment-1582660285
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24322?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24322](https://app.codecov.io/gh/apache/superset/pull/24322?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (02618d9) into [master](https://app.codecov.io/gh/apache/superset/commit/e13b80aff1821d6875b74045780e13b5c3913e6a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e13b80a) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 02618d9 differs from pull request most recent head 3d28eaf. Consider uploading reports for the commit 3d28eaf to get more accurate results
```diff
@@ Coverage Diff @@
## master #24322 +/- ##
=======================================
Coverage 68.33% 68.33%
=======================================
Files 1957 1957
Lines 75628 75628
Branches 8225 8225
=======================================
Hits 51680 51680
Misses 21835 21835
Partials 2113 2113
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.76% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24322?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...plugins/legacy-preset-chart-nvd3/src/Area/index.js](https://app.codecov.io/gh/apache/superset/pull/24322?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL0FyZWEvaW5kZXguanM=) | `66.66% <ø> (ø)` | |
| [.../plugins/legacy-preset-chart-nvd3/src/Bar/index.js](https://app.codecov.io/gh/apache/superset/pull/24322?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL0Jhci9pbmRleC5qcw==) | `66.66% <ø> (ø)` | |
| [...gins/legacy-preset-chart-nvd3/src/DistBar/index.js](https://app.codecov.io/gh/apache/superset/pull/24322?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL0Rpc3RCYXIvaW5kZXguanM=) | `66.66% <ø> (ø)` | |
| [...plugins/legacy-preset-chart-nvd3/src/Line/index.js](https://app.codecov.io/gh/apache/superset/pull/24322?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL0xpbmUvaW5kZXguanM=) | `66.66% <ø> (ø)` | |
| [.../plugins/legacy-preset-chart-nvd3/src/Pie/index.js](https://app.codecov.io/gh/apache/superset/pull/24322?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL1BpZS9pbmRleC5qcw==) | `33.33% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #24322: chore: Deprecates some NVD3 charts in 3.0
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #24322:
URL: https://github.com/apache/superset/pull/24322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #24322: chore: Deprecates some NVD3 charts in 3.0
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #24322:
URL: https://github.com/apache/superset/pull/24322#issuecomment-1583116059
@rusackas I added the DEPRECATED label to all and kept the (legacy) suffix in the name. I updated the PR image to reflect the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #24322: chore: Deprecates some NVD3 charts in 3.0
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #24322:
URL: https://github.com/apache/superset/pull/24322#discussion_r1223301454
##########
superset-frontend/plugins/legacy-preset-chart-nvd3/src/Pie/index.js:
##########
@@ -24,11 +24,15 @@ import controlPanel from './controlPanel';
const metadata = new ChartMetadata({
credits: ['http://nvd3.org'],
description: '',
- name: t('Pie Chart'),
+ name: t('Pie Chart (deprecated)'),
Review Comment:
This one does not appear in the viz gallery already. I just marked it as deprecated to be removed in 4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #24322: chore: Deprecates some NVD3 charts in 3.0
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #24322:
URL: https://github.com/apache/superset/pull/24322#discussion_r1223296386
##########
superset-frontend/plugins/legacy-preset-chart-nvd3/src/Pie/index.js:
##########
@@ -24,11 +24,15 @@ import controlPanel from './controlPanel';
const metadata = new ChartMetadata({
credits: ['http://nvd3.org'],
description: '',
- name: t('Pie Chart'),
+ name: t('Pie Chart (deprecated)'),
Review Comment:
Hmm, I wonder if it's fair to add `deprecated: true` to the metadata here, which would hide it from the viz gallery. Maybe we should gather some thoughts on this at Town Hall tomorrow? I'll stick it on the agenda.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #24322: chore: Deprecates some NVD3 charts in 3.0
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #24322:
URL: https://github.com/apache/superset/pull/24322#issuecomment-1583019696
> 2. Maybe we should add label: ChartLabel.DEPRECATED to their metadata, which adds the visible "DEPRECATED" label in the viz gallery.
I didn't know about this label. I'll add the label to all 👍🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org