You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Alex Deparvu (JIRA)" <ji...@apache.org> on 2019/04/04 09:34:00 UTC

[jira] [Commented] (OAK-8182) Improvements to PasswordUtil

    [ https://issues.apache.org/jira/browse/OAK-8182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809669#comment-16809669 ] 

Alex Deparvu commented on OAK-8182:
-----------------------------------

looks good to me.

> Improvements to PasswordUtil
> ----------------------------
>
>                 Key: OAK-8182
>                 URL: https://issues.apache.org/jira/browse/OAK-8182
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: security-spi
>            Reporter: angela
>            Priority: Minor
>         Attachments: OAK-8182.patch
>
>
> [~stillalex], i think some of the nullable annotations in private methods in {{PasswordUtil}} could actually be changed to notnull and we could remove the associated extra checks for those params to be null. along with some other minor improvements see attached patch. i would appreciate if you had time to take a close look to make sure, i did not introduce a regression while refactoring.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)