You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "cdivilly (via GitHub)" <gi...@apache.org> on 2025/01/14 10:52:01 UTC

[I] org.assertj:assertj-core dependency should have test scope [mina-sshd]

cdivilly opened a new issue, #654:
URL: https://github.com/apache/mina-sshd/issues/654

   ### Version
   
   2.14.0
   
   ### Bug description
   
   Even though the dependency for `org.assertj:assertj-core` is in the section labelled for test dependencies it [does not ](https://github.com/apache/mina-sshd/blob/sshd-2.14.0/sshd-contrib/pom.xml#L99)have a `<scope>test</scope>` element, leading to it being treated as a compile scope dependency, which causes downstream depenencies to include `org.assertj:assertj-core` unecessarily.
   
   ```xml
           <dependency>
               <groupId>org.assertj</groupId>
               <artifactId>assertj-core</artifactId>
               <version>3.26.3</version>
           </dependency>
   ```
   
   
   ### Actual behavior
   
   `org.assertj:assertj-core` dependency is included by downstream dependencies of `sshd-contrib`, even though it is not used at runtime
   
   ### Expected behavior
   
   `org.assertj:assertj-core` should have a `<scope>test</scope>` element so that it is only used at test time.
   
   ### Relevant log output
   
   ```Shell
   
   ```
   
   ### Other information
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org


Re: [I] org.assertj:assertj-core dependency should have test scope [mina-sshd]

Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf closed issue #654: org.assertj:assertj-core dependency should have test scope
URL: https://github.com/apache/mina-sshd/issues/654


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org


Re: [I] org.assertj:assertj-core dependency should have test scope [mina-sshd]

Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf commented on issue #654:
URL: https://github.com/apache/mina-sshd/issues/654#issuecomment-2613210233

   Thanks for reporting; fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org