You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/07/01 07:28:05 UTC
Review Request 36079: Added Subscribe call support to the master and
the C++ scheduler library.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36079/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Marco Massenzio.
Bugs: MESOs-2551
https://issues.apache.org/jira/browse/MESOs-2551
Repository: mesos
Description
-------
Haven't refactored registeredFramework() and re-registeredFramework() yet, but made Master::subscribe() call them instead.
Diffs
-----
src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064
src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92
src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6
Diff: https://reviews.apache.org/r/36079/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 36079: Added Subscribe call support to the master
and the C++ scheduler library.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36079/#review90120
-----------------------------------------------------------
Ship it!
+1 to Anand's comment since it is not a temporary.
- Ben Mahler
On July 1, 2015, 5:28 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36079/
> -----------------------------------------------------------
>
> (Updated July 1, 2015, 5:28 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Marco Massenzio.
>
>
> Bugs: MESOs-2551
> https://issues.apache.org/jira/browse/MESOs-2551
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Haven't refactored registeredFramework() and re-registeredFramework() yet, but made Master::subscribe() call them instead.
>
>
> Diffs
> -----
>
> src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064
> src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92
> src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6
>
> Diff: https://reviews.apache.org/r/36079/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 36079: Added Subscribe call support to the master
and the C++ scheduler library.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36079/#review90098
-----------------------------------------------------------
Ship it!
Looks good, just one minor comment.
- Anand Mazumdar
On July 1, 2015, 5:28 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36079/
> -----------------------------------------------------------
>
> (Updated July 1, 2015, 5:28 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Marco Massenzio.
>
>
> Bugs: MESOs-2551
> https://issues.apache.org/jira/browse/MESOs-2551
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Haven't refactored registeredFramework() and re-registeredFramework() yet, but made Master::subscribe() call them instead.
>
>
> Diffs
> -----
>
> src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064
> src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92
> src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6
>
> Diff: https://reviews.apache.org/r/36079/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 36079: Added Subscribe call support to the master
and the C++ scheduler library.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36079/#review90095
-----------------------------------------------------------
src/master/master.cpp (line 2072)
<https://reviews.apache.org/r/36079/#comment143066>
Minor nit-pick:
const FrameworkInfo& frameworkInfo ?
- Anand Mazumdar
On July 1, 2015, 5:28 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36079/
> -----------------------------------------------------------
>
> (Updated July 1, 2015, 5:28 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Marco Massenzio.
>
>
> Bugs: MESOs-2551
> https://issues.apache.org/jira/browse/MESOs-2551
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Haven't refactored registeredFramework() and re-registeredFramework() yet, but made Master::subscribe() call them instead.
>
>
> Diffs
> -----
>
> src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064
> src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92
> src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6
>
> Diff: https://reviews.apache.org/r/36079/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 36079: Added Subscribe call support to the master
and the C++ scheduler library.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36079/#review90163
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36077, 36078, 35855, 35856, 35857, 35858, 36079]
All tests passed.
- Mesos ReviewBot
On July 1, 2015, 10:20 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36079/
> -----------------------------------------------------------
>
> (Updated July 1, 2015, 10:20 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Marco Massenzio.
>
>
> Bugs: MESOs-2551
> https://issues.apache.org/jira/browse/MESOs-2551
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Haven't refactored registeredFramework() and re-registeredFramework() yet, but made Master::subscribe() call them instead.
>
>
> Diffs
> -----
>
> src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064
> src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92
> src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6
>
> Diff: https://reviews.apache.org/r/36079/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 36079: Added Subscribe call support to the master
and the C++ scheduler library.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36079/
-----------------------------------------------------------
(Updated July 1, 2015, 10:20 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Marco Massenzio.
Changes
-------
anand's comment. NNFR.
Bugs: MESOs-2551
https://issues.apache.org/jira/browse/MESOs-2551
Repository: mesos
Description
-------
Haven't refactored registeredFramework() and re-registeredFramework() yet, but made Master::subscribe() call them instead.
Diffs (updated)
-----
src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064
src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92
src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6
Diff: https://reviews.apache.org/r/36079/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 36079: Added Subscribe call support to the master
and the C++ scheduler library.
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36079/#review90110
-----------------------------------------------------------
Ship it!
Ship It!
- Isabel Jimenez
On July 1, 2015, 5:28 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36079/
> -----------------------------------------------------------
>
> (Updated July 1, 2015, 5:28 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Marco Massenzio.
>
>
> Bugs: MESOs-2551
> https://issues.apache.org/jira/browse/MESOs-2551
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Haven't refactored registeredFramework() and re-registeredFramework() yet, but made Master::subscribe() call them instead.
>
>
> Diffs
> -----
>
> src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064
> src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92
> src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6
>
> Diff: https://reviews.apache.org/r/36079/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 36079: Added Subscribe call support to the master
and the C++ scheduler library.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36079/#review90031
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36077, 36078, 35855, 35856, 35857, 35858, 36079]
All tests passed.
- Mesos ReviewBot
On July 1, 2015, 5:28 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36079/
> -----------------------------------------------------------
>
> (Updated July 1, 2015, 5:28 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Marco Massenzio.
>
>
> Bugs: MESOs-2551
> https://issues.apache.org/jira/browse/MESOs-2551
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Haven't refactored registeredFramework() and re-registeredFramework() yet, but made Master::subscribe() call them instead.
>
>
> Diffs
> -----
>
> src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064
> src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92
> src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6
>
> Diff: https://reviews.apache.org/r/36079/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>