You are viewing a plain text version of this content. The canonical link for it is here.
Posted to xap-commits@incubator.apache.org by jm...@apache.org on 2007/04/16 22:48:11 UTC
svn commit: r529426 -
/incubator/xap/trunk/codebase/src/xap/widgets/dojo/HorizontalPanel.js
Author: jmargaris
Date: Mon Apr 16 15:48:10 2007
New Revision: 529426
URL: http://svn.apache.org/viewvc?view=rev&rev=529426
Log:
using same logic as VerticalPanel to make sure we layout in
cases where the size of a table is being stubborn
Modified:
incubator/xap/trunk/codebase/src/xap/widgets/dojo/HorizontalPanel.js
Modified: incubator/xap/trunk/codebase/src/xap/widgets/dojo/HorizontalPanel.js
URL: http://svn.apache.org/viewvc/incubator/xap/trunk/codebase/src/xap/widgets/dojo/HorizontalPanel.js?view=diff&rev=529426&r1=529425&r2=529426
==============================================================================
--- incubator/xap/trunk/codebase/src/xap/widgets/dojo/HorizontalPanel.js (original)
+++ incubator/xap/trunk/codebase/src/xap/widgets/dojo/HorizontalPanel.js Mon Apr 16 15:48:10 2007
@@ -169,6 +169,30 @@
},
+ checkSize: function(){
+ //IMPORTANT for efficiency if _totalFlex is zero
+ //can we use the old behavior and check isResized()?
+ //Seems like it but not 100% sure.
+ if (!this._totalFlex){
+ xap.widgets.dojo.HorizontalPanel.superclass.checkSize.call(this);
+ }
+
+ else{
+ //This used to do a check against isResized()
+ //however that check fails on FF some times.
+ //What appears to happen is that we have a flexible
+ //component which is a table. Tables do not like to size
+ //smaller than their given size. So what happens is we shrink down
+ //but the inner table with a fixed size prevents us from actually
+ //growing smaller, so we fail the isResized() test.
+ //if(!this._isResized()){ return; }
+ //TODO what about a horizontal panel inside of another
+ //horizontal panel?? Same problem??
+ //revisit this at some point
+ this.onResized();
+ }
+ },
+
onResized: function(){
delete this._resizeTask;