You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ivica-k (via GitHub)" <gi...@apache.org> on 2023/07/23 15:32:27 UTC

[GitHub] [airflow] ivica-k opened a new pull request, #32785: adds support for querying Redshift Serverless clusters

ivica-k opened a new pull request, #32785:
URL: https://github.com/apache/airflow/pull/32785

   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   Adds support for querying Redshift Serverless clusters using the `RedshiftDataOperator`. Serverless clusters require the `workgroup_name` to be specified and do not require the `cluster_identifier`.
   
   Closes #32280 
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Lee-W commented on a diff in pull request #32785: adds support for querying Redshift Serverless clusters

Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #32785:
URL: https://github.com/apache/airflow/pull/32785#discussion_r1272312032


##########
airflow/providers/amazon/aws/hooks/redshift_data.py:
##########
@@ -95,6 +100,12 @@ def execute_query(
 
         statement_id = resp["Id"]
 
+        if kwargs["ClusterIdentifier"] and kwargs["WorkgroupName"]:

Review Comment:
   If we opt for this solution, we'll need to update the log message as well and `bool(...) is bool(...)` might be a better solution?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ivica-k commented on a diff in pull request #32785: adds support for querying Redshift Serverless clusters

Posted by "ivica-k (via GitHub)" <gi...@apache.org>.
ivica-k commented on code in PR #32785:
URL: https://github.com/apache/airflow/pull/32785#discussion_r1272412389


##########
airflow/providers/amazon/aws/operators/redshift_data.py:
##########
@@ -55,6 +58,7 @@ class RedshiftDataOperator(BaseOperator):
 
     template_fields = (
         "cluster_identifier",
+        "workgroup_name",

Review Comment:
   Tests are passing but i'll do it to remain consistent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ivica-k commented on a diff in pull request #32785: adds support for querying Redshift Serverless clusters

Posted by "ivica-k (via GitHub)" <gi...@apache.org>.
ivica-k commented on code in PR #32785:
URL: https://github.com/apache/airflow/pull/32785#discussion_r1272371045


##########
airflow/providers/amazon/aws/hooks/redshift_data.py:
##########
@@ -95,6 +100,12 @@ def execute_query(
 
         statement_id = resp["Id"]
 
+        if kwargs["ClusterIdentifier"] and kwargs["WorkgroupName"]:
+            raise ValueError("Specify either 'cluster_identifier' or 'workgroup_name', not both.")
+
+        if not kwargs["ClusterIdentifier"] and not kwargs["WorkgroupName"]:

Review Comment:
   Thank you, addressed in 56cc6d8ea13031ca610250735c8b0071065b233f



##########
airflow/providers/amazon/aws/operators/redshift_data.py:
##########
@@ -113,12 +120,19 @@ def hook(self) -> RedshiftDataHook:
 
     def execute(self, context: Context) -> GetStatementResultResponseTypeDef | str:
         """Execute a statement against Amazon Redshift."""
+        if self.cluster_identifier and self.workgroup_name:
+            raise AirflowException("Specify either 'cluster_identifier' or 'workgroup_name', not both.")
+
+        if not self.cluster_identifier and not self.workgroup_name:
+            raise AirflowException("Either 'cluster_identifier' or 'workgroup_name' must be specified.")

Review Comment:
   Thank you, addressed in 56cc6d8ea13031ca610250735c8b0071065b233f



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Lee-W commented on a diff in pull request #32785: adds support for querying Redshift Serverless clusters

Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #32785:
URL: https://github.com/apache/airflow/pull/32785#discussion_r1271951686


##########
airflow/providers/amazon/aws/hooks/redshift_data.py:
##########
@@ -53,6 +53,7 @@ def execute_query(
         database: str,
         sql: str | list[str],
         cluster_identifier: str | None = None,
+        workgroup_name: str | None = None,

Review Comment:
   Should we add this new parameter to the end of this function? Some users might pass positional arguments.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ivica-k commented on a diff in pull request #32785: adds support for querying Redshift Serverless clusters

Posted by "ivica-k (via GitHub)" <gi...@apache.org>.
ivica-k commented on code in PR #32785:
URL: https://github.com/apache/airflow/pull/32785#discussion_r1272000469


##########
airflow/providers/amazon/aws/hooks/redshift_data.py:
##########
@@ -53,6 +53,7 @@ def execute_query(
         database: str,
         sql: str | list[str],
         cluster_identifier: str | None = None,
+        workgroup_name: str | None = None,

Review Comment:
   Good point Lee, I'll make it happen.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] vincbeck merged pull request #32785: adds support for querying Redshift Serverless clusters

Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #32785:
URL: https://github.com/apache/airflow/pull/32785


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ivica-k commented on a diff in pull request #32785: adds support for querying Redshift Serverless clusters

Posted by "ivica-k (via GitHub)" <gi...@apache.org>.
ivica-k commented on code in PR #32785:
URL: https://github.com/apache/airflow/pull/32785#discussion_r1272416728


##########
airflow/providers/amazon/aws/operators/redshift_data.py:
##########
@@ -55,6 +58,7 @@ class RedshiftDataOperator(BaseOperator):
 
     template_fields = (
         "cluster_identifier",
+        "workgroup_name",

Review Comment:
   Also not sure, but for consistency addressed in 71bea87aff9be72086c85d99862568701e014bc4



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ivica-k commented on a diff in pull request #32785: adds support for querying Redshift Serverless clusters

Posted by "ivica-k (via GitHub)" <gi...@apache.org>.
ivica-k commented on code in PR #32785:
URL: https://github.com/apache/airflow/pull/32785#discussion_r1272412389


##########
airflow/providers/amazon/aws/operators/redshift_data.py:
##########
@@ -55,6 +58,7 @@ class RedshiftDataOperator(BaseOperator):
 
     template_fields = (
         "cluster_identifier",
+        "workgroup_name",

Review Comment:
   Tests are passing but i'll do it to remain consistent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ivica-k commented on a diff in pull request #32785: adds support for querying Redshift Serverless clusters

Posted by "ivica-k (via GitHub)" <gi...@apache.org>.
ivica-k commented on code in PR #32785:
URL: https://github.com/apache/airflow/pull/32785#discussion_r1272371737


##########
tests/providers/amazon/aws/hooks/test_redshift_data.py:
##########
@@ -39,22 +41,53 @@ def test_conn_attribute(self):
     @mock.patch("airflow.providers.amazon.aws.hooks.redshift_data.RedshiftDataHook.conn")
     def test_execute_without_waiting(self, mock_conn):
         mock_conn.execute_statement.return_value = {"Id": STATEMENT_ID}
+        cluster_identifier = "cluster_identifier"
 
         hook = RedshiftDataHook()
         hook.execute_query(
             database=DATABASE,
+            cluster_identifier=cluster_identifier,
             sql=SQL,
             wait_for_completion=False,
         )
         mock_conn.execute_statement.assert_called_once_with(
             Database=DATABASE,
+            ClusterIdentifier=cluster_identifier,
             Sql=SQL,
             WithEvent=False,
         )
         mock_conn.describe_statement.assert_not_called()
 
     @mock.patch("airflow.providers.amazon.aws.hooks.redshift_data.RedshiftDataHook.conn")
-    def test_execute_with_all_parameters(self, mock_conn):
+    def test_execute_requires_cluster_identifier_or_workgroup_name(self, mock_conn):
+        mock_conn.execute_statement.return_value = {"Id": STATEMENT_ID}
+
+        with pytest.raises(ValueError):
+            hook = RedshiftDataHook()
+            hook.execute_query(
+                database=DATABASE,
+                sql=SQL,
+                wait_for_completion=False,
+            )
+
+    @mock.patch("airflow.providers.amazon.aws.hooks.redshift_data.RedshiftDataHook.conn")
+    def test_execute_requires_cluster_identifier_or_workgroup_name_not_both(self, mock_conn):
+        mock_conn.execute_statement.return_value = {"Id": STATEMENT_ID}
+        cluster_identifier = "cluster_identifier"
+        workgroup_name = "workgroup_name"
+
+        with pytest.raises(ValueError):
+            hook = RedshiftDataHook()
+            hook.execute_query(
+                database=DATABASE,
+                cluster_identifier=cluster_identifier,
+                workgroup_name=workgroup_name,
+                sql=SQL,
+                wait_for_completion=False,
+            )

Review Comment:
   Good point, improved in 56cc6d8ea13031ca610250735c8b0071065b233f



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Lee-W commented on a diff in pull request #32785: adds support for querying Redshift Serverless clusters

Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #32785:
URL: https://github.com/apache/airflow/pull/32785#discussion_r1272312032


##########
airflow/providers/amazon/aws/hooks/redshift_data.py:
##########
@@ -95,6 +100,12 @@ def execute_query(
 
         statement_id = resp["Id"]
 
+        if kwargs["ClusterIdentifier"] and kwargs["WorkgroupName"]:

Review Comment:
   If we opt for this solution, we'll need to update the log message as well and I might suggest trying `bool(...) is bool(...)` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Lee-W commented on a diff in pull request #32785: adds support for querying Redshift Serverless clusters

Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #32785:
URL: https://github.com/apache/airflow/pull/32785#discussion_r1272382745


##########
airflow/providers/amazon/aws/hooks/redshift_data.py:
##########
@@ -60,13 +60,17 @@ def execute_query(
         with_event: bool = False,
         wait_for_completion: bool = True,
         poll_interval: int = 10,
+        workgroup_name: str | None = None,
     ) -> str:
         """
         Execute a statement against Amazon Redshift.
 
         :param database: the name of the database
         :param sql: the SQL statement or list of  SQL statement to run
         :param cluster_identifier: unique identifier of a cluster
+        :param workgroup_name: name of the Redshift Serverless workgroup. Mutually exclusive with

Review Comment:
   nitpick: i think we should reorder the docstring as well



##########
airflow/providers/amazon/aws/operators/redshift_data.py:
##########
@@ -55,6 +58,7 @@ class RedshiftDataOperator(BaseOperator):
 
     template_fields = (
         "cluster_identifier",
+        "workgroup_name",

Review Comment:
   not sure whether this will need to be reordered



##########
airflow/providers/amazon/aws/operators/redshift_data.py:
##########
@@ -40,6 +40,9 @@ class RedshiftDataOperator(BaseOperator):
     :param database: the name of the database
     :param sql: the SQL statement or list of  SQL statement to run
     :param cluster_identifier: unique identifier of a cluster
+    :param workgroup_name: name of the Redshift Serverless workgroup. Mutually exclusive with

Review Comment:
   nitpick: same here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ivica-k commented on a diff in pull request #32785: adds support for querying Redshift Serverless clusters

Posted by "ivica-k (via GitHub)" <gi...@apache.org>.
ivica-k commented on code in PR #32785:
URL: https://github.com/apache/airflow/pull/32785#discussion_r1272416092


##########
airflow/providers/amazon/aws/hooks/redshift_data.py:
##########
@@ -60,13 +60,17 @@ def execute_query(
         with_event: bool = False,
         wait_for_completion: bool = True,
         poll_interval: int = 10,
+        workgroup_name: str | None = None,
     ) -> str:
         """
         Execute a statement against Amazon Redshift.
 
         :param database: the name of the database
         :param sql: the SQL statement or list of  SQL statement to run
         :param cluster_identifier: unique identifier of a cluster
+        :param workgroup_name: name of the Redshift Serverless workgroup. Mutually exclusive with

Review Comment:
   Absolutely :) addressed in 71bea87aff9be72086c85d99862568701e014bc4



##########
airflow/providers/amazon/aws/operators/redshift_data.py:
##########
@@ -40,6 +40,9 @@ class RedshiftDataOperator(BaseOperator):
     :param database: the name of the database
     :param sql: the SQL statement or list of  SQL statement to run
     :param cluster_identifier: unique identifier of a cluster
+    :param workgroup_name: name of the Redshift Serverless workgroup. Mutually exclusive with

Review Comment:
   Same here: addressed in 71bea87aff9be72086c85d99862568701e014bc4 :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ivica-k commented on a diff in pull request #32785: adds support for querying Redshift Serverless clusters

Posted by "ivica-k (via GitHub)" <gi...@apache.org>.
ivica-k commented on code in PR #32785:
URL: https://github.com/apache/airflow/pull/32785#discussion_r1272370482


##########
airflow/providers/amazon/aws/hooks/redshift_data.py:
##########
@@ -53,6 +53,7 @@ def execute_query(
         database: str,
         sql: str | list[str],
         cluster_identifier: str | None = None,
+        workgroup_name: str | None = None,

Review Comment:
   Thank you, addressed in 56cc6d8ea13031ca610250735c8b0071065b233f



##########
airflow/providers/amazon/aws/hooks/redshift_data.py:
##########
@@ -95,6 +100,12 @@ def execute_query(
 
         statement_id = resp["Id"]
 
+        if kwargs["ClusterIdentifier"] and kwargs["WorkgroupName"]:

Review Comment:
   Thank you both, addressed in 56cc6d8ea13031ca610250735c8b0071065b233f



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] vincbeck commented on pull request #32785: adds support for querying Redshift Serverless clusters

Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #32785:
URL: https://github.com/apache/airflow/pull/32785#issuecomment-1648116560

   Besides the nits mentioned by @Lee-W , it looks good to me :) Good job!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] vincbeck commented on a diff in pull request #32785: adds support for querying Redshift Serverless clusters

Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #32785:
URL: https://github.com/apache/airflow/pull/32785#discussion_r1272269208


##########
airflow/providers/amazon/aws/hooks/redshift_data.py:
##########
@@ -95,6 +100,12 @@ def execute_query(
 
         statement_id = resp["Id"]
 
+        if kwargs["ClusterIdentifier"] and kwargs["WorkgroupName"]:

Review Comment:
   Another solution: merge the two if into one with:
   
   ```python
   if bool(cluster_identifier) == bool(workgroup_name):
   ```



##########
tests/providers/amazon/aws/hooks/test_redshift_data.py:
##########
@@ -39,22 +41,53 @@ def test_conn_attribute(self):
     @mock.patch("airflow.providers.amazon.aws.hooks.redshift_data.RedshiftDataHook.conn")
     def test_execute_without_waiting(self, mock_conn):
         mock_conn.execute_statement.return_value = {"Id": STATEMENT_ID}
+        cluster_identifier = "cluster_identifier"
 
         hook = RedshiftDataHook()
         hook.execute_query(
             database=DATABASE,
+            cluster_identifier=cluster_identifier,
             sql=SQL,
             wait_for_completion=False,
         )
         mock_conn.execute_statement.assert_called_once_with(
             Database=DATABASE,
+            ClusterIdentifier=cluster_identifier,
             Sql=SQL,
             WithEvent=False,
         )
         mock_conn.describe_statement.assert_not_called()
 
     @mock.patch("airflow.providers.amazon.aws.hooks.redshift_data.RedshiftDataHook.conn")
-    def test_execute_with_all_parameters(self, mock_conn):
+    def test_execute_requires_cluster_identifier_or_workgroup_name(self, mock_conn):
+        mock_conn.execute_statement.return_value = {"Id": STATEMENT_ID}
+
+        with pytest.raises(ValueError):
+            hook = RedshiftDataHook()
+            hook.execute_query(
+                database=DATABASE,
+                sql=SQL,
+                wait_for_completion=False,
+            )
+
+    @mock.patch("airflow.providers.amazon.aws.hooks.redshift_data.RedshiftDataHook.conn")
+    def test_execute_requires_cluster_identifier_or_workgroup_name_not_both(self, mock_conn):
+        mock_conn.execute_statement.return_value = {"Id": STATEMENT_ID}
+        cluster_identifier = "cluster_identifier"
+        workgroup_name = "workgroup_name"
+
+        with pytest.raises(ValueError):
+            hook = RedshiftDataHook()
+            hook.execute_query(
+                database=DATABASE,
+                cluster_identifier=cluster_identifier,
+                workgroup_name=workgroup_name,
+                sql=SQL,
+                wait_for_completion=False,
+            )

Review Comment:
   nit: you can merge these two tests into one using @parametrize



##########
airflow/providers/amazon/aws/hooks/redshift_data.py:
##########
@@ -95,6 +100,12 @@ def execute_query(
 
         statement_id = resp["Id"]
 
+        if kwargs["ClusterIdentifier"] and kwargs["WorkgroupName"]:
+            raise ValueError("Specify either 'cluster_identifier' or 'workgroup_name', not both.")
+
+        if not kwargs["ClusterIdentifier"] and not kwargs["WorkgroupName"]:

Review Comment:
   ```suggestion
           if not cluster_identifier and not workgroup_name:
   ```



##########
airflow/providers/amazon/aws/operators/redshift_data.py:
##########
@@ -113,12 +120,19 @@ def hook(self) -> RedshiftDataHook:
 
     def execute(self, context: Context) -> GetStatementResultResponseTypeDef | str:
         """Execute a statement against Amazon Redshift."""
+        if self.cluster_identifier and self.workgroup_name:
+            raise AirflowException("Specify either 'cluster_identifier' or 'workgroup_name', not both.")
+
+        if not self.cluster_identifier and not self.workgroup_name:
+            raise AirflowException("Either 'cluster_identifier' or 'workgroup_name' must be specified.")

Review Comment:
   You're already making these checks in the hook, no need to do it again here



##########
airflow/providers/amazon/aws/hooks/redshift_data.py:
##########
@@ -95,6 +100,12 @@ def execute_query(
 
         statement_id = resp["Id"]
 
+        if kwargs["ClusterIdentifier"] and kwargs["WorkgroupName"]:

Review Comment:
   ```suggestion
           if cluster_identifier and workgroup_name:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org