You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/08/05 22:03:57 UTC
[kudu-CR] Rename Remote Bootstrap: some manual changes
Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3852
to review the following change.
Change subject: Rename Remote Bootstrap: some manual changes
......................................................................
Rename Remote Bootstrap: some manual changes
This patch has a bunch more manual fixes to replace "Remote Bootstrap"
terminology with "Tablet Copy". I looked through the previous (automatic)
diff and tried to clean up comments and variable names to be more clear,
as well as find other abbreviated cases like the term 'bootstrap' or 'rb'
which needed to be updated.
This still doesn't do the file renames. That's yet to come.
Change-Id: I9e2860b64e46c5cc021cb8574e6845d7bcb27cce
---
M docs/design-docs/README.md
M docs/design-docs/raft-config-change.md
M docs/design-docs/raft-remote-bootstrap.md
M docs/whitepaper/kudu.tex
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/cluster_itest_util.h
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/remote_bootstrap-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/tablet/metadata.proto
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tserver/remote_bootstrap_client.cc
M src/kudu/tserver/remote_bootstrap_client.h
M src/kudu/tserver/remote_bootstrap_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
21 files changed, 167 insertions(+), 167 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/3852/1
--
To view, visit http://gerrit.cloudera.org:8080/3852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e2860b64e46c5cc021cb8574e6845d7bcb27cce
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Rename Remote Bootstrap: some manual changes
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Rename Remote Bootstrap: some manual changes
......................................................................
Rename Remote Bootstrap: some manual changes
This patch has a bunch more manual fixes to replace "Remote Bootstrap"
terminology with "Tablet Copy". I looked through the previous (automatic)
diff and tried to clean up comments and variable names to be more clear,
as well as find other abbreviated cases like the term 'bootstrap' or 'rb'
which needed to be updated.
This still doesn't do the file renames. That's yet to come.
Change-Id: I9e2860b64e46c5cc021cb8574e6845d7bcb27cce
Reviewed-on: http://gerrit.cloudera.org:8080/3852
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
---
M docs/design-docs/README.md
M docs/design-docs/raft-config-change.md
M docs/design-docs/raft-remote-bootstrap.md
M docs/whitepaper/kudu.tex
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/cluster_itest_util.h
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/remote_bootstrap-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/tablet/metadata.proto
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tserver/remote_bootstrap_client.cc
M src/kudu/tserver/remote_bootstrap_client.h
M src/kudu/tserver/remote_bootstrap_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
21 files changed, 167 insertions(+), 167 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e2860b64e46c5cc021cb8574e6845d7bcb27cce
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Rename Remote Bootstrap: some manual changes
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Rename Remote Bootstrap: some manual changes
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e2860b64e46c5cc021cb8574e6845d7bcb27cce
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Rename Remote Bootstrap: some manual changes
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3852
to look at the new patch set (#2).
Change subject: Rename Remote Bootstrap: some manual changes
......................................................................
Rename Remote Bootstrap: some manual changes
This patch has a bunch more manual fixes to replace "Remote Bootstrap"
terminology with "Tablet Copy". I looked through the previous (automatic)
diff and tried to clean up comments and variable names to be more clear,
as well as find other abbreviated cases like the term 'bootstrap' or 'rb'
which needed to be updated.
This still doesn't do the file renames. That's yet to come.
Change-Id: I9e2860b64e46c5cc021cb8574e6845d7bcb27cce
---
M docs/design-docs/README.md
M docs/design-docs/raft-config-change.md
M docs/design-docs/raft-remote-bootstrap.md
M docs/whitepaper/kudu.tex
M src/kudu/consensus/consensus.proto
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/cluster_itest_util.h
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/remote_bootstrap-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/tablet/metadata.proto
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tserver/remote_bootstrap_client.cc
M src/kudu/tserver/remote_bootstrap_client.h
M src/kudu/tserver/remote_bootstrap_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
21 files changed, 167 insertions(+), 167 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/3852/2
--
To view, visit http://gerrit.cloudera.org:8080/3852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e2860b64e46c5cc021cb8574e6845d7bcb27cce
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Rename Remote Bootstrap: some manual changes
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Rename Remote Bootstrap: some manual changes
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2724/
--
To view, visit http://gerrit.cloudera.org:8080/3852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e2860b64e46c5cc021cb8574e6845d7bcb27cce
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Rename Remote Bootstrap: some manual changes
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Rename Remote Bootstrap: some manual changes
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3852/1/docs/design-docs/raft-remote-bootstrap.md
File docs/design-docs/raft-remote-bootstrap.md:
Line 58: ## Design & implementation of tablet Tablet Copy
nit: tablet Tablet Copy. If this is too painful to rebase from then we can fix after
--
To view, visit http://gerrit.cloudera.org:8080/3852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e2860b64e46c5cc021cb8574e6845d7bcb27cce
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Rename Remote Bootstrap: some manual changes
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Rename Remote Bootstrap: some manual changes
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/2727/
--
To view, visit http://gerrit.cloudera.org:8080/3852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e2860b64e46c5cc021cb8574e6845d7bcb27cce
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No