You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/10/13 07:18:50 UTC

[GitHub] [iceberg] Kontinuation opened a new pull request, #5975: Core/Spark: Fix kryo deserialization of `SerializableTable`

Kontinuation opened a new pull request, #5975:
URL: https://github.com/apache/iceberg/pull/5975

   Closes https://github.com/apache/iceberg/issues/5974


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] Kontinuation commented on a diff in pull request #5975: Core/Spark: Fix kryo deserialization of `SerializableTable`

Posted by GitBox <gi...@apache.org>.
Kontinuation commented on code in PR #5975:
URL: https://github.com/apache/iceberg/pull/5975#discussion_r995279026


##########
core/src/test/java/org/apache/iceberg/hadoop/TestTableSerialization.java:
##########
@@ -51,6 +52,15 @@ public void testSerializableTable() throws IOException, ClassNotFoundException {
     table.updateSchema().addColumn("new_col", Types.IntegerType.get()).commit();
 
     TestHelpers.assertSerializedAndLoadedMetadata(table, TestHelpers.roundTripSerialize(table));
+    Table serializableTable = SerializableTable.copyOf(table);
+    TestHelpers.assertSerializedAndLoadedMetadata(
+        serializableTable, TestHelpers.KryoHelpers.roundTripSerialize(serializableTable));
+
+    table.newAppend().appendFile(FILE_A).commit();

Review Comment:
   Moved serialization of table with snapshot to a new test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] aokolnychyi commented on pull request #5975: Core/Spark: Fix kryo deserialization of `SerializableTable`

Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on PR #5975:
URL: https://github.com/apache/iceberg/pull/5975#issuecomment-1278465093

   Thanks for fixing it, @Kontinuation! Thanks for reviewing, @nastra @singhpk234 @szehon-ho!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] aokolnychyi merged pull request #5975: Core/Spark: Fix kryo deserialization of `SerializableTable`

Posted by GitBox <gi...@apache.org>.
aokolnychyi merged PR #5975:
URL: https://github.com/apache/iceberg/pull/5975


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] szehon-ho commented on a diff in pull request #5975: Core/Spark: Fix kryo deserialization of `SerializableTable`

Posted by GitBox <gi...@apache.org>.
szehon-ho commented on code in PR #5975:
URL: https://github.com/apache/iceberg/pull/5975#discussion_r995257262


##########
core/src/test/java/org/apache/iceberg/hadoop/TestTableSerialization.java:
##########
@@ -51,6 +52,15 @@ public void testSerializableTable() throws IOException, ClassNotFoundException {
     table.updateSchema().addColumn("new_col", Types.IntegerType.get()).commit();
 
     TestHelpers.assertSerializedAndLoadedMetadata(table, TestHelpers.roundTripSerialize(table));
+    Table serializableTable = SerializableTable.copyOf(table);
+    TestHelpers.assertSerializedAndLoadedMetadata(
+        serializableTable, TestHelpers.KryoHelpers.roundTripSerialize(serializableTable));
+
+    table.newAppend().appendFile(FILE_A).commit();

Review Comment:
   Nit: would make a new test as it seems unrelated to previous one (ie, testSerializableTableWithSnapshot)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org