You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by sekimura <gi...@git.apache.org> on 2016/11/18 23:36:55 UTC
[GitHub] trafficserver pull request #1227: TS-5051 Add a new log tag % AppVersio...
GitHub user sekimura opened a pull request:
https://github.com/apache/trafficserver/pull/1227
TS-5051 Add a new log tag %<vbn> AppVersionInfo.BldNumStr
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sekimura/trafficserver ts-5051
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1227.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1227
----
commit ead9d56da076b43ac8ddb02e48e6a03f78bd3b06
Author: Masa Sekimura <se...@gmail.com>
Date: 2016-11-18T23:34:35Z
TS-5051 Add a new log tag %<vbn> AppVersionInfo.BldNumStr
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1227: TS-5051 Add a new log tag % AppVersionInfo.B...
Posted by sekimura <gi...@git.apache.org>.
Github user sekimura commented on the issue:
https://github.com/apache/trafficserver/pull/1227
+1 to " a logging tag that can log an arbitrary metric"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1227: TS-5051 Add a new log tag % AppVersionInfo.B...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1227
Hmmm, logging most metrics seems somewhat useless. What would be useful would be to have generic access to the underlying data that is used to update the metrics for that transactions.
There are exceptions; Those metric which are static (tracking things like versions, startup time, etc.) might be useful to provide as a generic log field? If we have easy access to those from the Lua logging.config format, then I'm definitely +1 on using that instead. Is there a Lua API to inspect the lib records, or would the Lua script have to do a request on the mgmt port? The latter seems potentially expensive, unless it can be saved in a static variable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1227: TS-5051 Add a new log tag % AppVersionInfo.B...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1227
@sekimura You want to take stab at adding this as Lua definitions? I assume the intent would be to expose some of these constants in an internal Lua table?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1227: TS-5051 Add a new log tag % AppVersionInfo.B...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1227
I really don't think this is worth a log tag. It is trivial to add this information as Lua constants to be consumed by `logging.config`. Alternatively, a logging tag that can log an arbitrary metric would be interesting. This is just too specific IMHO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1227: TS-5051 Add a new log tag % AppVersionInfo.B...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1227
Well it is trivial to make those constants available in the Lua API. I don't think these things are worth adding log tags on their own.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---