You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by dbravender <gi...@git.apache.org> on 2017/01/02 19:49:18 UTC
[GitHub] thrift pull request #1148: THRIFT-4018 corruption after ApplicationException...
GitHub user dbravender opened a pull request:
https://github.com/apache/thrift/pull/1148
THRIFT-4018 corruption after ApplicationException in Ruby server
This fixes an issue where a Ruby Thrift server can corrupt connections by putting ApplicationException in the middle of a response. See https://issues.apache.org/jira/browse/THRIFT-4018 for more information.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dbravender/thrift defect/THRIFT-4018-corruption-after-ApplicationException
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1148.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1148
----
commit d1e3ef2c600913c17e8503d792f35604105849d0
Author: Dan Bravender <da...@gmail.com>
Date: 2016-12-20T14:57:56Z
THRIFT-4018 reproduction test case
commit aac7b6cedd3bf1711d3bfaa657d0e137d252508b
Author: Dan Bravender <da...@gmail.com>
Date: 2017-01-02T19:40:11Z
THRIFT-4018 validate response before putting it on the wire
Client: ruby
Fixes an issue where an invalid response could corrupt all future responses
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1148: THRIFT-4018 corruption after ApplicationException in Rub...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1148
Would you be able to rebase this on the current master and push? This would kick a new build, and I would like to see it pass before merging anything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1148: THRIFT-4018 corruption after ApplicationException...
Posted by dbravender <gi...@git.apache.org>.
Github user dbravender closed the pull request at:
https://github.com/apache/thrift/pull/1148
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---