Re: [PR] feat(export/import): add annotation layer export/import support for charts and dashboards [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #43232:
URL: https://github.com/apache/superset/pull/43232#issuecomment-5612069307

   Heya @MallikarjunaReddyN, thanks for tackling this one. Couple of things to look into before this can move forward.
   
   `import_annotation_layer` doesn't check `can_write` on Annotation Layer the way `import_chart` and `import_dataset` do, so a Gamma user could smuggle `annotation_layers/*.yaml` into a chart import bundle and write to what's supposed to be an Alpha-only resource. EnxDev's review has the details, plus a few other findings worth a look.
   
   Also needs a rebase, it's conflicting with `master`. I'll see if I can tackle that now.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org