You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/13 20:53:02 UTC

[GitHub] stu1130 commented on a change in pull request #12131: [MXNET-737][WIP] Add last batch handle for imageiter

stu1130 commented on a change in pull request #12131: [MXNET-737][WIP] Add last batch handle for imageiter
URL: https://github.com/apache/incubator-mxnet/pull/12131#discussion_r209754983
 
 

 ##########
 File path: python/mxnet/image/image.py
 ##########
 @@ -1059,16 +1059,21 @@ class ImageIter(io.DataIter):
         Label name for provided symbols.
     dtype : str
         Label data type. Default: float32. Other options: int32, int64, float64
+    last_batch_hanle :  str, optional
 
 Review comment:
   The original [NDArrayIter](https://mxnet.apache.org/api/python/io/io.html#mxnet.io.NDArrayIter) call it `last_batch_handle` but I think the name `last_batch` already give much information of what it does. So I would go with your suggestion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services