You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/03/23 15:57:29 UTC
[GitHub] zeppelin pull request #2184: [MINOR][ZEPPELIN-2306] Improve alignment of com...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2184
[MINOR][ZEPPELIN-2306] Improve alignment of components in Helium header
### What is this PR for?
If there are 2 more enabled `VISUALIZATION` pkgs, the ordering control section will be shown like below. But the useless spaces between "Helium" and "Bundle package display order(drag and drop)".
So I changed some alignment to remove the extra space.
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-2306](https://issues.apache.org/jira/browse/ZEPPELIN-2306)
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
- Before
<img width="1278" alt="screen shot 2017-03-24 at 12 55 12 am" src="https://cloud.githubusercontent.com/assets/10060731/24256864/a3940516-102c-11e7-9fe2-71ded6115c4f.png">
- After
1. more than 2 pkgs are enabled
<img width="1271" alt="after1" src="https://cloud.githubusercontent.com/assets/10060731/24256742/4e09d1f2-102c-11e7-9ef6-327f54d8a31a.png">
2. only 1 pkg is enabled
<img width="1267" alt="after2" src="https://cloud.githubusercontent.com/assets/10060731/24256794/6ac384dc-102c-11e7-8861-950a8ca35427.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-2306
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2184.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2184
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2184: [MINOR][ZEPPELIN-2306] Improve alignment of components...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2184
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2184: [MINOR][ZEPPELIN-2306] Improve alignment of com...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2184: [MINOR][ZEPPELIN-2306] Improve alignment of components...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2184
Merge into master if there are no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---