You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by "kezhuw (via GitHub)" <gi...@apache.org> on 2023/06/13 06:04:08 UTC

[GitHub] [zookeeper] kezhuw opened a new pull request, #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes

kezhuw opened a new pull request, #1998:
URL: https://github.com/apache/zookeeper/pull/1998

   Before ZOOKEEPER-1416, `WatcherType.Children` was used to remove watchers attached through `ZooKeeper.getChildren`. `WatcherType.Data` was used to remove watchers attached through `ZooKeeper.getData` and `ZooKeeper.exists`.
   
   ZOOKEEPER-1416 adds `AddWatchMode.PERSISTENT`. This watcher could be completed remove using `WatcherType.Any`. But when removing through `WatcherType.Data` or `WatcherType.Children`, part of `AddWatchMode.PERSISTENT` will be left behind. And we get persistent children or data watchers.
   
   We are never claiming to support these type of watchers. So fix it.
   
   In rare chance, we are going to support persistent data or children watchers in future, I think we probably don't want to do such "magic" thing in ZooKeeper. So fix it.
   
   This is a step towards ZOOKEEPER-4472 which proposed to support `WatcherType.Persistent` and `WatcherType.PersistentRecursive` to remove persistent watchers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] kezhuw closed pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes

Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw closed pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes
URL: https://github.com/apache/zookeeper/pull/1998


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] kezhuw closed pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes

Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw closed pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes
URL: https://github.com/apache/zookeeper/pull/1998


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] kezhuw commented on pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes

Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on PR #1998:
URL: https://github.com/apache/zookeeper/pull/1998#issuecomment-1589071434

   This is the link to previous ci run, the cpp tests hang for almost 5 hours.
   
   https://github.com/apache/zookeeper/actions/runs/5251856628/jobs/9487231863


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] kezhuw commented on pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes

Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on PR #1998:
URL: https://github.com/apache/zookeeper/pull/1998#issuecomment-1538695645

   We are approaching [ZOOKEEPER-4472][].
   
   * [ZOOKEEPER-4466][](#1859) enables multiple modes on one path.
   * [ZOOKEEPER-4471][] forbids partially watcher removing in server side. These is no such "partial removing" in client side.
   * [ZOOKEEPER-4472][] proposed to individual `WatcherType`s for persistent watches.
   
   Combine them all, we will have orthogonal watcher modes for clients. Watching or un-watching a path in one mode will not break other watching modes on same path.
   
   [ZOOKEEPER-4466]: https://issues.apache.org/jira/browse/ZOOKEEPER-4466
   [ZOOKEEPER-4471]: https://issues.apache.org/jira/browse/ZOOKEEPER-4471
   [ZOOKEEPER-4472]: https://issues.apache.org/jira/browse/ZOOKEEPER-4472
   
   cc @eolivelli @tisonkun @Randgalt @symat @maoling @cnauroth


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] tisonkun commented on pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #1998:
URL: https://github.com/apache/zookeeper/pull/1998#issuecomment-1589289550

   I think it's good to go. Merging...
   
   Thanks for your contribution @kezhuw!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] kezhuw commented on pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes

Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on PR #1998:
URL: https://github.com/apache/zookeeper/pull/1998#issuecomment-1589280448

   All checks are green. Can we merge this and move forward to #2006 ? @eolivelli @tisonkun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] tisonkun merged pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #1998:
URL: https://github.com/apache/zookeeper/pull/1998


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] kezhuw commented on pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes

Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on PR #1998:
URL: https://github.com/apache/zookeeper/pull/1998#issuecomment-1588600215

   Failure test case run reported at [ZOOKEEPER-4512](https://issues.apache.org/jira/browse/ZOOKEEPER-4512).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] kezhuw commented on pull request #1998: ZOOKEEPER-4471: Match removing WatcherType to standard, persistent modes

Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on PR #1998:
URL: https://github.com/apache/zookeeper/pull/1998#issuecomment-1589069167

   Great! Thank you for reviewing! @tisonkun @eolivelli 
   
   The cpp tests hang, I will reopen this pr for another ci run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org