You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/04 00:51:00 UTC
[GitHub] [incubator-superset] etr2460 opened a new pull request #11920: fix: Remove expensive logs table migration
etr2460 opened a new pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920
### SUMMARY
Addresses issues with https://github.com/apache/incubator-superset/pull/11714 that prevented the migration from being run on MySQL dbs with large `logs` tables.
Does the following:
- Updates the original migration to remove the add column statements
- Adds a new migration to remove the columns if they exist
- Pushes the new columns into the json column in the logs table
Does not:
- Address any naming concerns about the new columns
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TEST PLAN
- run the original migration, then upgrade past my new migration without errors
- run the updated original migration, then upgrade past my new migration without errors
- run the original migration, then downgrade without errors
- run the update original migration, then downgrade without errors
- run a query and see the new fields in the json column of the logs table
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [x] Requires DB Migration.
- [x] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
to: @mistercrunch @john-bodley @dpgaspar @ktmud @graceguo-supercat
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#discussion_r535840491
##########
File path: superset/utils/log.py
##########
@@ -92,6 +89,13 @@ def log_context(
if log_to_statsd:
self.stats_logger.incr(action)
+ payload.update(
+ {
+ "path": request.path,
+ "path_no_int": strip_int_from_path(request.path),
Review comment:
can we name this to `path_no_param` in case we want to update the logic in `strip_int_from_path` as discussed in #11714 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738480160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=h1) Report
> Merging [#11920](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=desc) (a5a8eb2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **decrease** coverage by `4.17%`.
> The diff coverage is `2.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
- Coverage 67.68% 63.51% -4.18%
==========================================
Files 930 464 -466
Lines 45132 28463 -16669
Branches 4331 0 -4331
==========================================
- Hits 30549 18079 -12470
+ Misses 14480 10384 -4096
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.51% <2.56%> (-0.72%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/migrations/shared/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvdXRpbHMucHk=) | `0.00% <0.00%> (ø)` | |
| [...ons/versions/811494c0cc23\_remove\_path\_from\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MTE0OTRjMGNjMjNfcmVtb3ZlX3BhdGhfZnJvbV9sb2dzLnB5) | `0.00% <0.00%> (ø)` | |
| [...grations/versions/a8173232b786\_add\_path\_to\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hODE3MzIzMmI3ODZfYWRkX3BhdGhfdG9fbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <ø> (-0.91%)` | :arrow_down: |
| [superset/utils/log.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.20% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| ... and [486 more](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=footer). Last update [e0288bf...a5a8eb2](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738480160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=h1) Report
> Merging [#11920](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=desc) (f89b9da) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **decrease** coverage by `4.48%`.
> The diff coverage is `2.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
- Coverage 67.68% 63.20% -4.49%
==========================================
Files 930 932 +2
Lines 45132 45139 +7
Branches 4331 4331
==========================================
- Hits 30549 28529 -2020
- Misses 14480 16433 +1953
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.15% <ø> (ø)` | |
| python | `63.22% <2.56%> (-1.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/migrations/shared/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvdXRpbHMucHk=) | `0.00% <0.00%> (ø)` | |
| [...ons/versions/811494c0cc23\_remove\_path\_from\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MTE0OTRjMGNjMjNfcmVtb3ZlX3BhdGhfZnJvbV9sb2dzLnB5) | `0.00% <0.00%> (ø)` | |
| [...grations/versions/a8173232b786\_add\_path\_to\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hODE3MzIzMmI3ODZfYWRkX3BhdGhfdG9fbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.14% <ø> (-2.81%)` | :arrow_down: |
| [superset/utils/log.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.20% <100.00%> (+0.06%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [203 more](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=footer). Last update [e0288bf...1f221c4](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738863402
Since CI is green, i'm going to merge this now. Feel free to follow up with any naming PRs today or next week
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738480160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=h1) Report
> Merging [#11920](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=desc) (f89b9da) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **decrease** coverage by `4.27%`.
> The diff coverage is `2.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
- Coverage 67.68% 63.41% -4.28%
==========================================
Files 930 932 +2
Lines 45132 45139 +7
Branches 4331 4331
==========================================
- Hits 30549 28626 -1923
- Misses 14480 16336 +1856
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.15% <ø> (ø)` | |
| python | `63.57% <2.56%> (-0.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/migrations/shared/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvdXRpbHMucHk=) | `0.00% <0.00%> (ø)` | |
| [...ons/versions/811494c0cc23\_remove\_path\_from\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MTE0OTRjMGNjMjNfcmVtb3ZlX3BhdGhfZnJvbV9sb2dzLnB5) | `0.00% <0.00%> (ø)` | |
| [...grations/versions/a8173232b786\_add\_path\_to\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hODE3MzIzMmI3ODZfYWRkX3BhdGhfdG9fbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <ø> (-0.91%)` | :arrow_down: |
| [superset/utils/log.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.20% <100.00%> (+0.06%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [190 more](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=footer). Last update [e0288bf...1f221c4](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738480160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=h1) Report
> Merging [#11920](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=desc) (23cf625) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **increase** coverage by `5.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
+ Coverage 67.68% 73.27% +5.58%
==========================================
Files 930 468 -462
Lines 45132 16694 -28438
Branches 4331 4339 +8
==========================================
- Hits 30549 12233 -18316
+ Misses 14480 4354 -10126
- Partials 103 107 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.39% <ø> (-0.50%)` | :arrow_down: |
| javascript | `63.16% <ø> (+<0.01%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.12% <0.00%> (-5.17%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.25% <0.00%> (-4.28%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `49.01% <0.00%> (-3.93%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.60% <0.00%> (-3.31%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `86.48% <0.00%> (-2.71%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `59.49% <0.00%> (-1.27%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `52.43% <0.00%> (-1.22%)` | :arrow_down: |
| [...erset-frontend/src/components/DatabaseSelector.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci50c3g=) | `89.36% <0.00%> (-1.07%)` | :arrow_down: |
| ... and [463 more](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=footer). Last update [e0288bf...89bd58e](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#discussion_r535831394
##########
File path: superset/migrations/versions/811494c0cc23_remove_path_from_logs.py
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Remove path, path_no_int, and ref from logs
+
+Revision ID: 811494c0cc23
+Revises: 8ee129739cf9
+Create Date: 2020-12-03 16:21:06.771684
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = "811494c0cc23"
+down_revision = "8ee129739cf9"
+
+import sqlalchemy as sa
+from alembic import op
+
+from superset.migrations.shared import utils
+
+
+def upgrade():
+ with op.batch_alter_table("logs") as batch_op:
+ if utils.table_has_column("logs", "path"):
+ batch_op.drop_column("path")
Review comment:
I think it's ok to drop the metadata
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#discussion_r535845221
##########
File path: superset/utils/log.py
##########
@@ -92,6 +89,13 @@ def log_context(
if log_to_statsd:
self.stats_logger.incr(action)
+ payload.update(
+ {
+ "path": request.path,
+ "path_no_int": strip_int_from_path(request.path),
Review comment:
Feel free to completely drop `path_no_int` and the `strip_int_from_path` method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-739014920
> Since CI is green, i'm going to merge this now. Feel free to follow up with any naming PRs today or next week
@etr2460 @mistercrunch #11927 is ready for review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#discussion_r535846684
##########
File path: superset/utils/log.py
##########
@@ -92,6 +89,13 @@ def log_context(
if log_to_statsd:
self.stats_logger.incr(action)
+ payload.update(
+ {
+ "path": request.path,
+ "path_no_int": strip_int_from_path(request.path),
Review comment:
Naming is hard. I'm a fan of measure twice cut once, as renaming things (or dealing with legacy names) in the future is always somewhat painful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#discussion_r535758330
##########
File path: superset/utils/log.py
##########
@@ -224,6 +224,9 @@ def log( # pylint: disable=too-many-arguments,too-many-locals
logs = list()
for record in records:
json_string: Optional[str]
+ record.update(
+ {"path": path, "path_no_int": path_no_int, "ref": ref,}
+ )
Review comment:
This should probably happen in `log_context` so you don't have to pass these arguments around.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738480160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=h1) Report
> Merging [#11920](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=desc) (6cf8428) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **decrease** coverage by `4.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
- Coverage 67.68% 63.16% -4.53%
==========================================
Files 930 468 -462
Lines 45132 16686 -28446
Branches 4331 4339 +8
==========================================
- Hits 30549 10539 -20010
+ Misses 14480 5970 -8510
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.16% <ø> (+<0.01%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [626 more](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=footer). Last update [e0288bf...23cf625](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738480160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=h1) Report
> Merging [#11920](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=desc) (f89b9da) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **decrease** coverage by `4.45%`.
> The diff coverage is `2.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
- Coverage 67.68% 63.22% -4.46%
==========================================
Files 930 464 -466
Lines 45132 28463 -16669
Branches 4331 0 -4331
==========================================
- Hits 30549 17997 -12552
+ Misses 14480 10466 -4014
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.22% <2.56%> (-1.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/migrations/shared/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvdXRpbHMucHk=) | `0.00% <0.00%> (ø)` | |
| [...ons/versions/811494c0cc23\_remove\_path\_from\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MTE0OTRjMGNjMjNfcmVtb3ZlX3BhdGhfZnJvbV9sb2dzLnB5) | `0.00% <0.00%> (ø)` | |
| [...grations/versions/a8173232b786\_add\_path\_to\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hODE3MzIzMmI3ODZfYWRkX3BhdGhfdG9fbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.14% <ø> (-2.81%)` | :arrow_down: |
| [superset/utils/log.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.20% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| ... and [495 more](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=footer). Last update [e0288bf...f89b9da](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#discussion_r535790437
##########
File path: superset/migrations/shared/utils.py
##########
@@ -0,0 +1,45 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from alembic import op
+from sqlalchemy import engine_from_config
+from sqlalchemy.engine import reflection
+from sqlalchemy.exc import NoSuchTableError
+
+
+def table_has_column(table: str, column: str) -> bool:
+ """
+ Checks if a column exists in a given table.
+
+ :param table: A table name
+ :param column: A column name
+ :returns: True iff the column exists in the table
+ """
+
+ config = op.get_context().config
+ engine = engine_from_config(
+ config.get_section(config.config_ini_section), prefix="sqlalchemy."
+ )
+ insp = reflection.Inspector.from_engine(engine)
+ has_column = False
+ try:
+ for col in insp.get_columns(table):
Review comment:
Maybe,
```python
return any(col["name"] == column for col in insp.get_columns(table))
```
This would replace line 37 and lines 40 - 43.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#discussion_r535790437
##########
File path: superset/migrations/shared/utils.py
##########
@@ -0,0 +1,45 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from alembic import op
+from sqlalchemy import engine_from_config
+from sqlalchemy.engine import reflection
+from sqlalchemy.exc import NoSuchTableError
+
+
+def table_has_column(table: str, column: str) -> bool:
+ """
+ Checks if a column exists in a given table.
+
+ :param table: A table name
+ :param column: A column name
+ :returns: True iff the column exists in the table
+ """
+
+ config = op.get_context().config
+ engine = engine_from_config(
+ config.get_section(config.config_ini_section), prefix="sqlalchemy."
+ )
+ insp = reflection.Inspector.from_engine(engine)
+ has_column = False
+ try:
+ for col in insp.get_columns(table):
Review comment:
Maybe,
```python
return any(col["name"] == column for col in nsp.get_columns(table))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#discussion_r535844147
##########
File path: superset/utils/log.py
##########
@@ -92,6 +89,13 @@ def log_context(
if log_to_statsd:
self.stats_logger.incr(action)
+ payload.update(
+ {
+ "path": request.path,
+ "path_no_int": strip_int_from_path(request.path),
Review comment:
I think `path_no_param` was agreed on. Just thought it's better to make that change sooner so we don't have any dirty data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#discussion_r535817197
##########
File path: superset/migrations/versions/811494c0cc23_remove_path_from_logs.py
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Remove path, path_no_int, and ref from logs
+
+Revision ID: 811494c0cc23
+Revises: 8ee129739cf9
+Create Date: 2020-12-03 16:21:06.771684
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = "811494c0cc23"
+down_revision = "8ee129739cf9"
+
+import sqlalchemy as sa
+from alembic import op
+
+from superset.migrations.shared import utils
+
+
+def upgrade():
+ with op.batch_alter_table("logs") as batch_op:
+ if utils.table_has_column("logs", "path"):
+ batch_op.drop_column("path")
Review comment:
yeah, i made the executive decision to drop any extra metadata that came in in the last week from the previous change. I think it's reasonable since i doubt many folks are relying on them thus far
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738480160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=h1) Report
> Merging [#11920](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=desc) (89bd58e) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **decrease** coverage by `3.89%`.
> The diff coverage is `2.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
- Coverage 67.68% 63.78% -3.90%
==========================================
Files 930 932 +2
Lines 45132 45153 +21
Branches 4331 4331
==========================================
- Hits 30549 28803 -1746
- Misses 14480 16173 +1693
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.15% <ø> (ø)` | |
| python | `64.16% <2.63%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/migrations/shared/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvdXRpbHMucHk=) | `0.00% <0.00%> (ø)` | |
| [...ons/versions/811494c0cc23\_remove\_path\_from\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MTE0OTRjMGNjMjNfcmVtb3ZlX3BhdGhfZnJvbV9sb2dzLnB5) | `0.00% <0.00%> (ø)` | |
| [...grations/versions/a8173232b786\_add\_path\_to\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hODE3MzIzMmI3ODZfYWRkX3BhdGhfdG9fbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <ø> (-0.10%)` | :arrow_down: |
| [superset/utils/log.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.20% <100.00%> (+0.06%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [173 more](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=footer). Last update [e0288bf...14fd7fc](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#discussion_r535845624
##########
File path: superset/utils/log.py
##########
@@ -92,6 +89,13 @@ def log_context(
if log_to_statsd:
self.stats_logger.incr(action)
+ payload.update(
+ {
+ "path": request.path,
+ "path_no_int": strip_int_from_path(request.path),
Review comment:
I'm also ok fine with `ref` -> `object_ref` too. Happy to do in a fast follow PR
##########
File path: superset/utils/log.py
##########
@@ -92,6 +89,13 @@ def log_context(
if log_to_statsd:
self.stats_logger.incr(action)
+ payload.update(
+ {
+ "path": request.path,
+ "path_no_int": strip_int_from_path(request.path),
Review comment:
I'm also ok fine with `ref` -> `object_ref` too. I'm happy to do in a fast follow PR too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738480160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=h1) Report
> Merging [#11920](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=desc) (a5a8eb2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **decrease** coverage by `4.11%`.
> The diff coverage is `2.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
- Coverage 67.68% 63.57% -4.12%
==========================================
Files 930 464 -466
Lines 45132 28463 -16669
Branches 4331 0 -4331
==========================================
- Hits 30549 18094 -12455
+ Misses 14480 10369 -4111
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.57% <2.56%> (-0.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/migrations/shared/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvdXRpbHMucHk=) | `0.00% <0.00%> (ø)` | |
| [...ons/versions/811494c0cc23\_remove\_path\_from\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MTE0OTRjMGNjMjNfcmVtb3ZlX3BhdGhfZnJvbV9sb2dzLnB5) | `0.00% <0.00%> (ø)` | |
| [...grations/versions/a8173232b786\_add\_path\_to\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hODE3MzIzMmI3ODZfYWRkX3BhdGhfdG9fbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <ø> (-0.91%)` | :arrow_down: |
| [superset/utils/log.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.20% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.56% <0.00%> (-2.44%)` | :arrow_down: |
| ... and [482 more](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=footer). Last update [e0288bf...a5a8eb2](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738480160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=h1) Report
> Merging [#11920](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=desc) (6cf8428) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **increase** coverage by `5.88%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
+ Coverage 67.68% 73.57% +5.88%
==========================================
Files 930 468 -462
Lines 45132 16694 -28438
Branches 4331 4339 +8
==========================================
- Hits 30549 12283 -18266
+ Misses 14480 4308 -10172
Partials 103 103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.89% <ø> (ø)` | |
| javascript | `63.16% <ø> (+<0.01%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/SaveDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVEYXRhc2V0TW9kYWwudHN4) | `71.42% <0.00%> (-0.58%)` | :arrow_down: |
| [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | | |
| [superset/migrations/versions/4736ec66ce19\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80NzM2ZWM2NmNlMTlfLnB5) | | |
| [...migrations/versions/ad4d656d92bc\_add\_avg\_metric.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZDRkNjU2ZDkyYmNfYWRkX2F2Z19tZXRyaWMucHk=) | | |
| [...7bf4f117f9\_adding\_extra\_field\_to\_database\_model.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84NjdiZjRmMTE3ZjlfYWRkaW5nX2V4dHJhX2ZpZWxkX3RvX2RhdGFiYXNlX21vZGVsLnB5) | | |
| [...ns/5afa9079866a\_serialize\_schema\_permissions\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81YWZhOTA3OTg2NmFfc2VyaWFsaXplX3NjaGVtYV9wZXJtaXNzaW9uc19weS5weQ==) | | |
| [...f2f7c195a\_rewriting\_url\_from\_shortner\_with\_new\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hOTlmMmY3YzE5NWFfcmV3cml0aW5nX3VybF9mcm9tX3Nob3J0bmVyX3dpdGhfbmV3Xy5weQ==) | | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | | |
| [...ions/bf706ae5eb46\_cal\_heatmap\_metric\_to\_metrics.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iZjcwNmFlNWViNDZfY2FsX2hlYXRtYXBfbWV0cmljX3RvX21ldHJpY3MucHk=) | | |
| [superset/examples/bart\_lines.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmFydF9saW5lcy5weQ==) | | |
| ... and [450 more](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=footer). Last update [e0288bf...23cf625](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#discussion_r535798622
##########
File path: superset/migrations/versions/811494c0cc23_remove_path_from_logs.py
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Remove path, path_no_int, and ref from logs
+
+Revision ID: 811494c0cc23
+Revises: 8ee129739cf9
+Create Date: 2020-12-03 16:21:06.771684
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = "811494c0cc23"
+down_revision = "8ee129739cf9"
+
+import sqlalchemy as sa
+from alembic import op
+
+from superset.migrations.shared import utils
+
+
+def upgrade():
+ with op.batch_alter_table("logs") as batch_op:
+ if utils.table_has_column("logs", "path"):
+ batch_op.drop_column("path")
Review comment:
@etr2460 this isn't quite right. If the column exists one should really iterate over the non-NULL values and migrate those to the `json` column. That could be somewhat of an expensive operation but given the relevancy (or lack there of) and recency of the original migration it may be ok to accept the data loss.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#discussion_r535761226
##########
File path: superset/utils/log.py
##########
@@ -224,6 +224,9 @@ def log( # pylint: disable=too-many-arguments,too-many-locals
logs = list()
for record in records:
json_string: Optional[str]
+ record.update(
+ {"path": path, "path_no_int": path_no_int, "ref": ref,}
+ )
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#discussion_r535790437
##########
File path: superset/migrations/shared/utils.py
##########
@@ -0,0 +1,45 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from alembic import op
+from sqlalchemy import engine_from_config
+from sqlalchemy.engine import reflection
+from sqlalchemy.exc import NoSuchTableError
+
+
+def table_has_column(table: str, column: str) -> bool:
+ """
+ Checks if a column exists in a given table.
+
+ :param table: A table name
+ :param column: A column name
+ :returns: True iff the column exists in the table
+ """
+
+ config = op.get_context().config
+ engine = engine_from_config(
+ config.get_section(config.config_ini_section), prefix="sqlalchemy."
+ )
+ insp = reflection.Inspector.from_engine(engine)
+ has_column = False
+ try:
+ for col in insp.get_columns(table):
Review comment:
Maybe,
```python
return any(col["name"] == column for col in insp.get_columns(table))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738480160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=h1) Report
> Merging [#11920](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=desc) (89bd58e) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **decrease** coverage by `3.89%`.
> The diff coverage is `2.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
- Coverage 67.68% 63.79% -3.90%
==========================================
Files 930 932 +2
Lines 45132 45163 +31
Branches 4331 4339 +8
==========================================
- Hits 30549 28810 -1739
- Misses 14480 16176 +1696
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.16% <ø> (+<0.01%)` | :arrow_up: |
| python | `64.16% <2.63%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/migrations/shared/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvdXRpbHMucHk=) | `0.00% <0.00%> (ø)` | |
| [...ons/versions/811494c0cc23\_remove\_path\_from\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MTE0OTRjMGNjMjNfcmVtb3ZlX3BhdGhfZnJvbV9sb2dzLnB5) | `0.00% <0.00%> (ø)` | |
| [...grations/versions/a8173232b786\_add\_path\_to\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hODE3MzIzMmI3ODZfYWRkX3BhdGhfdG9fbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <ø> (-0.10%)` | :arrow_down: |
| [superset/utils/log.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.20% <100.00%> (+0.06%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [174 more](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=footer). Last update [e0288bf...14fd7fc](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738565088
I think it's useful to keep logs for things like object creation/deletion for auditing purposes. But for UX analytics and simple access logs, we should probably target moving it out of the metadata database?
Should we create two separate loggers for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738480160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=h1) Report
> Merging [#11920](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=desc) (a5a8eb2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **decrease** coverage by `4.27%`.
> The diff coverage is `2.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
- Coverage 67.68% 63.41% -4.28%
==========================================
Files 930 932 +2
Lines 45132 45139 +7
Branches 4331 4331
==========================================
- Hits 30549 28626 -1923
- Misses 14480 16336 +1856
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.15% <ø> (ø)` | |
| python | `63.57% <2.56%> (-0.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/migrations/shared/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvdXRpbHMucHk=) | `0.00% <0.00%> (ø)` | |
| [...ons/versions/811494c0cc23\_remove\_path\_from\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MTE0OTRjMGNjMjNfcmVtb3ZlX3BhdGhfZnJvbV9sb2dzLnB5) | `0.00% <0.00%> (ø)` | |
| [...grations/versions/a8173232b786\_add\_path\_to\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hODE3MzIzMmI3ODZfYWRkX3BhdGhfdG9fbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <ø> (-0.91%)` | :arrow_down: |
| [superset/utils/log.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.20% <100.00%> (+0.06%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [190 more](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=footer). Last update [e0288bf...f89b9da](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738480160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=h1) Report
> Merging [#11920](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=desc) (14fd7fc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **decrease** coverage by `0.16%`.
> The diff coverage is `2.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
- Coverage 67.68% 67.52% -0.17%
==========================================
Files 930 932 +2
Lines 45132 45161 +29
Branches 4331 4331
==========================================
- Hits 30549 30494 -55
- Misses 14480 14560 +80
- Partials 103 107 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.36% <ø> (-0.54%)` | :arrow_down: |
| javascript | `63.15% <ø> (ø)` | |
| python | `64.16% <2.63%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/migrations/shared/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvdXRpbHMucHk=) | `0.00% <0.00%> (ø)` | |
| [...ons/versions/811494c0cc23\_remove\_path\_from\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MTE0OTRjMGNjMjNfcmVtb3ZlX3BhdGhfZnJvbV9sb2dzLnB5) | `0.00% <0.00%> (ø)` | |
| [...grations/versions/a8173232b786\_add\_path\_to\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hODE3MzIzMmI3ODZfYWRkX3BhdGhfdG9fbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <ø> (-0.10%)` | :arrow_down: |
| [superset/utils/log.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.20% <100.00%> (+0.06%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.12% <0.00%> (-5.17%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.25% <0.00%> (-4.28%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `49.01% <0.00%> (-3.93%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=footer). Last update [e0288bf...14fd7fc](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738480160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=h1) Report
> Merging [#11920](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=desc) (14fd7fc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **decrease** coverage by `3.89%`.
> The diff coverage is `2.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
- Coverage 67.68% 63.78% -3.90%
==========================================
Files 930 932 +2
Lines 45132 45153 +21
Branches 4331 4331
==========================================
- Hits 30549 28803 -1746
- Misses 14480 16173 +1693
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.15% <ø> (ø)` | |
| python | `64.16% <2.63%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/migrations/shared/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvdXRpbHMucHk=) | `0.00% <0.00%> (ø)` | |
| [...ons/versions/811494c0cc23\_remove\_path\_from\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MTE0OTRjMGNjMjNfcmVtb3ZlX3BhdGhfZnJvbV9sb2dzLnB5) | `0.00% <0.00%> (ø)` | |
| [...grations/versions/a8173232b786\_add\_path\_to\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hODE3MzIzMmI3ODZfYWRkX3BhdGhfdG9fbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <ø> (-0.10%)` | :arrow_down: |
| [superset/utils/log.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.20% <100.00%> (+0.06%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [173 more](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=footer). Last update [e0288bf...14fd7fc](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#discussion_r535844343
##########
File path: superset/utils/log.py
##########
@@ -92,6 +89,13 @@ def log_context(
if log_to_statsd:
self.stats_logger.incr(action)
+ payload.update(
+ {
+ "path": request.path,
+ "path_no_int": strip_int_from_path(request.path),
Review comment:
But if you just merge this after CI is green, I can make another followup PR soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#discussion_r535842689
##########
File path: superset/utils/log.py
##########
@@ -92,6 +89,13 @@ def log_context(
if log_to_statsd:
self.stats_logger.incr(action)
+ payload.update(
+ {
+ "path": request.path,
+ "path_no_int": strip_int_from_path(request.path),
Review comment:
as mentioned in the summary, this PR:
> Does not:
>
> - Address any naming concerns about the new columns
I'd rather keep this PR just scoped to fixing the migration issue. We can fast follow with naming changes if we all agree they're preferred.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738480160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=h1) Report
> Merging [#11920](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=desc) (14fd7fc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **decrease** coverage by `3.89%`.
> The diff coverage is `2.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
- Coverage 67.68% 63.78% -3.90%
==========================================
Files 930 932 +2
Lines 45132 45153 +21
Branches 4331 4331
==========================================
- Hits 30549 28803 -1746
- Misses 14480 16173 +1693
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.15% <ø> (ø)` | |
| python | `64.16% <2.63%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/migrations/shared/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvdXRpbHMucHk=) | `0.00% <0.00%> (ø)` | |
| [...ons/versions/811494c0cc23\_remove\_path\_from\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MTE0OTRjMGNjMjNfcmVtb3ZlX3BhdGhfZnJvbV9sb2dzLnB5) | `0.00% <0.00%> (ø)` | |
| [...grations/versions/a8173232b786\_add\_path\_to\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hODE3MzIzMmI3ODZfYWRkX3BhdGhfdG9fbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <ø> (-0.10%)` | :arrow_down: |
| [superset/utils/log.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.20% <100.00%> (+0.06%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [173 more](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=footer). Last update [e0288bf...14fd7fc](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738480160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=h1) Report
> Merging [#11920](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=desc) (a5a8eb2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **decrease** coverage by `4.27%`.
> The diff coverage is `2.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
- Coverage 67.68% 63.41% -4.28%
==========================================
Files 930 932 +2
Lines 45132 45139 +7
Branches 4331 4331
==========================================
- Hits 30549 28626 -1923
- Misses 14480 16336 +1856
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.15% <ø> (ø)` | |
| python | `63.57% <2.56%> (-0.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/migrations/shared/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvdXRpbHMucHk=) | `0.00% <0.00%> (ø)` | |
| [...ons/versions/811494c0cc23\_remove\_path\_from\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MTE0OTRjMGNjMjNfcmVtb3ZlX3BhdGhfZnJvbV9sb2dzLnB5) | `0.00% <0.00%> (ø)` | |
| [...grations/versions/a8173232b786\_add\_path\_to\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hODE3MzIzMmI3ODZfYWRkX3BhdGhfdG9fbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <ø> (-0.91%)` | :arrow_down: |
| [superset/utils/log.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.20% <100.00%> (+0.06%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [190 more](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=footer). Last update [e0288bf...a5a8eb2](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#discussion_r535847193
##########
File path: superset/utils/log.py
##########
@@ -92,6 +89,13 @@ def log_context(
if log_to_statsd:
self.stats_logger.incr(action)
+ payload.update(
+ {
+ "path": request.path,
+ "path_no_int": strip_int_from_path(request.path),
Review comment:
ah, i see the `path_no_param` agreement from the previous pr. tbh, CI is sooo slow tonight i probably won't merge this until tomorrow. So i'll make the change now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#discussion_r535844343
##########
File path: superset/utils/log.py
##########
@@ -92,6 +89,13 @@ def log_context(
if log_to_statsd:
self.stats_logger.incr(action)
+ payload.update(
+ {
+ "path": request.path,
+ "path_no_int": strip_int_from_path(request.path),
Review comment:
But it you just merge this after CI is agree, I can make another follow PR soon.
##########
File path: superset/utils/log.py
##########
@@ -92,6 +89,13 @@ def log_context(
if log_to_statsd:
self.stats_logger.incr(action)
+ payload.update(
+ {
+ "path": request.path,
+ "path_no_int": strip_int_from_path(request.path),
Review comment:
But it you just merge this after CI is green, I can make another follow PR soon.
##########
File path: superset/utils/log.py
##########
@@ -92,6 +89,13 @@ def log_context(
if log_to_statsd:
self.stats_logger.incr(action)
+ payload.update(
+ {
+ "path": request.path,
+ "path_no_int": strip_int_from_path(request.path),
Review comment:
But it you just merge this after CI is green, I can make another followup PR soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#discussion_r535790745
##########
File path: superset/migrations/shared/utils.py
##########
@@ -0,0 +1,45 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from alembic import op
+from sqlalchemy import engine_from_config
+from sqlalchemy.engine import reflection
+from sqlalchemy.exc import NoSuchTableError
+
+
+def table_has_column(table: str, column: str) -> bool:
+ """
+ Checks if a column exists in a given table.
+
+ :param table: A table name
+ :param column: A column name
+ :returns: True iff the column exists in the table
+ """
+
+ config = op.get_context().config
+ engine = engine_from_config(
+ config.get_section(config.config_ini_section), prefix="sqlalchemy."
+ )
+ insp = reflection.Inspector.from_engine(engine)
+ has_column = False
+ try:
+ for col in insp.get_columns(table):
Review comment:
fyi: https://stackoverflow.com/a/52865284
but i'm realizing now, this is a pretty janky function. let me fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738480160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=h1) Report
> Merging [#11920](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=desc) (14fd7fc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **decrease** coverage by `0.04%`.
> The diff coverage is `2.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
- Coverage 67.68% 67.64% -0.05%
==========================================
Files 930 932 +2
Lines 45132 45161 +29
Branches 4331 4331
==========================================
+ Hits 30549 30550 +1
- Misses 14480 14508 +28
Partials 103 103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.94% <ø> (+0.05%)` | :arrow_up: |
| javascript | `63.15% <ø> (ø)` | |
| python | `64.16% <2.63%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/migrations/shared/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvdXRpbHMucHk=) | `0.00% <0.00%> (ø)` | |
| [...ons/versions/811494c0cc23\_remove\_path\_from\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MTE0OTRjMGNjMjNfcmVtb3ZlX3BhdGhfZnJvbV9sb2dzLnB5) | `0.00% <0.00%> (ø)` | |
| [...grations/versions/a8173232b786\_add\_path\_to\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hODE3MzIzMmI3ODZfYWRkX3BhdGhfdG9fbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.85% <ø> (-0.10%)` | :arrow_down: |
| [superset/utils/log.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.20% <100.00%> (+0.06%)` | :arrow_up: |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `81.81% <0.00%> (-1.82%)` | :arrow_down: |
| [...perset-frontend/src/messageToasts/actions/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvYWN0aW9ucy9pbmRleC50cw==) | `96.15% <0.00%> (+7.69%)` | :arrow_up: |
| [...et-frontend/src/messageToasts/components/Toast.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdC50c3g=) | `100.00% <0.00%> (+8.33%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=footer). Last update [e0288bf...14fd7fc](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738480160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=h1) Report
> Merging [#11920](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=desc) (6cf8428) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **increase** coverage by `5.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
+ Coverage 67.68% 73.24% +5.55%
==========================================
Files 930 468 -462
Lines 45132 16694 -28438
Branches 4331 4339 +8
==========================================
- Hits 30549 12227 -18322
+ Misses 14480 4360 -10120
- Partials 103 107 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.30% <ø> (-0.59%)` | :arrow_down: |
| javascript | `63.16% <ø> (+<0.01%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.12% <0.00%> (-5.17%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.25% <0.00%> (-4.28%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `49.01% <0.00%> (-3.93%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.60% <0.00%> (-3.31%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `86.48% <0.00%> (-2.71%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `59.49% <0.00%> (-1.27%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `52.43% <0.00%> (-1.22%)` | :arrow_down: |
| [...erset-frontend/src/components/DatabaseSelector.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci50c3g=) | `89.36% <0.00%> (-1.07%)` | :arrow_down: |
| ... and [460 more](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=footer). Last update [e0288bf...23cf625](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738480160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=h1) Report
> Merging [#11920](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=desc) (23cf625) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **decrease** coverage by `4.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
- Coverage 67.68% 63.16% -4.53%
==========================================
Files 930 468 -462
Lines 45132 16686 -28446
Branches 4331 4339 +8
==========================================
- Hits 30549 10539 -20010
+ Misses 14480 5970 -8510
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.16% <ø> (+<0.01%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [626 more](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=footer). Last update [e0288bf...89bd58e](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11920: fix: Remove expensive logs table migration
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11920:
URL: https://github.com/apache/incubator-superset/pull/11920#issuecomment-738480160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=h1) Report
> Merging [#11920](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=desc) (23cf625) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e0288bf76b561b65e439058d263be88f8ca019b3?el=desc) (e0288bf) will **increase** coverage by `5.92%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11920 +/- ##
==========================================
+ Coverage 67.68% 73.61% +5.92%
==========================================
Files 930 468 -462
Lines 45132 16694 -28438
Branches 4331 4339 +8
==========================================
- Hits 30549 12289 -18260
+ Misses 14480 4302 -10178
Partials 103 103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.98% <ø> (+0.08%)` | :arrow_up: |
| javascript | `63.16% <ø> (+<0.01%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/SaveDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVEYXRhc2V0TW9kYWwudHN4) | `71.42% <0.00%> (-0.58%)` | :arrow_down: |
| [...ons/versions/67a6ac9b727b\_update\_spatial\_params.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy82N2E2YWM5YjcyN2JfdXBkYXRlX3NwYXRpYWxfcGFyYW1zLnB5) | | |
| [...ersions/2929af7925ed\_tz\_offsets\_in\_data\_sources.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yOTI5YWY3OTI1ZWRfdHpfb2Zmc2V0c19pbl9kYXRhX3NvdXJjZXMucHk=) | | |
| [...versions/743a117f0d98\_add\_slack\_to\_the\_schedule.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83NDNhMTE3ZjBkOThfYWRkX3NsYWNrX3RvX3RoZV9zY2hlZHVsZS5weQ==) | | |
| [superset/db\_engine\_specs/oracle.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL29yYWNsZS5weQ==) | | |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | | |
| [...ab3d66c4246e\_add\_cache\_timeout\_to\_druid\_cluster.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hYjNkNjZjNDI0NmVfYWRkX2NhY2hlX3RpbWVvdXRfdG9fZHJ1aWRfY2x1c3Rlci5weQ==) | | |
| [superset/datasets/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvc2NoZW1hcy5weQ==) | | |
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | | |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | | |
| ... and [453 more](https://codecov.io/gh/apache/incubator-superset/pull/11920/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=footer). Last update [e0288bf...89bd58e](https://codecov.io/gh/apache/incubator-superset/pull/11920?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org