You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@eagle.apache.org by "Liangfei.Su" <su...@gmail.com> on 2015/12/09 03:46:03 UTC

About dev process

Hi, PMCs

To help clear the dev process, i'm trying to put this into eagle WIKI.
Please advise if it's OK to all.

The referenced commit msg format is:


[EAGLE-${ticket_number}] ${ticket_title}

${ticket_url}

Author: ${commiter}
Reviewer: ${reviewer}

Closes #${pr_number} from ${do_person}





Thanks,
Ralph

Re: About dev process

Posted by Hao Chen <cn...@gmail.com>.

Sure, could you please send me the content internally? I will add it for
you.


--

Hao


On Wed, Dec 9, 2015 at 5:24 PM, Liangfei.Su <su...@gmail.com> wrote:

> That's the plan as i stated. Since eagle wiki currently only open write
> permission to its PMC/Committers. I would like someone who already have the
> wiki write permission help to do this. Can you help?
>
> Ralph
>
> On Wed, Dec 9, 2015 at 4:42 PM, Hao Chen <cn...@gmail.com> wrote:
>
> > Liangfei,
> >
> > Could you please help document the process in Eagle wiki and we could
> > finalize the process ASAP? U.S. and Indian committers are pending on this
> > process to merge new features.
> >
> >
> > --
> >
> > Hao
> >
> >
> >
> > On Wed, Dec 9, 2015 at 4:16 PM, Liangfei.Su <su...@gmail.com>
> wrote:
> >
> > > Yes, the '[]' is not expected here. It should be typo when i copy from
> my
> > > text editor. We don't need that.
> > >
> > > Regarding the author and reviewer, i agree that they're optional. The
> > main
> > > idea here is that if we could states the name of reviewers here. (And
> > yes,
> > > the reviewers should give their comments on pull request page which is
> > > traceable from the ${ticket_number}, just want to make this information
> > > explicitly here :) ). Let's make this info as optional.
> > >
> > > Ralph
> > >
> > >
> > > On Wed, Dec 9, 2015 at 4:00 PM, Julian Hyde <jh...@apache.org> wrote:
> > >
> > > > One minor problem with the "[EAGLE-${ticket_number}] message" format
> is
> > > the
> > > > 'git am' command. When it reads patches from a mail box, it uses the
> > > > subject of each email as the commit message but it strips off any [
> > ... ]
> > > > at the start of the subject. So, even though we use this format in
> > > Calcite,
> > > > if we started over, I think we might use something like
> > > > "EAGLE-{ticket_number}: message" (without brackets) instead.
> > > >
> > > > Strictly, you don't need the "Author:" and "Reviewer:" lines because
> > they
> > > > are contained in the git metadata. But you probably know that
> already.
> > > >
> > > > Julian
> > > >
> > > >
> > > > On Tue, Dec 8, 2015 at 6:46 PM, Liangfei.Su <su...@gmail.com>
> > > wrote:
> > > >
> > > > > Hi, PMCs
> > > > >
> > > > > To help clear the dev process, i'm trying to put this into eagle
> > WIKI.
> > > > > Please advise if it's OK to all.
> > > > >
> > > > > The referenced commit msg format is:
> > > > >
> > > > >
> > > > > [EAGLE-${ticket_number}] ${ticket_title}
> > > > >
> > > > > ${ticket_url}
> > > > >
> > > > > Author: ${commiter}
> > > > > Reviewer: ${reviewer}
> > > > >
> > > > > Closes #${pr_number} from ${do_person}
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > 
> > > > > Thanks,
> > > > > Ralph
> > > > >
> > > >
> > >
> >
>

Re: About dev process

Posted by "Liangfei.Su" <su...@gmail.com>.

That's the plan as i stated. Since eagle wiki currently only open write
permission to its PMC/Committers. I would like someone who already have the
wiki write permission help to do this. Can you help?

Ralph

On Wed, Dec 9, 2015 at 4:42 PM, Hao Chen <cn...@gmail.com> wrote:

> Liangfei,
>
> Could you please help document the process in Eagle wiki and we could
> finalize the process ASAP? U.S. and Indian committers are pending on this
> process to merge new features.
>
>
> --
>
> Hao
>
>
>
> On Wed, Dec 9, 2015 at 4:16 PM, Liangfei.Su <su...@gmail.com> wrote:
>
> > Yes, the '[]' is not expected here. It should be typo when i copy from my
> > text editor. We don't need that.
> >
> > Regarding the author and reviewer, i agree that they're optional. The
> main
> > idea here is that if we could states the name of reviewers here. (And
> yes,
> > the reviewers should give their comments on pull request page which is
> > traceable from the ${ticket_number}, just want to make this information
> > explicitly here :) ). Let's make this info as optional.
> >
> > Ralph
> >
> >
> > On Wed, Dec 9, 2015 at 4:00 PM, Julian Hyde <jh...@apache.org> wrote:
> >
> > > One minor problem with the "[EAGLE-${ticket_number}] message" format is
> > the
> > > 'git am' command. When it reads patches from a mail box, it uses the
> > > subject of each email as the commit message but it strips off any [
> ... ]
> > > at the start of the subject. So, even though we use this format in
> > Calcite,
> > > if we started over, I think we might use something like
> > > "EAGLE-{ticket_number}: message" (without brackets) instead.
> > >
> > > Strictly, you don't need the "Author:" and "Reviewer:" lines because
> they
> > > are contained in the git metadata. But you probably know that already.
> > >
> > > Julian
> > >
> > >
> > > On Tue, Dec 8, 2015 at 6:46 PM, Liangfei.Su <su...@gmail.com>
> > wrote:
> > >
> > > > Hi, PMCs
> > > >
> > > > To help clear the dev process, i'm trying to put this into eagle
> WIKI.
> > > > Please advise if it's OK to all.
> > > >
> > > > The referenced commit msg format is:
> > > >
> > > >
> > > > [EAGLE-${ticket_number}] ${ticket_title}
> > > >
> > > > ${ticket_url}
> > > >
> > > > Author: ${commiter}
> > > > Reviewer: ${reviewer}
> > > >
> > > > Closes #${pr_number} from ${do_person}
> > > >
> > > >
> > > >
> > > >
> > > > 
> > > > Thanks,
> > > > Ralph
> > > >
> > >
> >
>

Re: Re: About dev process

Posted by Michael Wu <mc...@gmail.com>.

Amareshwari,

Thanks a lot!

Michael

On Thu, Dec 10, 2015 at 1:01 PM, amareshwarisr . <am...@gmail.com>
wrote:

> Hi all,
>
> Added wuziyang as contributor. Welcome Michael !
>
> Any jira user (who shares the jira account name) , who shows interest can
> be added as contributor by PMCs. They need not be committers to start
> contributing.
>
> Thanks
> Amareshwari
>
> On Thu, Dec 10, 2015 at 6:18 AM, sul*fei <su...@163.com> wrote:
>
> > That would be fine. We might not be assignee before become committer.(not
> > sure) Contributor could also send pull request:)
> >
> >
> >
> > At 2015-12-09 23:41:34, "Michael Wu" <mc...@gmail.com> wrote:
> > >Hao,
> > >
> > >EAGLE-84 is created. I'm not able to assign it to myself. Is it possible
> > >that you add permission to my jira account "wuziyang"? Thanks.
> > >
> > >Michael
> > >
> > >On Wed, Dec 9, 2015 at 11:21 PM, Hao Chen <cn...@gmail.com> wrote:
> > >
> > >> Thanks Michael :-)
> > >>
> > >>
> > >> --
> > >>
> > >> Hao
> > >>
> > >>
> > >> On Wed, Dec 9, 2015 at 10:41 PM, Wu, Michael(Ziyang) <
> > Ziyang.Wu@ebay.com>
> > >> wrote:
> > >>
> > >> > Sure Hao, I’ll create a ticket for this task and update it with the
> > >> status.
> > >> >
> > >> > Michael
> > >> >
> > >> > From: Hao Chen <cn...@gmail.com>
> > >> > Date: Wednesday, December 09, 2015 at 16:45
> > >> > To: "dev@eagle.incubator.apache.org" <
> dev@eagle.incubator.apache.org
> > >,
> > >> > "Wu , Michael(Ziyang)" <zi...@ebay.com>
> > >> > Subject: Re: About dev process
> > >> >
> > >> > Michael, I think you are working on the task creating the automatic
> > >> script
> > >> > for the dev process? What's the status and do you have ticket to
> track
> > >> your
> > >> > work?
> > >> >
> > >> >
> > >> > --
> > >> >
> > >> > Hao
> > >> >
> > >> >
> > >> > On Wed, Dec 9, 2015 at 4:42 PM, Hao Chen <cn...@gmail.com>
> > wrote:
> > >> >
> > >> >> Liangfei,
> > >> >>
> > >> >> Could you please help document the process in Eagle wiki and we
> could
> > >> >> finalize the process ASAP? U.S. and Indian committers are pending
> on
> > >> this
> > >> >> process to merge new features.
> > >> >>
> > >> >>
> > >> >> --
> > >> >>
> > >> >> Hao
> > >> >>
> > >> >>
> > >> >>
> > >> >> On Wed, Dec 9, 2015 at 4:16 PM, Liangfei.Su <su...@gmail.com>
> > >> wrote:
> > >> >>
> > >> >>> Yes, the '[]' is not expected here. It should be typo when i copy
> > from
> > >> my
> > >> >>> text editor. We don't need that.
> > >> >>>
> > >> >>> Regarding the author and reviewer, i agree that they're optional.
> > The
> > >> >>> main
> > >> >>> idea here is that if we could states the name of reviewers here.
> > (And
> > >> >>> yes,
> > >> >>> the reviewers should give their comments on pull request page
> which
> > is
> > >> >>> traceable from the ${ticket_number}, just want to make this
> > information
> > >> >>> explicitly here :) ). Let's make this info as optional.
> > >> >>>
> > >> >>> Ralph
> > >> >>>
> > >> >>>
> > >> >>> On Wed, Dec 9, 2015 at 4:00 PM, Julian Hyde <jh...@apache.org>
> > wrote:
> > >> >>>
> > >> >>> > One minor problem with the "[EAGLE-${ticket_number}] message"
> > format
> > >> >>> is the
> > >> >>> > 'git am' command. When it reads patches from a mail box, it uses
> > the
> > >> >>> > subject of each email as the commit message but it strips off
> any
> > [
> > >> >>> ... ]
> > >> >>> > at the start of the subject. So, even though we use this format
> in
> > >> >>> Calcite,
> > >> >>> > if we started over, I think we might use something like
> > >> >>> > "EAGLE-{ticket_number}: message" (without brackets) instead.
> > >> >>> >
> > >> >>> > Strictly, you don't need the "Author:" and "Reviewer:" lines
> > because
> > >> >>> they
> > >> >>> > are contained in the git metadata. But you probably know that
> > >> already.
> > >> >>> >
> > >> >>> > Julian
> > >> >>> >
> > >> >>> >
> > >> >>> > On Tue, Dec 8, 2015 at 6:46 PM, Liangfei.Su <
> suliangfei@gmail.com
> > >
> > >> >>> wrote:
> > >> >>> >
> > >> >>> > > Hi, PMCs
> > >> >>> > >
> > >> >>> > > To help clear the dev process, i'm trying to put this into
> eagle
> > >> >>> WIKI.
> > >> >>> > > Please advise if it's OK to all.
> > >> >>> > >
> > >> >>> > > The referenced commit msg format is:
> > >> >>> > >
> > >> >>> > >
> > >> >>> > > [EAGLE-${ticket_number}] ${ticket_title}
> > >> >>> > >
> > >> >>> > > ${ticket_url}
> > >> >>> > >
> > >> >>> > > Author: ${commiter}
> > >> >>> > > Reviewer: ${reviewer}
> > >> >>> > >
> > >> >>> > > Closes #${pr_number} from ${do_person}
> > >> >>> > >
> > >> >>> > >
> > >> >>> > >
> > >> >>> > >
> > >> >>> > >
> > >> >>> > > Thanks,
> > >> >>> > > Ralph
> > >> >>> > >
> > >> >>> >
> > >> >>>
> > >> >>
> > >> >>
> > >> >
> > >>
> >
>

Re: Re: About dev process

Posted by "amareshwarisr ." <am...@gmail.com>.

Hi all,

Added wuziyang as contributor. Welcome Michael !

Any jira user (who shares the jira account name) , who shows interest can
be added as contributor by PMCs. They need not be committers to start
contributing.

Thanks
Amareshwari

On Thu, Dec 10, 2015 at 6:18 AM, sul*fei <su...@163.com> wrote:

> That would be fine. We might not be assignee before become committer.(not
> sure) Contributor could also send pull request:)
>
>
>
> At 2015-12-09 23:41:34, "Michael Wu" <mc...@gmail.com> wrote:
> >Hao,
> >
> >EAGLE-84 is created. I'm not able to assign it to myself. Is it possible
> >that you add permission to my jira account "wuziyang"? Thanks.
> >
> >Michael
> >
> >On Wed, Dec 9, 2015 at 11:21 PM, Hao Chen <cn...@gmail.com> wrote:
> >
> >> Thanks Michael :-)
> >>
> >>
> >> --
> >>
> >> Hao
> >>
> >>
> >> On Wed, Dec 9, 2015 at 10:41 PM, Wu, Michael(Ziyang) <
> Ziyang.Wu@ebay.com>
> >> wrote:
> >>
> >> > Sure Hao, I’ll create a ticket for this task and update it with the
> >> status.
> >> >
> >> > Michael
> >> >
> >> > From: Hao Chen <cn...@gmail.com>
> >> > Date: Wednesday, December 09, 2015 at 16:45
> >> > To: "dev@eagle.incubator.apache.org" <dev@eagle.incubator.apache.org
> >,
> >> > "Wu , Michael(Ziyang)" <zi...@ebay.com>
> >> > Subject: Re: About dev process
> >> >
> >> > Michael, I think you are working on the task creating the automatic
> >> script
> >> > for the dev process? What's the status and do you have ticket to track
> >> your
> >> > work?
> >> >
> >> >
> >> > --
> >> >
> >> > Hao
> >> >
> >> >
> >> > On Wed, Dec 9, 2015 at 4:42 PM, Hao Chen <cn...@gmail.com>
> wrote:
> >> >
> >> >> Liangfei,
> >> >>
> >> >> Could you please help document the process in Eagle wiki and we could
> >> >> finalize the process ASAP? U.S. and Indian committers are pending on
> >> this
> >> >> process to merge new features.
> >> >>
> >> >>
> >> >> --
> >> >>
> >> >> Hao
> >> >>
> >> >>
> >> >>
> >> >> On Wed, Dec 9, 2015 at 4:16 PM, Liangfei.Su <su...@gmail.com>
> >> wrote:
> >> >>
> >> >>> Yes, the '[]' is not expected here. It should be typo when i copy
> from
> >> my
> >> >>> text editor. We don't need that.
> >> >>>
> >> >>> Regarding the author and reviewer, i agree that they're optional.
> The
> >> >>> main
> >> >>> idea here is that if we could states the name of reviewers here.
> (And
> >> >>> yes,
> >> >>> the reviewers should give their comments on pull request page which
> is
> >> >>> traceable from the ${ticket_number}, just want to make this
> information
> >> >>> explicitly here :) ). Let's make this info as optional.
> >> >>>
> >> >>> Ralph
> >> >>>
> >> >>>
> >> >>> On Wed, Dec 9, 2015 at 4:00 PM, Julian Hyde <jh...@apache.org>
> wrote:
> >> >>>
> >> >>> > One minor problem with the "[EAGLE-${ticket_number}] message"
> format
> >> >>> is the
> >> >>> > 'git am' command. When it reads patches from a mail box, it uses
> the
> >> >>> > subject of each email as the commit message but it strips off any
> [
> >> >>> ... ]
> >> >>> > at the start of the subject. So, even though we use this format in
> >> >>> Calcite,
> >> >>> > if we started over, I think we might use something like
> >> >>> > "EAGLE-{ticket_number}: message" (without brackets) instead.
> >> >>> >
> >> >>> > Strictly, you don't need the "Author:" and "Reviewer:" lines
> because
> >> >>> they
> >> >>> > are contained in the git metadata. But you probably know that
> >> already.
> >> >>> >
> >> >>> > Julian
> >> >>> >
> >> >>> >
> >> >>> > On Tue, Dec 8, 2015 at 6:46 PM, Liangfei.Su <suliangfei@gmail.com
> >
> >> >>> wrote:
> >> >>> >
> >> >>> > > Hi, PMCs
> >> >>> > >
> >> >>> > > To help clear the dev process, i'm trying to put this into eagle
> >> >>> WIKI.
> >> >>> > > Please advise if it's OK to all.
> >> >>> > >
> >> >>> > > The referenced commit msg format is:
> >> >>> > >
> >> >>> > >
> >> >>> > > [EAGLE-${ticket_number}] ${ticket_title}
> >> >>> > >
> >> >>> > > ${ticket_url}
> >> >>> > >
> >> >>> > > Author: ${commiter}
> >> >>> > > Reviewer: ${reviewer}
> >> >>> > >
> >> >>> > > Closes #${pr_number} from ${do_person}
> >> >>> > >
> >> >>> > >
> >> >>> > >
> >> >>> > >
> >> >>> > >
> >> >>> > > Thanks,
> >> >>> > > Ralph
> >> >>> > >
> >> >>> >
> >> >>>
> >> >>
> >> >>
> >> >
> >>
>

Re:Re: About dev process

Posted by sul*fei <su...@163.com>.

That would be fine. We might not be assignee before become committer.(not sure) Contributor could also send pull request:)



At 2015-12-09 23:41:34, "Michael Wu" <mc...@gmail.com> wrote:
>Hao,
>
>EAGLE-84 is created. I'm not able to assign it to myself. Is it possible
>that you add permission to my jira account "wuziyang"? Thanks.
>
>Michael
>
>On Wed, Dec 9, 2015 at 11:21 PM, Hao Chen <cn...@gmail.com> wrote:
>
>> Thanks Michael :-)
>>
>>
>> --
>>
>> Hao
>>
>>
>> On Wed, Dec 9, 2015 at 10:41 PM, Wu, Michael(Ziyang) <Zi...@ebay.com>
>> wrote:
>>
>> > Sure Hao, I’ll create a ticket for this task and update it with the
>> status.
>> >
>> > Michael
>> >
>> > From: Hao Chen <cn...@gmail.com>
>> > Date: Wednesday, December 09, 2015 at 16:45
>> > To: "dev@eagle.incubator.apache.org" <de...@eagle.incubator.apache.org>,
>> > "Wu , Michael(Ziyang)" <zi...@ebay.com>
>> > Subject: Re: About dev process
>> >
>> > Michael, I think you are working on the task creating the automatic
>> script
>> > for the dev process? What's the status and do you have ticket to track
>> your
>> > work?
>> >
>> >
>> > --
>> >
>> > Hao
>> >
>> >
>> > On Wed, Dec 9, 2015 at 4:42 PM, Hao Chen <cn...@gmail.com> wrote:
>> >
>> >> Liangfei,
>> >>
>> >> Could you please help document the process in Eagle wiki and we could
>> >> finalize the process ASAP? U.S. and Indian committers are pending on
>> this
>> >> process to merge new features.
>> >>
>> >>
>> >> --
>> >>
>> >> Hao
>> >>
>> >>
>> >>
>> >> On Wed, Dec 9, 2015 at 4:16 PM, Liangfei.Su <su...@gmail.com>
>> wrote:
>> >>
>> >>> Yes, the '[]' is not expected here. It should be typo when i copy from
>> my
>> >>> text editor. We don't need that.
>> >>>
>> >>> Regarding the author and reviewer, i agree that they're optional. The
>> >>> main
>> >>> idea here is that if we could states the name of reviewers here. (And
>> >>> yes,
>> >>> the reviewers should give their comments on pull request page which is
>> >>> traceable from the ${ticket_number}, just want to make this information
>> >>> explicitly here :) ). Let's make this info as optional.
>> >>>
>> >>> Ralph
>> >>>
>> >>>
>> >>> On Wed, Dec 9, 2015 at 4:00 PM, Julian Hyde <jh...@apache.org> wrote:
>> >>>
>> >>> > One minor problem with the "[EAGLE-${ticket_number}] message" format
>> >>> is the
>> >>> > 'git am' command. When it reads patches from a mail box, it uses the
>> >>> > subject of each email as the commit message but it strips off any [
>> >>> ... ]
>> >>> > at the start of the subject. So, even though we use this format in
>> >>> Calcite,
>> >>> > if we started over, I think we might use something like
>> >>> > "EAGLE-{ticket_number}: message" (without brackets) instead.
>> >>> >
>> >>> > Strictly, you don't need the "Author:" and "Reviewer:" lines because
>> >>> they
>> >>> > are contained in the git metadata. But you probably know that
>> already.
>> >>> >
>> >>> > Julian
>> >>> >
>> >>> >
>> >>> > On Tue, Dec 8, 2015 at 6:46 PM, Liangfei.Su <su...@gmail.com>
>> >>> wrote:
>> >>> >
>> >>> > > Hi, PMCs
>> >>> > >
>> >>> > > To help clear the dev process, i'm trying to put this into eagle
>> >>> WIKI.
>> >>> > > Please advise if it's OK to all.
>> >>> > >
>> >>> > > The referenced commit msg format is:
>> >>> > >
>> >>> > >
>> >>> > > [EAGLE-${ticket_number}] ${ticket_title}
>> >>> > >
>> >>> > > ${ticket_url}
>> >>> > >
>> >>> > > Author: ${commiter}
>> >>> > > Reviewer: ${reviewer}
>> >>> > >
>> >>> > > Closes #${pr_number} from ${do_person}
>> >>> > >
>> >>> > >
>> >>> > >
>> >>> > >
>> >>> > > 
>> >>> > > Thanks,
>> >>> > > Ralph
>> >>> > >
>> >>> >
>> >>>
>> >>
>> >>
>> >
>>

Re: About dev process

Posted by Michael Wu <mc...@gmail.com>.

Hao,

EAGLE-84 is created. I'm not able to assign it to myself. Is it possible
that you add permission to my jira account "wuziyang"? Thanks.

Michael

On Wed, Dec 9, 2015 at 11:21 PM, Hao Chen <cn...@gmail.com> wrote:

> Thanks Michael :-)
>
>
> --
>
> Hao
>
>
> On Wed, Dec 9, 2015 at 10:41 PM, Wu, Michael(Ziyang) <Zi...@ebay.com>
> wrote:
>
> > Sure Hao, I’ll create a ticket for this task and update it with the
> status.
> >
> > Michael
> >
> > From: Hao Chen <cn...@gmail.com>
> > Date: Wednesday, December 09, 2015 at 16:45
> > To: "dev@eagle.incubator.apache.org" <de...@eagle.incubator.apache.org>,
> > "Wu , Michael(Ziyang)" <zi...@ebay.com>
> > Subject: Re: About dev process
> >
> > Michael, I think you are working on the task creating the automatic
> script
> > for the dev process? What's the status and do you have ticket to track
> your
> > work?
> >
> >
> > --
> >
> > Hao
> >
> >
> > On Wed, Dec 9, 2015 at 4:42 PM, Hao Chen <cn...@gmail.com> wrote:
> >
> >> Liangfei,
> >>
> >> Could you please help document the process in Eagle wiki and we could
> >> finalize the process ASAP? U.S. and Indian committers are pending on
> this
> >> process to merge new features.
> >>
> >>
> >> --
> >>
> >> Hao
> >>
> >>
> >>
> >> On Wed, Dec 9, 2015 at 4:16 PM, Liangfei.Su <su...@gmail.com>
> wrote:
> >>
> >>> Yes, the '[]' is not expected here. It should be typo when i copy from
> my
> >>> text editor. We don't need that.
> >>>
> >>> Regarding the author and reviewer, i agree that they're optional. The
> >>> main
> >>> idea here is that if we could states the name of reviewers here. (And
> >>> yes,
> >>> the reviewers should give their comments on pull request page which is
> >>> traceable from the ${ticket_number}, just want to make this information
> >>> explicitly here :) ). Let's make this info as optional.
> >>>
> >>> Ralph
> >>>
> >>>
> >>> On Wed, Dec 9, 2015 at 4:00 PM, Julian Hyde <jh...@apache.org> wrote:
> >>>
> >>> > One minor problem with the "[EAGLE-${ticket_number}] message" format
> >>> is the
> >>> > 'git am' command. When it reads patches from a mail box, it uses the
> >>> > subject of each email as the commit message but it strips off any [
> >>> ... ]
> >>> > at the start of the subject. So, even though we use this format in
> >>> Calcite,
> >>> > if we started over, I think we might use something like
> >>> > "EAGLE-{ticket_number}: message" (without brackets) instead.
> >>> >
> >>> > Strictly, you don't need the "Author:" and "Reviewer:" lines because
> >>> they
> >>> > are contained in the git metadata. But you probably know that
> already.
> >>> >
> >>> > Julian
> >>> >
> >>> >
> >>> > On Tue, Dec 8, 2015 at 6:46 PM, Liangfei.Su <su...@gmail.com>
> >>> wrote:
> >>> >
> >>> > > Hi, PMCs
> >>> > >
> >>> > > To help clear the dev process, i'm trying to put this into eagle
> >>> WIKI.
> >>> > > Please advise if it's OK to all.
> >>> > >
> >>> > > The referenced commit msg format is:
> >>> > >
> >>> > >
> >>> > > [EAGLE-${ticket_number}] ${ticket_title}
> >>> > >
> >>> > > ${ticket_url}
> >>> > >
> >>> > > Author: ${commiter}
> >>> > > Reviewer: ${reviewer}
> >>> > >
> >>> > > Closes #${pr_number} from ${do_person}
> >>> > >
> >>> > >
> >>> > >
> >>> > >
> >>> > > 
> >>> > > Thanks,
> >>> > > Ralph
> >>> > >
> >>> >
> >>>
> >>
> >>
> >
>

Re: About dev process

Posted by Hao Chen <cn...@gmail.com>.

Thanks Michael :-)


--

Hao


On Wed, Dec 9, 2015 at 10:41 PM, Wu, Michael(Ziyang) <Zi...@ebay.com>
wrote:

> Sure Hao, I’ll create a ticket for this task and update it with the status.
>
> Michael
>
> From: Hao Chen <cn...@gmail.com>
> Date: Wednesday, December 09, 2015 at 16:45
> To: "dev@eagle.incubator.apache.org" <de...@eagle.incubator.apache.org>,
> "Wu , Michael(Ziyang)" <zi...@ebay.com>
> Subject: Re: About dev process
>
> Michael, I think you are working on the task creating the automatic script
> for the dev process? What's the status and do you have ticket to track your
> work?
>
>
> --
>
> Hao
>
>
> On Wed, Dec 9, 2015 at 4:42 PM, Hao Chen <cn...@gmail.com> wrote:
>
>> Liangfei,
>>
>> Could you please help document the process in Eagle wiki and we could
>> finalize the process ASAP? U.S. and Indian committers are pending on this
>> process to merge new features.
>>
>>
>> --
>>
>> Hao
>>
>>
>>
>> On Wed, Dec 9, 2015 at 4:16 PM, Liangfei.Su <su...@gmail.com> wrote:
>>
>>> Yes, the '[]' is not expected here. It should be typo when i copy from my
>>> text editor. We don't need that.
>>>
>>> Regarding the author and reviewer, i agree that they're optional. The
>>> main
>>> idea here is that if we could states the name of reviewers here. (And
>>> yes,
>>> the reviewers should give their comments on pull request page which is
>>> traceable from the ${ticket_number}, just want to make this information
>>> explicitly here :) ). Let's make this info as optional.
>>>
>>> Ralph
>>>
>>>
>>> On Wed, Dec 9, 2015 at 4:00 PM, Julian Hyde <jh...@apache.org> wrote:
>>>
>>> > One minor problem with the "[EAGLE-${ticket_number}] message" format
>>> is the
>>> > 'git am' command. When it reads patches from a mail box, it uses the
>>> > subject of each email as the commit message but it strips off any [
>>> ... ]
>>> > at the start of the subject. So, even though we use this format in
>>> Calcite,
>>> > if we started over, I think we might use something like
>>> > "EAGLE-{ticket_number}: message" (without brackets) instead.
>>> >
>>> > Strictly, you don't need the "Author:" and "Reviewer:" lines because
>>> they
>>> > are contained in the git metadata. But you probably know that already.
>>> >
>>> > Julian
>>> >
>>> >
>>> > On Tue, Dec 8, 2015 at 6:46 PM, Liangfei.Su <su...@gmail.com>
>>> wrote:
>>> >
>>> > > Hi, PMCs
>>> > >
>>> > > To help clear the dev process, i'm trying to put this into eagle
>>> WIKI.
>>> > > Please advise if it's OK to all.
>>> > >
>>> > > The referenced commit msg format is:
>>> > >
>>> > >
>>> > > [EAGLE-${ticket_number}] ${ticket_title}
>>> > >
>>> > > ${ticket_url}
>>> > >
>>> > > Author: ${commiter}
>>> > > Reviewer: ${reviewer}
>>> > >
>>> > > Closes #${pr_number} from ${do_person}
>>> > >
>>> > >
>>> > >
>>> > >
>>> > > 
>>> > > Thanks,
>>> > > Ralph
>>> > >
>>> >
>>>
>>
>>
>

Re: About dev process

Posted by Hao Chen <cn...@gmail.com>.

Michael, I think you are working on the task creating the automatic script
for the dev process? What's the status and do you have ticket to track your
work?


--

Hao


On Wed, Dec 9, 2015 at 4:42 PM, Hao Chen <cn...@gmail.com> wrote:

> Liangfei,
>
> Could you please help document the process in Eagle wiki and we could
> finalize the process ASAP? U.S. and Indian committers are pending on this
> process to merge new features.
>
>
> --
>
> Hao
>
>
>
> On Wed, Dec 9, 2015 at 4:16 PM, Liangfei.Su <su...@gmail.com> wrote:
>
>> Yes, the '[]' is not expected here. It should be typo when i copy from my
>> text editor. We don't need that.
>>
>> Regarding the author and reviewer, i agree that they're optional. The main
>> idea here is that if we could states the name of reviewers here. (And yes,
>> the reviewers should give their comments on pull request page which is
>> traceable from the ${ticket_number}, just want to make this information
>> explicitly here :) ). Let's make this info as optional.
>>
>> Ralph
>>
>>
>> On Wed, Dec 9, 2015 at 4:00 PM, Julian Hyde <jh...@apache.org> wrote:
>>
>> > One minor problem with the "[EAGLE-${ticket_number}] message" format is
>> the
>> > 'git am' command. When it reads patches from a mail box, it uses the
>> > subject of each email as the commit message but it strips off any [ ...
>> ]
>> > at the start of the subject. So, even though we use this format in
>> Calcite,
>> > if we started over, I think we might use something like
>> > "EAGLE-{ticket_number}: message" (without brackets) instead.
>> >
>> > Strictly, you don't need the "Author:" and "Reviewer:" lines because
>> they
>> > are contained in the git metadata. But you probably know that already.
>> >
>> > Julian
>> >
>> >
>> > On Tue, Dec 8, 2015 at 6:46 PM, Liangfei.Su <su...@gmail.com>
>> wrote:
>> >
>> > > Hi, PMCs
>> > >
>> > > To help clear the dev process, i'm trying to put this into eagle WIKI.
>> > > Please advise if it's OK to all.
>> > >
>> > > The referenced commit msg format is:
>> > >
>> > >
>> > > [EAGLE-${ticket_number}] ${ticket_title}
>> > >
>> > > ${ticket_url}
>> > >
>> > > Author: ${commiter}
>> > > Reviewer: ${reviewer}
>> > >
>> > > Closes #${pr_number} from ${do_person}
>> > >
>> > >
>> > >
>> > >
>> > > 
>> > > Thanks,
>> > > Ralph
>> > >
>> >
>>
>
>

Re: About dev process

Posted by Hao Chen <cn...@gmail.com>.

Liangfei,

Could you please help document the process in Eagle wiki and we could
finalize the process ASAP? U.S. and Indian committers are pending on this
process to merge new features.


--

Hao



On Wed, Dec 9, 2015 at 4:16 PM, Liangfei.Su <su...@gmail.com> wrote:

> Yes, the '[]' is not expected here. It should be typo when i copy from my
> text editor. We don't need that.
>
> Regarding the author and reviewer, i agree that they're optional. The main
> idea here is that if we could states the name of reviewers here. (And yes,
> the reviewers should give their comments on pull request page which is
> traceable from the ${ticket_number}, just want to make this information
> explicitly here :) ). Let's make this info as optional.
>
> Ralph
>
>
> On Wed, Dec 9, 2015 at 4:00 PM, Julian Hyde <jh...@apache.org> wrote:
>
> > One minor problem with the "[EAGLE-${ticket_number}] message" format is
> the
> > 'git am' command. When it reads patches from a mail box, it uses the
> > subject of each email as the commit message but it strips off any [ ... ]
> > at the start of the subject. So, even though we use this format in
> Calcite,
> > if we started over, I think we might use something like
> > "EAGLE-{ticket_number}: message" (without brackets) instead.
> >
> > Strictly, you don't need the "Author:" and "Reviewer:" lines because they
> > are contained in the git metadata. But you probably know that already.
> >
> > Julian
> >
> >
> > On Tue, Dec 8, 2015 at 6:46 PM, Liangfei.Su <su...@gmail.com>
> wrote:
> >
> > > Hi, PMCs
> > >
> > > To help clear the dev process, i'm trying to put this into eagle WIKI.
> > > Please advise if it's OK to all.
> > >
> > > The referenced commit msg format is:
> > >
> > >
> > > [EAGLE-${ticket_number}] ${ticket_title}
> > >
> > > ${ticket_url}
> > >
> > > Author: ${commiter}
> > > Reviewer: ${reviewer}
> > >
> > > Closes #${pr_number} from ${do_person}
> > >
> > >
> > >
> > >
> > > 
> > > Thanks,
> > > Ralph
> > >
> >
>

Re: About dev process

Posted by "Liangfei.Su" <su...@gmail.com>.

Yes, the '[]' is not expected here. It should be typo when i copy from my
text editor. We don't need that.

Regarding the author and reviewer, i agree that they're optional. The main
idea here is that if we could states the name of reviewers here. (And yes,
the reviewers should give their comments on pull request page which is
traceable from the ${ticket_number}, just want to make this information
explicitly here :) ). Let's make this info as optional.

Ralph

On Wed, Dec 9, 2015 at 4:00 PM, Julian Hyde <jh...@apache.org> wrote:

> One minor problem with the "[EAGLE-${ticket_number}] message" format is the
> 'git am' command. When it reads patches from a mail box, it uses the
> subject of each email as the commit message but it strips off any [ ... ]
> at the start of the subject. So, even though we use this format in Calcite,
> if we started over, I think we might use something like
> "EAGLE-{ticket_number}: message" (without brackets) instead.
>
> Strictly, you don't need the "Author:" and "Reviewer:" lines because they
> are contained in the git metadata. But you probably know that already.
>
> Julian
>
>
> On Tue, Dec 8, 2015 at 6:46 PM, Liangfei.Su <su...@gmail.com> wrote:
>
> > Hi, PMCs
> >
> > To help clear the dev process, i'm trying to put this into eagle WIKI.
> > Please advise if it's OK to all.
> >
> > The referenced commit msg format is:
> >
> >
> > [EAGLE-${ticket_number}] ${ticket_title}
> >
> > ${ticket_url}
> >
> > Author: ${commiter}
> > Reviewer: ${reviewer}
> >
> > Closes #${pr_number} from ${do_person}
> >
> >
> >
> >
> > 
> > Thanks,
> > Ralph
> >
>

Re: About dev process

Posted by Julian Hyde <jh...@apache.org>.

One minor problem with the "[EAGLE-${ticket_number}] message" format is the
'git am' command. When it reads patches from a mail box, it uses the
subject of each email as the commit message but it strips off any [ ... ]
at the start of the subject. So, even though we use this format in Calcite,
if we started over, I think we might use something like
"EAGLE-{ticket_number}: message" (without brackets) instead.

Strictly, you don't need the "Author:" and "Reviewer:" lines because they
are contained in the git metadata. But you probably know that already.

Julian

On Tue, Dec 8, 2015 at 6:46 PM, Liangfei.Su <su...@gmail.com> wrote:

> Hi, PMCs
>
> To help clear the dev process, i'm trying to put this into eagle WIKI.
> Please advise if it's OK to all.
>
> The referenced commit msg format is:
>
>
> [EAGLE-${ticket_number}] ${ticket_title}
>
> ${ticket_url}
>
> Author: ${commiter}
> Reviewer: ${reviewer}
>
> Closes #${pr_number} from ${do_person}
>
>
>
>
> 
> Thanks,
> Ralph
>

Re: About dev process

Posted by "Liangfei.Su" <su...@gmail.com>.

CIL


On Wed, Dec 9, 2015 at 11:07 AM, Zhang, Edward (GDI Hadoop) <
yonzhang@ebay.com> wrote:

> +1.
> Looks like picture can’t show up in dev mail list. I think that is good to
> put that into eagle wiki.
>
> My only concern is contributor/committer roles. Is that common practice to
> divide the 2 roles? Is committer the person who shows up in contributor
> list in git hub?
>
> I'm afraid the contributor won't show in the github, since the contributor
based on the commit history, i don't think it will detail into the commit
MSG. The contributor/committer roles are used in projects like eclipse
which using patch based merge. I haven't found detailed formal definition
in apache way. But the sole purpose here is to keep the history clear, and
contributor remarkable (through commit msg).

-Ralph


> Thanks
> Edward Zhang
>
> From: "Liangfei.Su" <su...@gmail.com>>
> Reply-To: "dev@eagle.incubator.apache.org<mailto:
> dev@eagle.incubator.apache.org>" <dev@eagle.incubator.apache.org<mailto:
> dev@eagle.incubator.apache.org>>
> Date: Tuesday, December 8, 2015 at 18:46
> To: "dev@eagle.incubator.apache.org<ma...@eagle.incubator.apache.org>"
> <de...@eagle.incubator.apache.org>>
> Subject: About dev process
>
> Hi, PMCs
>
> To help clear the dev process, i'm trying to put this into eagle WIKI.
> Please advise if it's OK to all.
>
> The referenced commit msg format is:
>
>
> [EAGLE-${ticket_number}] ${ticket_title}
>
> ${ticket_url}
>
> Author: ${commiter}
> Reviewer: ${reviewer}
>
> Closes #${pr_number} from ${do_person}
>
>
>
> [cid:ii_ihy78o9a0_1518493e28a2f6cc]
> 
> Thanks,
> Ralph
>

Re: About dev process

Posted by "Zhang, Edward (GDI Hadoop)" <yo...@ebay.com>.

+1.
Looks like picture can’t show up in dev mail list. I think that is good to put that into eagle wiki.

My only concern is contributor/committer roles. Is that common practice to divide the 2 roles? Is committer the person who shows up in contributor list in git hub?

Thanks
Edward Zhang

From: "Liangfei.Su" <su...@gmail.com>>
Reply-To: "dev@eagle.incubator.apache.org<ma...@eagle.incubator.apache.org>" <de...@eagle.incubator.apache.org>>
Date: Tuesday, December 8, 2015 at 18:46
To: "dev@eagle.incubator.apache.org<ma...@eagle.incubator.apache.org>" <de...@eagle.incubator.apache.org>>
Subject: About dev process

Hi, PMCs

To help clear the dev process, i'm trying to put this into eagle WIKI.
Please advise if it's OK to all.

The referenced commit msg format is:


[EAGLE-${ticket_number}] ${ticket_title}

${ticket_url}

Author: ${commiter}
Reviewer: ${reviewer}

Closes #${pr_number} from ${do_person}



[cid:ii_ihy78o9a0_1518493e28a2f6cc]

Thanks,
Ralph