You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/08 20:10:01 UTC

[GitHub] [beam] tvalentyn commented on a diff in pull request #22999: Allow expansion service to choose pickler.

tvalentyn commented on code in PR #22999:
URL: https://github.com/apache/beam/pull/22999#discussion_r966377773


##########
sdks/python/apache_beam/runners/portability/local_job_service_main.py:
##########
@@ -129,6 +131,9 @@ def run(argv):
     print('Server started at port', port)
     return
 
+  if options.default_pickler:
+    pickler.set_library(options.default_pickler)

Review Comment:
   should we set the `--pickler_library` pipeline option in this case?
   
   Also noting the naming difference for a similar concept - should this be renamed into `--pickler_library`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org