You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/04/21 19:47:16 UTC

[GitHub] [guacamole-client] necouchman commented on pull request #604: GUACAMOLE-1291: Add Korean language support

necouchman commented on pull request #604:
URL: https://github.com/apache/guacamole-client/pull/604#issuecomment-824313142


   Just at a glance, your commit messages should be a little more descriptive. You have 9 commit messages that say "Update ko.json", and then the final one is relatively similar (Add multiple ko.json files). Commit messages should describe at a high level what the commit is doing, and if all 9 of those commit messages are really updating the same ko.json file, they should be squashed together.
   
   For reference:
   https://www.codelord.net/2015/03/16/bad-commit-messages-hall-of-shame/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org