You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/30 11:22:56 UTC
[GitHub] [pulsar] shibd opened a new pull request, #16305: [improve][connector] Add getSourceConfig method on SourceContext.
shibd opened a new pull request, #16305:
URL: https://github.com/apache/pulsar/pull/16305
### Motivation
The configuration of SourceConfig is rich, and the user can flexibly specify it when registering the source. But some sources do not support these configurations. For example, some sources do not support `EFFECTIVELY_ONCE` guarantees, because the upstream system cannot generate ordered sequence id.
So, add the `getSourceConfig` method to SinkContext, enables the source to validate the configuration when executing the `source.open` method.
### Modifications
- Add getSourceConfig method to SourceContext
### Documentation
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nahguam commented on pull request #16305: [improve][connector] Add getSourceConfig method on SourceContext.
Posted by GitBox <gi...@apache.org>.
nahguam commented on PR #16305:
URL: https://github.com/apache/pulsar/pull/16305#issuecomment-1173499530
> So, add the `getSourceConfig` method to SinkContext
Do you mean add it to `SourceContext`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #16305: [improve][connector] Add getSourceConfig method on SourceContext.
Posted by GitBox <gi...@apache.org>.
shibd commented on PR #16305:
URL: https://github.com/apache/pulsar/pull/16305#issuecomment-1173544984
> Do you mean add it to `SourceContext`?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #16305: [improve][connector] Add getSourceConfig method on SourceContext.
Posted by GitBox <gi...@apache.org>.
shibd commented on PR #16305:
URL: https://github.com/apache/pulsar/pull/16305#issuecomment-1171387949
@nlu90 @freeznet @codelipenghui Please help review it, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #16305: [improve][connector] Add getSourceConfig method on SourceContext.
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #16305:
URL: https://github.com/apache/pulsar/pull/16305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nlu90 commented on pull request #16305: [improve][connector] Add getSourceConfig method on SourceContext.
Posted by GitBox <gi...@apache.org>.
nlu90 commented on PR #16305:
URL: https://github.com/apache/pulsar/pull/16305#issuecomment-1192236919
> ### Motivation
> ...
> So, add the `getSourceConfig` method to SinkContext, enables the source to validate the configuration when executing the `source.open` method.
^^ The PR is good, but the description has some typo. change `SinkContext` to `SourceContext`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #16305: [improve][connector] Add getSourceConfig method on SourceContext.
Posted by GitBox <gi...@apache.org>.
shibd commented on PR #16305:
URL: https://github.com/apache/pulsar/pull/16305#issuecomment-1192245301
> ^^ The PR is good, but the description has some typo. change SinkContext to SourceContext
Sorry, I changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org