You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "borinquenkid (via GitHub)" <gi...@apache.org> on 2026/08/23 16:06:02 UTC
[PR] chore(grails-data-graphql): root-level cleanup (GraphQLEntityHelper, GraphQLServiceManager, Schema) [grails-core]
borinquenkid opened a new pull request, #16207:
URL: https://github.com/apache/grails-core/pull/16207
## Summary
Stacked on #16201. Three small root-package fixes:
- `GraphQLEntityHelper#getMapping`: consolidated a four-branch reassignment of `mapping` into single-return helper methods (`findGraphqlProperty`, `toGraphQLMapping`, `buildMapping`), fixing a false "assignment is not used" flag. Added direct unit coverage (previously only exercised indirectly via `getDescription`).
- `GraphQLServiceManager#getService`: removed a redundant `public` modifier (Groovy methods are public by default).
- `Schema#generate()`: made the implicit `null` return explicit when no entity contributes any query fields, satisfying "not all execution paths return a value" with no behavior change (already covered by `DisableAllOpSpec`).
## Test plan
- [x] `./gradlew :grails-data-graphql-core:test :grails-data-graphql:test :grails-data-graphql-core:codeStyle :grails-data-graphql:codeStyle` passes
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(grails-data-graphql): root-level cleanup (GraphQLEntityHelper, GraphQLServiceManager, Schema) [grails-core]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16207:
URL: https://github.com/apache/grails-core/pull/16207#issuecomment-5387139966
## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16207?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:warning: Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`test/grails-data-graphql-coverage@36b7716`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit) about missing BASE report.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/grails-core/pull/16207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## test/grails-data-graphql-coverage #16207 +/- ##
======================================================================
Coverage ? 53.4210%
Complexity ? 19464
======================================================================
Files ? 2081
Lines ? 98993
Branches ? 17361
======================================================================
Hits ? 52883
Misses ? 38561
Partials ? 7549
```
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(grails-data-graphql): root-level cleanup (GraphQLEntityHelper, GraphQLServiceManager, Schema) [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16207:
URL: https://github.com/apache/grails-core/pull/16207#issuecomment-5387522490
## ✅ All tests passed ✅
🏷️ Commit: cc285e7d6a2bf460250a9ccdcba212ffae64939d
▶️ Tests: 47666 executed
⚪️ Checks: 70/70 completed
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(grails-data-graphql): root-level cleanup (GraphQLEntityHelper, GraphQLServiceManager, Schema) [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty merged PR #16207:
URL: https://github.com/apache/grails-core/pull/16207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org