[GitHub] [arrow] ianmcook commented on a change in pull request #9952: ARROW-12197: [R] dplyr bindings for cast, dictionary_encode [WIP]

[GitBox <gi...@apache.org>]

ianmcook commented on a change in pull request #9952:
URL: https://github.com/apache/arrow/pull/9952#discussion_r609991160



##########
File path: r/tests/testthat/test-dplyr.R
##########
@@ -421,12 +484,13 @@ test_that("explicit type conversions", {
         int2dbl = as.double(int),
         int2int = as.integer(int),
         int2lgl = as.logical(int),
-        lgl2chr = toupper(as.character(lgl)), # Arrow returns "true", "false"
+        lgl2chr = as.character(lgl), # Arrow returns "true", "false" here ...
         lgl2dbl = as.double(lgl),
         lgl2int = as.integer(lgl),
-        lgl2lgl = as.logical(lgl),
+        lgl2lgl = as.logical(lgl)
       ) %>%
-      collect(),
+      collect() %>%
+      mutate(lgl2chr = toupper(lgl2chr)), # ... but we need "TRUE", "FALSE"

Review comment:
       I moved the `toupper()` to after `collect()` to allow this test to run successfully without utf8proc. This fixes a `test-r-minimal-build` failure 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org