You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/05 04:18:12 UTC

[GitHub] [arrow-rs] matthewmturner commented on a change in pull request #1131: Add dyn boolean kernels

matthewmturner commented on a change in pull request #1131:
URL: https://github.com/apache/arrow-rs/pull/1131#discussion_r778536229



##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -3599,4 +3674,59 @@ mod tests {
             BooleanArray::from(vec![Some(false), Some(true), Some(false)])
         );
     }
+
+    #[test]
+    fn test_lt_dyn_bool_scalar() {

Review comment:
       sure - but can you expand on why? is there a specific concern on this test with nulls?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org