You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/09/25 18:56:30 UTC

Review Request 62551: Make Log Search IT work with the new UI

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62551/
-----------------------------------------------------------

Review request for Ambari, Attila Doroszlai, Miklos Gergely, Robert Nettleton, and Sandor Magyari.


Bugs: AMBARI-22055
    https://issues.apache.org/jira/browse/AMBARI-22055


Repository: ambari


Description
-------

As Log Search has a new UI, integration test framework cannot login (with Selenium) anyomore during test run (using X11)

Fix that to make IT tests work with the new UI


Diffs
-----

  ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchUISteps.java b40a2bc 
  ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/selenium/login.ui.story 543c211 


Diff: https://reviews.apache.org/r/62551/diff/1/


Testing
-------

done. with maven failsafe plugin and enabling xquartz


Thanks,

Oliver Szabo


Re: Review Request 62551: Make Log Search IT work with the new UI

Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62551/#review186166
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Nettleton


On Sept. 25, 2017, 6:56 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62551/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2017, 6:56 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Miklos Gergely, Robert Nettleton, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-22055
>     https://issues.apache.org/jira/browse/AMBARI-22055
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> As Log Search has a new UI, integration test framework cannot login (with Selenium) anyomore during test run (using X11)
> 
> Fix that to make IT tests work with the new UI
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchUISteps.java b40a2bc 
>   ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/selenium/login.ui.story 543c211 
> 
> 
> Diff: https://reviews.apache.org/r/62551/diff/1/
> 
> 
> Testing
> -------
> 
> done. with maven failsafe plugin and enabling xquartz
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Re: Review Request 62551: Make Log Search IT work with the new UI

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62551/#review186219
-----------------------------------------------------------


Ship it!




Ship It!

- Miklos Gergely


On Sept. 25, 2017, 6:56 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62551/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2017, 6:56 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Miklos Gergely, Robert Nettleton, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-22055
>     https://issues.apache.org/jira/browse/AMBARI-22055
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> As Log Search has a new UI, integration test framework cannot login (with Selenium) anyomore during test run (using X11)
> 
> Fix that to make IT tests work with the new UI
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchUISteps.java b40a2bc 
>   ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/selenium/login.ui.story 543c211 
> 
> 
> Diff: https://reviews.apache.org/r/62551/diff/1/
> 
> 
> Testing
> -------
> 
> done. with maven failsafe plugin and enabling xquartz
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>