You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "James Peach (Created) (JIRA)" <ji...@apache.org> on 2011/12/08 04:01:48 UTC
[jira] [Created] (TS-1043) PATCH: teach TSFetchUrl to use the
content-length to find the after_body event
PATCH: teach TSFetchUrl to use the content-length to find the after_body event
------------------------------------------------------------------------------
Key: TS-1043
URL: https://issues.apache.org/jira/browse/TS-1043
Project: Traffic Server
Issue Type: Improvement
Components: HTTP
Reporter: James Peach
Attachments: 0005-TSFetchUrl-use-content-length-to-fire-after_body-eve.patch
TSFetchUrl() does not fire the after_body event until the TCP connection is closed. The fix is to check the content-length when we receive more bytes and to fire the after_body event when all the byte are received.
This looks like https://issues.apache.org/jira/browse/TS-817 and possibly https://issues.apache.org/jira/browse/TS-912
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TS-1043) PATCH: teach TSFetchUrl to use the
content-length to find the after_body event
Posted by "James Peach (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach resolved TS-1043.
-----------------------------
Resolution: Won't Fix
Assignee: James Peach
The proposed patch breaks the API as described in the previous comment. Resolving as WontFix.
> PATCH: teach TSFetchUrl to use the content-length to find the after_body event
> ------------------------------------------------------------------------------
>
> Key: TS-1043
> URL: https://issues.apache.org/jira/browse/TS-1043
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP
> Reporter: James Peach
> Assignee: James Peach
> Fix For: 3.1.2
>
> Attachments: 0005-TSFetchUrl-use-content-length-to-fire-after_body-eve.patch
>
>
> TSFetchUrl() does not fire the after_body event until the TCP connection is closed. The fix is to check the content-length when we receive more bytes and to fire the after_body event when all the byte are received.
> This looks like https://issues.apache.org/jira/browse/TS-817 and possibly https://issues.apache.org/jira/browse/TS-912
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1043) PATCH: teach TSFetchUrl to use the
content-length to find the after_body event
Posted by "James Peach (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179297#comment-13179297 ]
James Peach commented on TS-1043:
---------------------------------
Sigh. This patch breaks TSFetchRespGet() by making it return only the body bytes rather than the whole response.
> PATCH: teach TSFetchUrl to use the content-length to find the after_body event
> ------------------------------------------------------------------------------
>
> Key: TS-1043
> URL: https://issues.apache.org/jira/browse/TS-1043
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP
> Reporter: James Peach
> Fix For: 3.1.2
>
> Attachments: 0005-TSFetchUrl-use-content-length-to-fire-after_body-eve.patch
>
>
> TSFetchUrl() does not fire the after_body event until the TCP connection is closed. The fix is to check the content-length when we receive more bytes and to fire the after_body event when all the byte are received.
> This looks like https://issues.apache.org/jira/browse/TS-817 and possibly https://issues.apache.org/jira/browse/TS-912
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1043) PATCH: teach TSFetchUrl to use the
content-length to find the after_body event
Posted by "James Peach (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181149#comment-13181149 ]
James Peach commented on TS-1043:
---------------------------------
TSFetchRespGet() returns different results depending on whether you asked for AFTER_HEADER or AFTER_BODY. This patch has the incompatible side-effect of making it consistently return the result from the AFTER_HEADER case. Sigh.
We probably should reject this patch.
> PATCH: teach TSFetchUrl to use the content-length to find the after_body event
> ------------------------------------------------------------------------------
>
> Key: TS-1043
> URL: https://issues.apache.org/jira/browse/TS-1043
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP
> Reporter: James Peach
> Fix For: 3.1.2
>
> Attachments: 0005-TSFetchUrl-use-content-length-to-fire-after_body-eve.patch
>
>
> TSFetchUrl() does not fire the after_body event until the TCP connection is closed. The fix is to check the content-length when we receive more bytes and to fire the after_body event when all the byte are received.
> This looks like https://issues.apache.org/jira/browse/TS-817 and possibly https://issues.apache.org/jira/browse/TS-912
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1043) PATCH: teach TSFetchUrl to use the
content-length to find the after_body event
Posted by "James Peach (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach updated TS-1043:
----------------------------
Attachment: 0005-TSFetchUrl-use-content-length-to-fire-after_body-eve.patch
> PATCH: teach TSFetchUrl to use the content-length to find the after_body event
> ------------------------------------------------------------------------------
>
> Key: TS-1043
> URL: https://issues.apache.org/jira/browse/TS-1043
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP
> Reporter: James Peach
> Attachments: 0005-TSFetchUrl-use-content-length-to-fire-after_body-eve.patch
>
>
> TSFetchUrl() does not fire the after_body event until the TCP connection is closed. The fix is to check the content-length when we receive more bytes and to fire the after_body event when all the byte are received.
> This looks like https://issues.apache.org/jira/browse/TS-817 and possibly https://issues.apache.org/jira/browse/TS-912
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1043) PATCH: teach TSFetchUrl to use the
content-length to find the after_body event
Posted by "Leif Hedstrom (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-1043:
------------------------------
Fix Version/s: 3.1.2
> PATCH: teach TSFetchUrl to use the content-length to find the after_body event
> ------------------------------------------------------------------------------
>
> Key: TS-1043
> URL: https://issues.apache.org/jira/browse/TS-1043
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP
> Reporter: James Peach
> Fix For: 3.1.2
>
> Attachments: 0005-TSFetchUrl-use-content-length-to-fire-after_body-eve.patch
>
>
> TSFetchUrl() does not fire the after_body event until the TCP connection is closed. The fix is to check the content-length when we receive more bytes and to fire the after_body event when all the byte are received.
> This looks like https://issues.apache.org/jira/browse/TS-817 and possibly https://issues.apache.org/jira/browse/TS-912
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1043) PATCH: teach TSFetchUrl to use the
content-length to find the after_body event
Posted by "James Peach (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach updated TS-1043:
----------------------------
Fix Version/s: (was: 3.1.2)
> PATCH: teach TSFetchUrl to use the content-length to find the after_body event
> ------------------------------------------------------------------------------
>
> Key: TS-1043
> URL: https://issues.apache.org/jira/browse/TS-1043
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP
> Reporter: James Peach
> Assignee: James Peach
> Attachments: 0005-TSFetchUrl-use-content-length-to-fire-after_body-eve.patch
>
>
> TSFetchUrl() does not fire the after_body event until the TCP connection is closed. The fix is to check the content-length when we receive more bytes and to fire the after_body event when all the byte are received.
> This looks like https://issues.apache.org/jira/browse/TS-817 and possibly https://issues.apache.org/jira/browse/TS-912
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira