You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by zh...@gmail.com on 2010/04/07 01:03:02 UTC

Set encoding type for HttpResponseBuilder when setting from string (issue816045)

Reviewers: shindig.remailer_gmail.com, johnfargo,

Description:

Issue found due to rewritters change.
Basically when a new response is created based on current response with
encoding different then utf8, and then setResponseString is called, the
encoding would be wrong.

The solution is to update encoding when calling setResponseString.



Please review this at http://codereview.appspot.com/816045/show

Affected files:
    
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java
    
java/gadgets/src/test/java/org/apache/shindig/gadgets/http/HttpResponseBuilderTest.java
    
java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/OAuthRequestTest.java
    
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyHandlerTest.java