You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/11/21 03:11:58 UTC
[commons-io] branch master updated: Use final.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git
The following commit(s) were added to refs/heads/master by this push:
new cd5a7d7 Use final.
cd5a7d7 is described below
commit cd5a7d7be8d4a071774ce4566231bf6f8c4f808d
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Nov 20 22:11:52 2020 -0500
Use final.
---
src/main/java/org/apache/commons/io/FileUtils.java | 4 ++--
src/main/java/org/apache/commons/io/file/PathUtils.java | 2 +-
src/main/java/org/apache/commons/io/filefilter/AndFileFilter.java | 2 +-
src/main/java/org/apache/commons/io/filefilter/FalseFileFilter.java | 4 ++--
.../java/org/apache/commons/io/filefilter/PathVisitorFileFilter.java | 2 +-
.../org/apache/commons/io/input/BufferedFileChannelInputStream.java | 4 ++--
.../java/org/apache/commons/io/input/CharSequenceInputStreamTest.java | 2 +-
7 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/main/java/org/apache/commons/io/FileUtils.java b/src/main/java/org/apache/commons/io/FileUtils.java
index 6ef2f4a..2df605c 100644
--- a/src/main/java/org/apache/commons/io/FileUtils.java
+++ b/src/main/java/org/apache/commons/io/FileUtils.java
@@ -2132,7 +2132,7 @@ public class FileUtils {
try {
final AccumulatorPathVisitor visitor = listAccumulate(directory, fileFilter, dirFilter);
return visitor.getFileList().stream().map(Path::toFile).collect(Collectors.toList());
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new IllegalArgumentException(e);
}
}
@@ -2180,7 +2180,7 @@ public class FileUtils {
final List<Path> list = visitor.getFileList();
list.addAll(visitor.getDirList());
return list.stream().map(Path::toFile).collect(Collectors.toList());
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new IllegalStateException(e);
}
}
diff --git a/src/main/java/org/apache/commons/io/file/PathUtils.java b/src/main/java/org/apache/commons/io/file/PathUtils.java
index f0ba36f..0ce9e6c 100644
--- a/src/main/java/org/apache/commons/io/file/PathUtils.java
+++ b/src/main/java/org/apache/commons/io/file/PathUtils.java
@@ -293,7 +293,7 @@ public final class PathUtils {
* @throws IOException if an I/O error occurs
* @since 2.9.0
*/
- public static Path createParentDirectories(final Path path, FileAttribute<?>... attrs) throws IOException {
+ public static Path createParentDirectories(final Path path, final FileAttribute<?>... attrs) throws IOException {
final Path parent = path.getParent();
if (parent == null) {
return null;
diff --git a/src/main/java/org/apache/commons/io/filefilter/AndFileFilter.java b/src/main/java/org/apache/commons/io/filefilter/AndFileFilter.java
index b1c6f42..090b0a6 100644
--- a/src/main/java/org/apache/commons/io/filefilter/AndFileFilter.java
+++ b/src/main/java/org/apache/commons/io/filefilter/AndFileFilter.java
@@ -68,7 +68,7 @@ public class AndFileFilter
*
* @param initialCapacity the initial capacity.
*/
- private AndFileFilter(int initialCapacity) {
+ private AndFileFilter(final int initialCapacity) {
this(new ArrayList<>(initialCapacity));
}
diff --git a/src/main/java/org/apache/commons/io/filefilter/FalseFileFilter.java b/src/main/java/org/apache/commons/io/filefilter/FalseFileFilter.java
index a1c09ce..46fdd5b 100644
--- a/src/main/java/org/apache/commons/io/filefilter/FalseFileFilter.java
+++ b/src/main/java/org/apache/commons/io/filefilter/FalseFileFilter.java
@@ -100,13 +100,13 @@ public class FalseFileFilter implements IOFileFilter, Serializable {
}
@Override
- public IOFileFilter and(IOFileFilter fileFilter) {
+ public IOFileFilter and(final IOFileFilter fileFilter) {
// FALSE AND expression <=> FALSE
return INSTANCE;
}
@Override
- public IOFileFilter or(IOFileFilter fileFilter) {
+ public IOFileFilter or(final IOFileFilter fileFilter) {
// FALSE OR expression <=> expression
return fileFilter;
}
diff --git a/src/main/java/org/apache/commons/io/filefilter/PathVisitorFileFilter.java b/src/main/java/org/apache/commons/io/filefilter/PathVisitorFileFilter.java
index 861f092..543a707 100644
--- a/src/main/java/org/apache/commons/io/filefilter/PathVisitorFileFilter.java
+++ b/src/main/java/org/apache/commons/io/filefilter/PathVisitorFileFilter.java
@@ -71,7 +71,7 @@ public class PathVisitorFileFilter extends AbstractFileFilter {
public FileVisitResult accept(final Path path, final BasicFileAttributes attributes) {
try {
return Files.isDirectory(path) ? pathVisitor.postVisitDirectory(path, null) : visitFile(path, attributes);
- } catch (IOException e) {
+ } catch (final IOException e) {
return handle(e);
}
}
diff --git a/src/main/java/org/apache/commons/io/input/BufferedFileChannelInputStream.java b/src/main/java/org/apache/commons/io/input/BufferedFileChannelInputStream.java
index 5443340..9cfac02 100644
--- a/src/main/java/org/apache/commons/io/input/BufferedFileChannelInputStream.java
+++ b/src/main/java/org/apache/commons/io/input/BufferedFileChannelInputStream.java
@@ -154,7 +154,7 @@ public final class BufferedFileChannelInputStream extends InputStream {
final Method cleanMethod = clsCleaner.getMethod("clean");
cleanMethod.invoke(cleaner);
}
- } catch (ReflectiveOperationException e) {
+ } catch (final ReflectiveOperationException e) {
throw new IllegalStateException(e);
}
} else {
@@ -165,7 +165,7 @@ public final class BufferedFileChannelInputStream extends InputStream {
final Field unsafeField = clsUnsafe.getDeclaredField("theUnsafe");
unsafeField.setAccessible(true);
cleanerMethod.invoke(unsafeField.get(null), buffer);
- } catch (ReflectiveOperationException e) {
+ } catch (final ReflectiveOperationException e) {
throw new IllegalStateException(e);
}
}
diff --git a/src/test/java/org/apache/commons/io/input/CharSequenceInputStreamTest.java b/src/test/java/org/apache/commons/io/input/CharSequenceInputStreamTest.java
index c728344..0278500 100644
--- a/src/test/java/org/apache/commons/io/input/CharSequenceInputStreamTest.java
+++ b/src/test/java/org/apache/commons/io/input/CharSequenceInputStreamTest.java
@@ -376,7 +376,7 @@ public class CharSequenceInputStreamTest {
int available = checkAvail(r, input.length());
assertEquals(available - 1, r.skip(available - 1)); // skip all but one
available = checkAvail(r, 1);
- byte[] buff = new byte[available];
+ final byte[] buff = new byte[available];
assertEquals(available, r.read(buff, 0, available));
}
}