You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "ivanzlenko (via GitHub)" <gi...@apache.org> on 2023/09/26 16:08:54 UTC
[GitHub] [ignite-3] ivanzlenko commented on a diff in pull request #2632: IGNITE-20494 sql command does not enter repl
ivanzlenko commented on code in PR #2632:
URL: https://github.com/apache/ignite-3/pull/2632#discussion_r1337459079
##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/Main.java:
##########
@@ -79,7 +79,7 @@ private static boolean isatty() {
/** Needed for immediate REPL mode and for running a command which will stay in REPL mode so we need to init it once. */
private static void initReplExecutor(MicronautFactory micronautFactory) throws Exception {
- ReplExecutorProvider replExecutorProvider = micronautFactory.create(ReplExecutorProvider.class);
+ ReplExecutorProviderImpl replExecutorProvider = micronautFactory.create(ReplExecutorProviderImpl.class);
Review Comment:
Overrefactored? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org