You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2021/09/14 04:20:00 UTC

[jira] [Commented] (SOLR-13998) Add thread safety annotation to classes

    [ https://issues.apache.org/jira/browse/SOLR-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17414710#comment-17414710 ] 

David Smiley commented on SOLR-13998:
-------------------------------------

Why do we want our own annotations instead of ones from, say, JCIP – [https://github.com/stephenc/jcip-annotations] e.g. net.jcip.annotations.ThreadSafe & net.jcip.annotations.NotThreadSafe (and Immutable & GuardedBy) ?  That's ASL licensed.  Also note these names are popular and available at a number of libs (e.g. javax.annotation.concurrent) and I think are more likely to be understood by tools rather than names with "Solr" in them.  I'm not sure yet if error-prone or some other static analysis tools makes use of such annotations; I looked today but didn't find definitive information.

> Add thread safety annotation to classes
> ---------------------------------------
>
>                 Key: SOLR-13998
>                 URL: https://issues.apache.org/jira/browse/SOLR-13998
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Anshum Gupta
>            Assignee: Anshum Gupta
>            Priority: Major
>             Fix For: 8.4, main (9.0)
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Add annotations that can be used to mark classes as thread safe / single threaded in Solr.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org