You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Rowan Kerr (JIRA)" <ji...@apache.org> on 2011/03/02 18:00:37 UTC
[jira] Created: (THRIFT-1079) Support i64 in AS3
Support i64 in AS3
------------------
Key: THRIFT-1079
URL: https://issues.apache.org/jira/browse/THRIFT-1079
Project: Thrift
Issue Type: Improvement
Components: AS3 - Compiler
Reporter: Rowan Kerr
Priority: Minor
Would be nice to have i64 support for AS3. Although it's not straight forward.
Found a previous bit of discussion about AS3 i64 support here:
http://mail-archives.apache.org/mod_mbox/incubator-thrift-dev/201002.mbox/%3cdfc1ae6d1002091950s3eb71f6dl1381ea1bece3ab3d@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1079) Support i64 in AS3
Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272989#comment-13272989 ]
Jake Farrell commented on THRIFT-1079:
--------------------------------------
reverted until this can be reworked to not break the release
> Support i64 in AS3
> ------------------
>
> Key: THRIFT-1079
> URL: https://issues.apache.org/jira/browse/THRIFT-1079
> Project: Thrift
> Issue Type: Improvement
> Components: AS3 - Compiler
> Reporter: Rowan Kerr
> Assignee: Jake Farrell
> Priority: Minor
> Attachments: THRIFT-1079_64_bit_support_in_as3.patch
>
>
> Would be nice to have i64 support for AS3. Although it's not straight forward.
> Found a previous bit of discussion about AS3 i64 support here:
> http://mail-archives.apache.org/mod_mbox/incubator-thrift-dev/201002.mbox/%3cdfc1ae6d1002091950s3eb71f6dl1381ea1bece3ab3d@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1079) Support i64 in AS3
Posted by "Ethan Urie (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Urie updated THRIFT-1079:
-------------------------------
Patch Info: Patch Available
> Support i64 in AS3
> ------------------
>
> Key: THRIFT-1079
> URL: https://issues.apache.org/jira/browse/THRIFT-1079
> Project: Thrift
> Issue Type: Improvement
> Components: AS3 - Compiler
> Reporter: Rowan Kerr
> Priority: Minor
> Attachments: THRIFT-1079_64_bit_support_in_as3.patch
>
>
> Would be nice to have i64 support for AS3. Although it's not straight forward.
> Found a previous bit of discussion about AS3 i64 support here:
> http://mail-archives.apache.org/mod_mbox/incubator-thrift-dev/201002.mbox/%3cdfc1ae6d1002091950s3eb71f6dl1381ea1bece3ab3d@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1079) Support i64 in AS3
Posted by "Ethan Urie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267396#comment-13267396 ]
Ethan Urie commented on THRIFT-1079:
------------------------------------
FWIW, there is a public Maven repo that is hosting as3crypto at: http://mlepicki.github.com/maven-repository/repository
> Support i64 in AS3
> ------------------
>
> Key: THRIFT-1079
> URL: https://issues.apache.org/jira/browse/THRIFT-1079
> Project: Thrift
> Issue Type: Improvement
> Components: AS3 - Compiler
> Reporter: Rowan Kerr
> Assignee: Jake Farrell
> Priority: Minor
> Attachments: THRIFT-1079_64_bit_support_in_as3.patch
>
>
> Would be nice to have i64 support for AS3. Although it's not straight forward.
> Found a previous bit of discussion about AS3 i64 support here:
> http://mail-archives.apache.org/mod_mbox/incubator-thrift-dev/201002.mbox/%3cdfc1ae6d1002091950s3eb71f6dl1381ea1bece3ab3d@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (THRIFT-1079) Support i64 in AS3
Posted by "Jake Farrell (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jake Farrell reopened THRIFT-1079:
----------------------------------
Assignee: Jake Farrell
> Support i64 in AS3
> ------------------
>
> Key: THRIFT-1079
> URL: https://issues.apache.org/jira/browse/THRIFT-1079
> Project: Thrift
> Issue Type: Improvement
> Components: AS3 - Compiler
> Reporter: Rowan Kerr
> Assignee: Jake Farrell
> Priority: Minor
> Attachments: THRIFT-1079_64_bit_support_in_as3.patch
>
>
> Would be nice to have i64 support for AS3. Although it's not straight forward.
> Found a previous bit of discussion about AS3 i64 support here:
> http://mail-archives.apache.org/mod_mbox/incubator-thrift-dev/201002.mbox/%3cdfc1ae6d1002091950s3eb71f6dl1381ea1bece3ab3d@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1079) Support i64 in AS3
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272998#comment-13272998 ]
Hudson commented on THRIFT-1079:
--------------------------------
Integrated in Thrift #461 (See [https://builds.apache.org/job/Thrift/461/])
Thrift-1079:Support i64 in AS3
Client: as3
Patch: Reverting
Reverting patch due to usage of non public library which breaks ability to export as3 client to maven central during a release. (Revision 1337007)
Result = SUCCESS
> Support i64 in AS3
> ------------------
>
> Key: THRIFT-1079
> URL: https://issues.apache.org/jira/browse/THRIFT-1079
> Project: Thrift
> Issue Type: Improvement
> Components: AS3 - Compiler
> Reporter: Rowan Kerr
> Assignee: Jake Farrell
> Priority: Minor
> Attachments: THRIFT-1079_64_bit_support_in_as3.patch
>
>
> Would be nice to have i64 support for AS3. Although it's not straight forward.
> Found a previous bit of discussion about AS3 i64 support here:
> http://mail-archives.apache.org/mod_mbox/incubator-thrift-dev/201002.mbox/%3cdfc1ae6d1002091950s3eb71f6dl1381ea1bece3ab3d@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1079) Support i64 in AS3
Posted by "Roger Meier (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier resolved THRIFT-1079.
---------------------------------
Resolution: Fixed
comitted
> Support i64 in AS3
> ------------------
>
> Key: THRIFT-1079
> URL: https://issues.apache.org/jira/browse/THRIFT-1079
> Project: Thrift
> Issue Type: Improvement
> Components: AS3 - Compiler
> Reporter: Rowan Kerr
> Priority: Minor
> Attachments: THRIFT-1079_64_bit_support_in_as3.patch
>
>
> Would be nice to have i64 support for AS3. Although it's not straight forward.
> Found a previous bit of discussion about AS3 i64 support here:
> http://mail-archives.apache.org/mod_mbox/incubator-thrift-dev/201002.mbox/%3cdfc1ae6d1002091950s3eb71f6dl1381ea1bece3ab3d@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1079) Support i64 in AS3
Posted by "Jake Farrell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252174#comment-13252174 ]
Jake Farrell commented on THRIFT-1079:
--------------------------------------
-1 for this patch, It introduces a dependency which is not publicly available via maven and will break our ability to push this to maven central for the next release
> Support i64 in AS3
> ------------------
>
> Key: THRIFT-1079
> URL: https://issues.apache.org/jira/browse/THRIFT-1079
> Project: Thrift
> Issue Type: Improvement
> Components: AS3 - Compiler
> Reporter: Rowan Kerr
> Priority: Minor
> Attachments: THRIFT-1079_64_bit_support_in_as3.patch
>
>
> Would be nice to have i64 support for AS3. Although it's not straight forward.
> Found a previous bit of discussion about AS3 i64 support here:
> http://mail-archives.apache.org/mod_mbox/incubator-thrift-dev/201002.mbox/%3cdfc1ae6d1002091950s3eb71f6dl1381ea1bece3ab3d@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1079) Support i64 in AS3
Posted by "Ethan Urie (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Urie updated THRIFT-1079:
-------------------------------
Attachment: THRIFT-1079_64_bit_support_in_as3.patch
Adding 64-bit AS3 support via as3crypto's BigInteger
> Support i64 in AS3
> ------------------
>
> Key: THRIFT-1079
> URL: https://issues.apache.org/jira/browse/THRIFT-1079
> Project: Thrift
> Issue Type: Improvement
> Components: AS3 - Compiler
> Reporter: Rowan Kerr
> Priority: Minor
> Attachments: THRIFT-1079_64_bit_support_in_as3.patch
>
>
> Would be nice to have i64 support for AS3. Although it's not straight forward.
> Found a previous bit of discussion about AS3 i64 support here:
> http://mail-archives.apache.org/mod_mbox/incubator-thrift-dev/201002.mbox/%3cdfc1ae6d1002091950s3eb71f6dl1381ea1bece3ab3d@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1079) Support i64 in AS3
Posted by "Ethan Urie (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237000#comment-13237000 ]
Ethan Urie commented on THRIFT-1079:
------------------------------------
I've attached a patch with 64-bit support via as3crypto's BigInteger.
I've also added a serializer and deserializer as well as a memory buffer.
Also fixed some casting in generated code.
To build, it expects as3crypto.swc to be in <thrift-trunk>/lib/as3/lib.
> Support i64 in AS3
> ------------------
>
> Key: THRIFT-1079
> URL: https://issues.apache.org/jira/browse/THRIFT-1079
> Project: Thrift
> Issue Type: Improvement
> Components: AS3 - Compiler
> Reporter: Rowan Kerr
> Priority: Minor
> Attachments: THRIFT-1079_64_bit_support_in_as3.patch
>
>
> Would be nice to have i64 support for AS3. Although it's not straight forward.
> Found a previous bit of discussion about AS3 i64 support here:
> http://mail-archives.apache.org/mod_mbox/incubator-thrift-dev/201002.mbox/%3cdfc1ae6d1002091950s3eb71f6dl1381ea1bece3ab3d@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1079) Support i64 in AS3
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252094#comment-13252094 ]
Hudson commented on THRIFT-1079:
--------------------------------
Integrated in Thrift #434 (See [https://builds.apache.org/job/Thrift/434/])
THRIFT-1079 Support i64 in AS3
Patch: Ethan Urie (Revision 1325048)
Result = SUCCESS
roger : http://svn.apache.org/viewvc/?view=rev&rev=1325048
Files :
* /thrift/trunk/compiler/cpp/src/generate/t_as3_generator.cc
* /thrift/trunk/lib/as3/build.xml
* /thrift/trunk/lib/as3/src/org/apache/thrift/TDeserializer.as
* /thrift/trunk/lib/as3/src/org/apache/thrift/TSerializer.as
* /thrift/trunk/lib/as3/src/org/apache/thrift/protocol/TBinaryProtocol.as
* /thrift/trunk/lib/as3/src/org/apache/thrift/protocol/TProtocol.as
* /thrift/trunk/lib/as3/src/org/apache/thrift/transport/TMemoryBuffer.as
> Support i64 in AS3
> ------------------
>
> Key: THRIFT-1079
> URL: https://issues.apache.org/jira/browse/THRIFT-1079
> Project: Thrift
> Issue Type: Improvement
> Components: AS3 - Compiler
> Reporter: Rowan Kerr
> Priority: Minor
> Attachments: THRIFT-1079_64_bit_support_in_as3.patch
>
>
> Would be nice to have i64 support for AS3. Although it's not straight forward.
> Found a previous bit of discussion about AS3 i64 support here:
> http://mail-archives.apache.org/mod_mbox/incubator-thrift-dev/201002.mbox/%3cdfc1ae6d1002091950s3eb71f6dl1381ea1bece3ab3d@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira