[GitHub] [incubator-hugegraph-toolchain] haohao0103 commented on a diff in pull request #480: fix: Spark with loader has dependency conflicts

["haohao0103 (via GitHub)" <gi...@apache.org>]

haohao0103 commented on code in PR #480:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/480#discussion_r1259091110


##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/executor/LoadOptions.java:
##########
@@ -233,6 +233,10 @@ public class LoadOptions implements Serializable {
                description = "hbaseZKParent")
     public String hbaseZKParent;
 
+    @Parameter(names = {"--action-type"},  arity = 1,

Review Comment:
   Yes, only hbase is implemented at this stage
   



##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/constant/Constants.java:
##########
@@ -81,4 +81,5 @@ public final class Constants {
     public static final String LOAD_DATA_PARSE_SUFFIX = "parse";
     public static final String LOAD_DATA_SER_SUFFIX = "ser";
     public static final String LOAD_DATA_INSERT_SUFFIX = "insert";
+    public static final String DELETE_ACTION = "delete";

Review Comment:
   thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org