[jira] [Commented] (HIVE-25842) Reimplement delta file metric collection

["László Pintér (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-25842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480121#comment-17480121 ] 

László Pintér commented on HIVE-25842:
--------------------------------------

Submitted to master. Thanks [~klcopp] and [~dkuzmenko] for the review

> Reimplement delta file metric collection
> ----------------------------------------
>
>                 Key: HIVE-25842
>                 URL: https://issues.apache.org/jira/browse/HIVE-25842
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Pintér
>            Assignee: László Pintér
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 7h
>  Remaining Estimate: 0h
>
> FUNCTIONALITY: Metrics are collected only when a Tez query runs a table (select * and select count( * ) don't update the metrics)
> Metrics aren't updated after compaction or cleaning after compaction, so users will probably see "issues" with compaction (like many active or obsolete or small deltas) that don't exist.
> RISK: Metrics are collected during queries – we tried to put a try-catch around each method in DeltaFilesMetricsReporter but of course this isn't foolproof. This is a HUGE performance and functionality liability. Tests caught some issues, but our tests aren't perfect.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)