[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2690: [ST-Engine][Starter] Add seatunnel own engine starter and e2e

[GitBox <gi...@apache.org>]

hailin0 commented on code in PR #2690:
URL: https://github.com/apache/incubator-seatunnel/pull/2690#discussion_r966598012


##########
seatunnel-core/seatunnel-spark-starter/src/main/java/org/apache/seatunnel/core/starter/spark/SparkStarter.java:
##########
@@ -134,7 +134,7 @@ static SparkStarter getInstance(String[] args) {
     private static SparkCommandArgs parseCommandArgs(String[] args) {
         SparkCommandArgs commandArgs = new SparkCommandArgs();
         JCommander commander = JCommander.newBuilder()
-                .programName("start-seatunnel-spark.sh")
+                .programName("start-seatunnel-spark-connector-v2.sh")

Review Comment:
   as above



##########
seatunnel-core/seatunnel-flink-starter/src/main/java/org/apache/seatunnel/core/starter/flink/utils/CommandLineUtils.java:
##########
@@ -43,10 +42,10 @@ public static FlinkCommandArgs parseFlinkArgs(String[] args) {
         return flinkCommandArgs;
     }
 
-    public static FlinkCommandArgs parseCommandArgs(String[] args, FlinkJobType jobType) {
+    public static FlinkCommandArgs parseCommandArgs(String[] args) {
         FlinkCommandArgs flinkCommandArgs = new FlinkCommandArgs();
         JCommander jCommander = JCommander.newBuilder()
-            .programName(jobType.getType())
+            .programName("start-seatunnel-flink-connector-v2.sh")

Review Comment:
   Need to update [this](https://github.com/apache/incubator-seatunnel/pull/2675/files#diff-d4c3677ccf36bf18f8b9fde06fbbca8c3b686d43afb7c65d19105069f142843dR34) when merging into dev later



##########
seatunnel-e2e/seatunnel-engine-e2e/pom.xml:
##########
@@ -27,6 +27,12 @@
     <modelVersion>4.0.0</modelVersion>
 
     <artifactId>seatunnel-engine-e2e</artifactId>
+    <packaging>pom</packaging>
+
+    <modules>
+        <module>seatunnel-engine-e2e-base</module>
+        <module>seatunnel-engine-connector-console-e2e</module>

Review Comment:
   module name style
    
   reference
   https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-flink-connector-v2-e2e
   https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-spark-connector-v2-e2e



##########
seatunnel-e2e/seatunnel-engine-e2e/seatunnel-engine-connector-console-e2e/src/test/resources/fakesource_to_console.conf:
##########
@@ -0,0 +1,42 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+######
+###### This config file is a demonstration of streaming processing in seatunnel config
+######
+
+env {
+  job.mode = "BATCH"
+}
+
+source {
+  # This is a example source plugin **only for test and demonstrate the feature source plugin**
+    FakeSource {
+      result_table_name = "fake"
+      field_name = "name,age"
+    }
+}
+
+transform {
+}
+
+sink {
+  console {
+  }
+
+  # If you would like to get more information about how to configure seatunnel and see full list of sink plugins,
+  # please go to https://seatunnel.apache.org/docs/flink/configuration/sink-plugins/Console

Review Comment:
   remove



##########
seatunnel-engine/seatunnel-engine-client/pom.xml:
##########
@@ -68,7 +68,7 @@
         </dependency>
         <dependency>
             <groupId>org.apache.seatunnel</groupId>
-            <artifactId>connector-file-local</artifactId>
+            <artifactId>connector-console</artifactId>

Review Comment:
   St-client depends on connector feeling strange



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org