You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by rob05c <gi...@git.apache.org> on 2017/02/07 16:48:13 UTC
[GitHub] incubator-trafficcontrol pull request #261: Cleanup Traffic Monitor 2.0 TODO...
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/261
Cleanup Traffic Monitor 2.0 TODOs, improve request time accuracy
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob05c/incubator-trafficcontrol tm2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/261.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #261
----
commit 8d3ae35e78908a3a6e894c98c288b2fe7410004b
Author: Robert Butts <ro...@gmail.com>
Date: 2017-02-06T22:46:59Z
Fix TM2 wrong TODOs, fix magic strings
commit 248af900be682326b8a0073cc0b25c8862107934
Author: Robert Butts <ro...@gmail.com>
Date: 2017-02-06T22:54:56Z
Fix TM2 to pass reqtime from fetcher for accuracy
commit d48e6b92f39f6fd77459aa0c7615a469abbaf820
Author: Robert Butts <ro...@gmail.com>
Date: 2017-02-07T16:46:35Z
Remove TM2 wrong todo
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #261: Cleanup Traffic Monitor 2.0 TODO...
Posted by rob05c <gi...@git.apache.org>.
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/261#discussion_r99869120
--- Diff: traffic_monitor_golang/traffic_monitor/trafficopsdata/trafficopsdata.go ---
@@ -35,7 +35,6 @@ import (
// 2. .*\.foo\..* expressions, where foo is a direct string match with no regular expression matching characters
// 3. Everything else
// This allows us to do a cheap match on 1 and 2, and only regex match the uncommon case.
-// TODO performance tests, whether Go compiled *Regexp is relevantly slower than `strings.Contains` for direct and .foo. matches
--- End diff --
I tested this. It's significantly slower.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #261: Cleanup Traffic Monitor 2.0 TODO...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/261
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---