You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/07 21:34:35 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #3044: Split out arrow-csv (#2594)
tustvold opened a new pull request, #3044:
URL: https://github.com/apache/arrow-rs/pull/3044
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Part of #2594
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3044: Split out arrow-csv (#2594)
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3044:
URL: https://github.com/apache/arrow-rs/pull/3044#discussion_r1015926098
##########
arrow-csv/src/writer.rs:
##########
@@ -595,105 +590,6 @@ sed do eiusmod tempor,-556132.25,1,,2019-04-18T02:45:55.555000000,23:46:03,foo
);
}
- #[cfg(feature = "chrono-tz")]
Review Comment:
Moved to integration test in arrow crate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3044: Split out arrow-csv (#2594)
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3044:
URL: https://github.com/apache/arrow-rs/pull/3044#discussion_r1015926664
##########
arrow/Cargo.toml:
##########
@@ -265,5 +264,9 @@ harness = false
required-features = ["test_utils"]
[[test]]
-name = "ipc_integration"
+name = "ipc"
Review Comment:
Opted to remove the redundant integration suffix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3044: Split out arrow-csv (#2594)
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3044:
URL: https://github.com/apache/arrow-rs/pull/3044#discussion_r1016993981
##########
arrow-csv/src/reader.rs:
##########
@@ -22,11 +22,11 @@
//!
//! Example:
//!
-//! ```
-//! use arrow::csv;
-//! use arrow::datatypes::{DataType, Field, Schema};
-//! use std::fs::File;
-//! use std::sync::Arc;
+//! ```no_run
Review Comment:
Because the file it reads is no longer part of this crate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3044: Split out arrow-csv (#2594)
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3044:
URL: https://github.com/apache/arrow-rs/pull/3044#discussion_r1015925890
##########
arrow-csv/src/reader.rs:
##########
@@ -1131,436 +1131,11 @@ impl ReaderBuilder {
mod tests {
use super::*;
- use std::fs::File;
- use std::io::{Cursor, Write};
+ use std::io::Write;
use tempfile::NamedTempFile;
- use crate::array::*;
- use crate::compute::cast;
- use crate::datatypes::Field;
use chrono::prelude::*;
- #[test]
Review Comment:
These are moved to an integration test in the arrow crate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #3044: Split out arrow-csv (#2594)
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3044:
URL: https://github.com/apache/arrow-rs/pull/3044#discussion_r1016475111
##########
arrow-csv/Cargo.toml:
##########
@@ -0,0 +1,53 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[package]
+name = "arrow-csv"
+version = "26.0.0"
+description = "Support for the Arrow CSV format"
Review Comment:
```suggestion
description = "Support for parsing CSV format into the Arrow format"
```
##########
arrow-csv/src/reader.rs:
##########
@@ -22,11 +22,11 @@
//!
//! Example:
//!
-//! ```
-//! use arrow::csv;
-//! use arrow::datatypes::{DataType, Field, Schema};
-//! use std::fs::File;
-//! use std::sync::Arc;
+//! ```no_run
Review Comment:
Why is this changed to "no_run"? It seems like it is a good thing to keep testing, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3044: Split out arrow-csv (#2594)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3044:
URL: https://github.com/apache/arrow-rs/pull/3044#issuecomment-1307783228
Benchmark runs are scheduled for baseline = a950b52ec83e5ac14e147f9605f871ba6bd06ee0 and contender = fe3318bba24abfe572fa037a0b8805a15bdf5c45. fe3318bba24abfe572fa037a0b8805a15bdf5c45 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7dd747a84c0243a88e1a1a2aa05a3579...026ce490172d497bbd775912256325b6/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/02cd6b6912274d48aedf2c65024a402c...32b72801fb7f4349991690f2db9ae849/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/c6a75fa239a84f8b95bec98f98e7fe49...fd6f267e8a2645b1a1a1ac063e0154c6/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/643ef7c4249946f28dc11f76bc917ac3...79a57b222eed43ab99836a276850754c/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3044: Split out arrow-csv (#2594)
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3044:
URL: https://github.com/apache/arrow-rs/pull/3044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org