You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "slow-J (via GitHub)" <gi...@apache.org> on 2024/06/18 11:00:36 UTC
[PR] Removing usage of TopScoreDocCollector + TopFieldCollector deprecated methods (#create, #createSharedManager) [lucene]
slow-J opened a new pull request, #13500:
URL: https://github.com/apache/lucene/pull/13500
Removing usage of TopScoreDocCollector + TopFieldCollector deprecated methods (#create, #createSharedManager)
Closes #13499
Copying description from issue:
These methods were deprecated in https://github.com/apache/lucene/pull/240 which is part of Lucene 10.0.
Since they are not marked for deprecation in Lucene 9.x, they will not be removed with Lucene 10.0 release (unless we want to deprecate them in 9.x in another backport commit?), but I still think we should remove the internal usage so it will be quicker to remove the methods when the time comes.
This is a 1:1 change to remove the usages.
Test command:
`./gradlew clean; ./gradlew tidy; ./gradlew check`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Removing usage of TopScoreDocCollector + TopFieldCollector deprecated methods (#create, #createSharedManager) [lucene]
Posted by "javanna (via GitHub)" <gi...@apache.org>.
javanna merged PR #13500:
URL: https://github.com/apache/lucene/pull/13500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Removing usage of TopScoreDocCollector + TopFieldCollector deprecated methods (#create, #createSharedManager) [lucene]
Posted by "slow-J (via GitHub)" <gi...@apache.org>.
slow-J commented on PR #13500:
URL: https://github.com/apache/lucene/pull/13500#issuecomment-2253605645
Thanks @javanna! I fixed the conflicts in `TestTopDocsMerge`, removing the changes that are no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Removing usage of TopScoreDocCollector + TopFieldCollector deprecated methods (#create, #createSharedManager) [lucene]
Posted by "javanna (via GitHub)" <gi...@apache.org>.
javanna commented on PR #13500:
URL: https://github.com/apache/lucene/pull/13500#issuecomment-2253270272
heya @slow-J thanks for the PR, and sorry for the delay in reviewing it. I was cleaning things up in this area as well, and ended up making changes to `TestTopDocsMerge` that are causing merge conflicts in your PR. Besides that, I think that this is a good step forward and I am happy to review it and merge it. Could you perhaps remove the changes to TestTopDocsMerge that are no longer necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Removing usage of TopScoreDocCollector + TopFieldCollector deprecated methods (#create, #createSharedManager) [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13500:
URL: https://github.com/apache/lucene/pull/13500#issuecomment-2204763139
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Removing usage of TopScoreDocCollector + TopFieldCollector deprecated methods (#create, #createSharedManager) [lucene]
Posted by "javanna (via GitHub)" <gi...@apache.org>.
javanna commented on PR #13500:
URL: https://github.com/apache/lucene/pull/13500#issuecomment-2255396796
Thanks @slow-J !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Removing usage of TopScoreDocCollector + TopFieldCollector deprecated methods (#create, #createSharedManager) [lucene]
Posted by "slow-J (via GitHub)" <gi...@apache.org>.
slow-J commented on PR #13500:
URL: https://github.com/apache/lucene/pull/13500#issuecomment-2255548859
Thanks @javanna for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org