You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Di Li <di...@ca.ibm.com> on 2017/01/03 16:09:55 UTC

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review160392
-----------------------------------------------------------


Ship it!




Ship It!

- Di Li


On Dec. 24, 2016, 7:12 a.m., ping wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2016, 7:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
>     https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Change default Spark configuration property in Oozie configuration settings to valid value
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py a2d725c 
>   ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> -------
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>


Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

Posted by Di Li <di...@ca.ibm.com>.

> On Jan. 3, 2017, 4:09 p.m., Di Li wrote:
> > Ship It!
> 
> ping wang wrote:
>     Hi Di, could you please help commit the code? Thanks!

Done. Please close this RB request.


- Di


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review160392
-----------------------------------------------------------


On Dec. 24, 2016, 7:12 a.m., ping wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2016, 7:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
>     https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Change default Spark configuration property in Oozie configuration settings to valid value
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py a2d725c 
>   ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> -------
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>


Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

Posted by ping wang <su...@gmail.com>.

> On \u4e00\u6708 3, 2017, 4:09 p.m., Di Li wrote:
> > Ship It!

Hi Di, could you please help commit the code? Thanks!


- ping


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review160392
-----------------------------------------------------------


On \u5341\u4e8c\u6708 24, 2016, 7:12 a.m., ping wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> -----------------------------------------------------------
> 
> (Updated \u5341\u4e8c\u6708 24, 2016, 7:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
>     https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Change default Spark configuration property in Oozie configuration settings to valid value
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py a2d725c 
>   ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> -------
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>