You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/08 20:46:01 UTC

[jira] [Commented] (GEODE-4225) Extend ClusterStartupRule to instantiate members and clients of a particular version

    [ https://issues.apache.org/jira/browse/GEODE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317035#comment-16317035 ] 

ASF GitHub Bot commented on GEODE-4225:
---------------------------------------

PurelyApplied opened a new pull request #1250: GEODE-4225: Extend ClusterStartupRule to specify member / client version.
URL: https://github.com/apache/geode/pull/1250
 
 
   * Correct typo: "Embeded" -> "Embedded"
   * Reorder class to resemble call heirarchy
   * Remove startClient signature inconsistent with other method calls
   
   -----
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Extend ClusterStartupRule to instantiate members and clients of a particular version
> ------------------------------------------------------------------------------------
>
>                 Key: GEODE-4225
>                 URL: https://issues.apache.org/jira/browse/GEODE-4225
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Patrick Rhomberg
>            Assignee: Patrick Rhomberg
>
> Many tests, particularly those testing rolling upgrade, would benefit from the consistency of the ClusterStartupRule but require clients of a specific version.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)