You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by "Sumit Kumar (JIRA)" <ji...@apache.org> on 2013/12/13 04:09:07 UTC

[jira] [Updated] (DRILL-324) Contributing wiki should mention the correct command to generate patch

     [ https://issues.apache.org/jira/browse/DRILL-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sumit Kumar updated DRILL-324:
------------------------------

    Description: 
Sections on creating a patch [1] and applying a patch [2] are not in sync. To be consistent, [1] should mention the correct command i.e. [3] instead of [4]

1. https://cwiki.apache.org/confluence/display/DRILL/Contributing#Contributing-Creatingapatch
2. https://cwiki.apache.org/confluence/display/DRILL/Contributing#Contributing-Applyingapatch
3. git diff --no-prefix master <my_branch> > DRILL-1234.1.patch.txt (correct command)
4. git diff master <my_branch> > DRILL-1234.1.patch.txt (current but incompatible command)

  was:
Sections on creating a patch [1] and applying a patch [2] are not in sync. To be consistent, [1] should mention the correct command i.e. [3] instead of [4]

1. https://cwiki.apache.org/confluence/display/DRILL/Contributing#Contributing-Creatingapatch
2. https://cwiki.apache.org/confluence/display/DRILL/Contributing#Contributing-Applyingapatch
3. git diff master --no-prefix <my_branch> > DRILL-1234.1.patch.txt (correct command)
4. git diff master <my_branch> > DRILL-1234.1.patch.txt (current but incompatible command)


> Contributing wiki should mention the correct command to generate patch
> ----------------------------------------------------------------------
>
>                 Key: DRILL-324
>                 URL: https://issues.apache.org/jira/browse/DRILL-324
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Sumit Kumar
>            Priority: Minor
>
> Sections on creating a patch [1] and applying a patch [2] are not in sync. To be consistent, [1] should mention the correct command i.e. [3] instead of [4]
> 1. https://cwiki.apache.org/confluence/display/DRILL/Contributing#Contributing-Creatingapatch
> 2. https://cwiki.apache.org/confluence/display/DRILL/Contributing#Contributing-Applyingapatch
> 3. git diff --no-prefix master <my_branch> > DRILL-1234.1.patch.txt (correct command)
> 4. git diff master <my_branch> > DRILL-1234.1.patch.txt (current but incompatible command)



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)