You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Glenn McAllister <gl...@somanetworks.com> on 2001/01/24 18:02:03 UTC
Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs
Javadoc.java
glennm@apache.org wrote:
> glennm 01/01/24 08:56:47
>
> Modified: src/main/org/apache/tools/ant/taskdefs Javadoc.java
> Log:
> Resolving package names now occurs with the
> use of a private FileSet. This provides
> the use of the default excludes patterns,
> which include **/CVS/**, preventing any
> .java files in a CVS/Base directory from
> being included.
>
> Just in case someone does ever have a
> package named blah.CVS, I added the
> "defaultexcludes" attribute.
Just in case anyone is wondering, I had to create my include strings as
org/blah/blah/**
and test for .java files in each included directory, because doing
org/blah/blah/**/*.java
returns 0 included directories. Anyone care to explain the logic of that one to me? If a
file is included, should its directory not be included as well?
Glenn McAllister
Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs
Javadoc.java
Posted by Glenn McAllister <gl...@somanetworks.com>.
Stefan Bodewig wrote:
> Glenn McAllister <gl...@somanetworks.com> wrote:
>
> > Just in case anyone is wondering, I had to create my include strings
> > as
> >
> > org/blah/blah/**
> >
> > and test for .java files in each included directory, because doing
> >
> > org/blah/blah/**/*.java
> >
> > returns 0 included directories.
>
> Right, but you could get to your directory by calling File.getParent()
> for the included files. Not sure, but this might be more efficient
> than scanning the filesystem twice.
Fair enough. If I end up touching this again, I'll probably do it your
way. However, it is pretty fast now, so maybe not. :-)
> Hmm, I don't know why Arnout decided to name the things like he did,
> but the logic is that an object is labeled included if it matches one
> of the include patterns and no exclude pattern. Obviously a directory
> doesn't match a **/*.java pattern, so it is not included by this
> definition.
I guess it just seems counterintuitive to me that if the file is
included, the directory isn't necessarily included and I have to do
tricks to get that extra information.
Glenn McAllister
Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs Javadoc.java
Posted by Stefan Bodewig <bo...@apache.org>.
Glenn McAllister <gl...@somanetworks.com> wrote:
> Just in case anyone is wondering, I had to create my include strings
> as
>
> org/blah/blah/**
>
> and test for .java files in each included directory, because doing
>
> org/blah/blah/**/*.java
>
> returns 0 included directories.
Right, but you could get to your directory by calling File.getParent()
for the included files. Not sure, but this might be more efficient
than scanning the filesystem twice.
> Anyone care to explain the logic of that one to me?
Hmm, I don't know why Arnout decided to name the things like he did,
but the logic is that an object is labeled included if it matches one
of the include patterns and no exclude pattern. Obviously a directory
doesn't match a **/*.java pattern, so it is not included by this
definition.
Stefan